You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/19 12:12:05 UTC
[GitHub] [airflow] ANiteckiP opened a new pull request #7466: [AIRFLOW-XXXX]
Delete obsolete and duplicated paragraph from CONTRIBUTING.rst
ANiteckiP opened a new pull request #7466: [AIRFLOW-XXXX] Delete obsolete and duplicated paragraph from CONTRIBUTING.rst
URL: https://github.com/apache/airflow/pull/7466
The paragraph about tests in `CONTRIBUTING.rst` contains text duplicated from the beginning of `TESTING.rst` file. Furthermore, it grew out of sync with the latter, containing obsolete info about `nose`. Let's just leave the link to `TESTING.rst` for simplicity.
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [ ] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ANiteckiP commented on issue #7466: [AIRFLOW-XXXX] Delete
obsolete and duplicated paragraph from CONTRIBUTING.rst
Posted by GitBox <gi...@apache.org>.
ANiteckiP commented on issue #7466: [AIRFLOW-XXXX] Delete obsolete and duplicated paragraph from CONTRIBUTING.rst
URL: https://github.com/apache/airflow/pull/7466#issuecomment-588201311
@potiuk Do we support both `nose` and `pytest` at the same time? Why?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] nuclearpinguin commented on issue #7466: [AIRFLOW-XXXX]
Delete obsolete and duplicated paragraph from CONTRIBUTING.rst
Posted by GitBox <gi...@apache.org>.
nuclearpinguin commented on issue #7466: [AIRFLOW-XXXX] Delete obsolete and duplicated paragraph from CONTRIBUTING.rst
URL: https://github.com/apache/airflow/pull/7466#issuecomment-588196735
I would leave list of test types without details and link to a specific section in TESTING for more details (that's mean adjusting existing link) :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] ANiteckiP edited a comment on issue #7466: [AIRFLOW-XXXX]
Delete obsolete and duplicated paragraph from CONTRIBUTING.rst
Posted by GitBox <gi...@apache.org>.
ANiteckiP edited a comment on issue #7466: [AIRFLOW-XXXX] Delete obsolete and duplicated paragraph from CONTRIBUTING.rst
URL: https://github.com/apache/airflow/pull/7466#issuecomment-588201311
@potiuk Do we support both `nose` and `pytest` at the same time? Why?
And if we do that, we should state that explicitely in a single place. Mentioning only `nose` in one file and only `pytest` in the other is confusing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #7466:
[AIRFLOW-XXXX] Update tests info in CONTRIBUTING.rst
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #7466: [AIRFLOW-XXXX] Update tests info in CONTRIBUTING.rst
URL: https://github.com/apache/airflow/pull/7466#discussion_r382125374
##########
File path: CONTRIBUTING.rst
##########
@@ -326,13 +326,13 @@ Test Infrastructure
We support the following types of tests:
-* **Unit tests** are Python ``nose`` tests launched with ``run-tests``.
+* **Unit tests** are Python tests launched with ``pytest``.
Unit tests are available both in the `Breeze environment <BREEZE.rst>`_
and `local virtualenv <LOCAL_VIRTUALENV.rst>`_.
* **Integration tests** are available in the Breeze development environment
that is also used for Airflow Travis CI tests. Integration test are special tests that require
- additional services running, such as Postgres,Mysql, Kerberos, etc. These tests are not yet
+ additional services running, such as Postgres, Mysql, Kerberos, etc. These tests are not yet
Review comment:
```suggestion
additional services running, such as Postgres, Mysql, Kerberos, etc.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk edited a comment on issue #7466: [AIRFLOW-XXXX]
Delete obsolete and duplicated paragraph from CONTRIBUTING.rst
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #7466: [AIRFLOW-XXXX] Delete obsolete and duplicated paragraph from CONTRIBUTING.rst
URL: https://github.com/apache/airflow/pull/7466#issuecomment-588194339
Well. @ANiteckiP -> it's not obsolete (some internals are but not the whole chapter). It's what we support now especially after #7389
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] boring-cyborg[bot] commented on issue #7466:
[AIRFLOW-XXXX] Update tests info in CONTRIBUTING.rst
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #7466: [AIRFLOW-XXXX] Update tests info in CONTRIBUTING.rst
URL: https://github.com/apache/airflow/pull/7466#issuecomment-589893723
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk edited a comment on issue #7466: [AIRFLOW-XXXX]
Delete obsolete and duplicated paragraph from CONTRIBUTING.rst
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on issue #7466: [AIRFLOW-XXXX] Delete obsolete and duplicated paragraph from CONTRIBUTING.rst
URL: https://github.com/apache/airflow/pull/7466#issuecomment-588206813
> @potiuk Do we support both `nose` and `pytest` at the same time? Why?
>
> And if we do that, we should state that explicitely in a single place. Mentioning only `nose` in one file and only `pytest` in the other is confusing.
No absolutely not. We only use pytest. Mentioning nosetests is clearly obsolete and should be replaced by pytest or removed - I think there is no need to go into details as @nuclearpinguin mentions (but the whole chapter should remain as is - listing the test case types we have).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7466: [AIRFLOW-XXXX] Delete
obsolete and duplicated paragraph from CONTRIBUTING.rst
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7466: [AIRFLOW-XXXX] Delete obsolete and duplicated paragraph from CONTRIBUTING.rst
URL: https://github.com/apache/airflow/pull/7466#issuecomment-588194339
Well. @ANiteckiP -> it's not at all obsolete. It's what we support now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] boring-cyborg[bot] commented on issue #7466:
[AIRFLOW-XXXX] Delete obsolete and duplicated paragraph from CONTRIBUTING.rst
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #7466: [AIRFLOW-XXXX] Delete obsolete and duplicated paragraph from CONTRIBUTING.rst
URL: https://github.com/apache/airflow/pull/7466#issuecomment-588193236
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itβs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
Apache Airflow is a community-driven project and together we are making it better π.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://apache-airflow-slack.herokuapp.com/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #7466:
[AIRFLOW-XXXX] Update tests info in CONTRIBUTING.rst
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #7466: [AIRFLOW-XXXX] Update tests info in CONTRIBUTING.rst
URL: https://github.com/apache/airflow/pull/7466#discussion_r382125829
##########
File path: CONTRIBUTING.rst
##########
@@ -326,13 +326,13 @@ Test Infrastructure
We support the following types of tests:
-* **Unit tests** are Python ``nose`` tests launched with ``run-tests``.
+* **Unit tests** are Python tests launched with ``pytest``.
Unit tests are available both in the `Breeze environment <BREEZE.rst>`_
and `local virtualenv <LOCAL_VIRTUALENV.rst>`_.
* **Integration tests** are available in the Breeze development environment
that is also used for Airflow Travis CI tests. Integration test are special tests that require
- additional services running, such as Postgres,Mysql, Kerberos, etc. These tests are not yet
+ additional services running, such as Postgres, Mysql, Kerberos, etc. These tests are not yet
clearly marked as integration tests but soon they will be clearly separated by the ``pytest`` annotations.
Review comment:
```suggestion
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on issue #7466: [AIRFLOW-XXXX] Delete
obsolete and duplicated paragraph from CONTRIBUTING.rst
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #7466: [AIRFLOW-XXXX] Delete obsolete and duplicated paragraph from CONTRIBUTING.rst
URL: https://github.com/apache/airflow/pull/7466#issuecomment-588206813
> @potiuk Do we support both `nose` and `pytest` at the same time? Why?
>
> And if we do that, we should state that explicitely in a single place. Mentioning only `nose` in one file and only `pytest` in the other is confusing.
No absolutely not. We only use pytest. Mentioning nosetests is clearly obsolete and should be replaced by pytest or removed - I think there is no need to go into details as @nuclearpinguin mentions (but the whole chapter should remain as is - listing the test cases we have).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil merged pull request #7466: [AIRFLOW-XXXX] Update
tests info in CONTRIBUTING.rst
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #7466: [AIRFLOW-XXXX] Update tests info in CONTRIBUTING.rst
URL: https://github.com/apache/airflow/pull/7466
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on issue #7466: [AIRFLOW-XXXX] Update
tests info in CONTRIBUTING.rst
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #7466: [AIRFLOW-XXXX] Update tests info in CONTRIBUTING.rst
URL: https://github.com/apache/airflow/pull/7466#issuecomment-589893753
Thanks @ANiteckiP π
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services