[GitHub] formath commented on a change in pull request #8460: cpu sparse embedding op

[GitBox <gi...@apache.org>]

formath commented on a change in pull request #8460: cpu sparse embedding op
URL: https://github.com/apache/incubator-mxnet/pull/8460#discussion_r147954638
 
 

 ##########
 File path: src/ndarray/ndarray.cc
 ##########
 @@ -65,10 +65,10 @@ nnvm::Symbol NDArray::get_autograd_symbol() const {
 
 NDArray NDArray::Reshape(const TShape &shape) const {
   CHECK(!is_none()) << "NDArray is not initialized";
-  CHECK(storage_type() == kDefaultStorage) << "Reshape for storage type " <<
-        storage_type() << " is not implemented yet";
-  CHECK(storage_type() == kDefaultStorage) << "Reshape for storage type " <<
-        storage_type() << " is not implemented yet";
+  auto stype = storage_type();
+  // reshape is not supported for non-default ndarray with dismatching shapes
+  CHECK((shape_ == shape) || stype == kDefaultStorage)
 
 Review comment:
   csr and rsp may have a same shape?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services