You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@myfaces.apache.org by hn...@apache.org on 2023/11/14 10:16:33 UTC

(myfaces-tobago) branch tobago-5.x updated: build(deps-dev): typescript-eslint 6.11.0

This is an automated email from the ASF dual-hosted git repository.

hnoeth pushed a commit to branch tobago-5.x
in repository https://gitbox.apache.org/repos/asf/myfaces-tobago.git


The following commit(s) were added to refs/heads/tobago-5.x by this push:
     new 35d53c8a8f build(deps-dev): typescript-eslint 6.11.0
35d53c8a8f is described below

commit 35d53c8a8ffd99872fc2bd780966f1aeffa9a736
Author: Henning Noeth <hn...@apache.org>
AuthorDate: Tue Nov 14 10:53:23 2023 +0100

    build(deps-dev): typescript-eslint 6.11.0
    
    * update typescript-eslint to 6.11.0
    * update NodeJs to 20.9.0
    * use recommended eslint config
    * adjust eslint rules to let current code compile
---
 pom.xml                   |  4 ++--
 tobago-theme/.eslintrc.js | 60 ++++++++++-------------------------------------
 tobago-theme/package.json |  4 ++--
 3 files changed, 17 insertions(+), 51 deletions(-)

diff --git a/pom.xml b/pom.xml
index a6b54de16d..f064b257d0 100644
--- a/pom.xml
+++ b/pom.xml
@@ -996,8 +996,8 @@
 
             <!-- optional -->
             <configuration>
-              <nodeVersion>v16.18.1</nodeVersion>
-              <!-- contains npm version 8.19.2 -->
+              <nodeVersion>v20.9.0</nodeVersion>
+              <!-- contains npm version 10.1.0 -->
               <!--
               todo: next version not running on Jenkins ubuntu - https://issues.apache.org/jira/browse/INFRA-23954
               todo: Update Jenkins file to use "docker"
diff --git a/tobago-theme/.eslintrc.js b/tobago-theme/.eslintrc.js
index d637876bc0..882644522a 100644
--- a/tobago-theme/.eslintrc.js
+++ b/tobago-theme/.eslintrc.js
@@ -19,9 +19,9 @@ module.exports = {
   parser: '@typescript-eslint/parser',
   plugins: ['@typescript-eslint'],
   extends: [
+    'eslint:recommended',
     'plugin:@typescript-eslint/recommended',
-    'plugin:@typescript-eslint/eslint-recommended',
-    'plugin:@typescript-eslint/recommended'
+    'plugin:@typescript-eslint/stylistic'
   ],
   parserOptions: {
     project: './tsconfig.json',
@@ -29,58 +29,24 @@ module.exports = {
     sourceType: 'module',
   },
   rules: {
-    "prefer-const": "warn",
-    "prefer-rest-params": "warn",
-    "no-case-declarations": "warn",
-    "no-irregular-whitespace": "warn",
-    "no-constant-condition": "warn",
-    "no-inner-declarations": "warn",
-    "@typescript-eslint/ban-ts-comment": "error",
-    "@typescript-eslint/no-implied-eval": "error",
-    "@typescript-eslint/unbound-method": "warn",
-    "@typescript-eslint/no-unsafe-call": "warn",
-    "@typescript-eslint/no-unsafe-assignment": "warn",
-    "@typescript-eslint/no-unsafe-member-access": "warn",
-    "@typescript-eslint/restrict-template-expressions": "warn",
+    "@typescript-eslint/array-type": "warn",
+    "@typescript-eslint/consistent-indexed-object-style": "warn",
+    "@typescript-eslint/consistent-type-assertions": "warn",
+    "@typescript-eslint/consistent-type-definitions": "warn",
+    "@typescript-eslint/no-explicit-any": "warn",
     "@typescript-eslint/no-unused-vars": "off",
-    "indent": "off",
-    "@typescript-eslint/indent": [
-      "off"
-    ],
-    "@typescript-eslint/member-delimiter-style": [
-      "warn",
-      {
-        "multiline": {
-          "delimiter": "semi",
-          "requireLast": true
-        },
-        "singleline": {
-          "delimiter": "semi",
-          "requireLast": false
-        }
-      }
-    ],
-    "@typescript-eslint/member-ordering": "warn",
-    "@typescript-eslint/no-unnecessary-type-assertion": ["warn"],
-    "@typescript-eslint/no-empty-function": "warn",
-    "@typescript-eslint/no-inferrable-types": "warn",
-    "@typescript-eslint/restrict-plus-operands": "error",
-    "@typescript-eslint/no-unsafe-return": "warn",
-    "@typescript-eslint/quotes": [
-      "error",
-      "double"
-    ],
-    "@typescript-eslint/semi": [
-      "error",
-      "always"
-    ],
+    "@typescript-eslint/prefer-for-of": "warn",
     "max-len": [
       "error",
       {
         "code": 120
       }
     ],
+    "no-constant-condition": "warn",
+    "no-inner-declarations": "warn",
+    "no-irregular-whitespace": "warn",
     "no-multiple-empty-lines": "error",
-    "no-var": "warn"
+    "prefer-const": "warn",
+    "prefer-rest-params": "warn"
   }
 }
diff --git a/tobago-theme/package.json b/tobago-theme/package.json
index 5b73bacb21..d4054aa1fa 100644
--- a/tobago-theme/package.json
+++ b/tobago-theme/package.json
@@ -80,8 +80,8 @@
     "@rollup/plugin-typescript": "^11.1.5",
     "@types/bootstrap": "^5.2.9",
     "@types/jest": "^29.5.7",
-    "@typescript-eslint/eslint-plugin": "^5.62.0",
-    "@typescript-eslint/parser": "^5.62.0",
+    "@typescript-eslint/eslint-plugin": "^6.11.0",
+    "@typescript-eslint/parser": "^6.11.0",
     "autoprefixer": "^10.4.16",
     "clean-css-cli": "^5.6.2",
     "eslint": "^8.53.0",