You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spamassassin.apache.org by jm...@apache.org on 2006/08/17 17:17:54 UTC
svn commit: r432262 -
/spamassassin/trunk/lib/Mail/SpamAssassin/ArchiveIterator.pm
Author: jm
Date: Thu Aug 17 08:17:54 2006
New Revision: 432262
URL: http://svn.apache.org/viewvc?rev=432262&view=rev
Log:
no need to warn about 'archive-iterator: readdir found no mail in '/home/bbmass/rawcor/jm/ham/pub.20060715' directory'
Modified:
spamassassin/trunk/lib/Mail/SpamAssassin/ArchiveIterator.pm
Modified: spamassassin/trunk/lib/Mail/SpamAssassin/ArchiveIterator.pm
URL: http://svn.apache.org/viewvc/spamassassin/trunk/lib/Mail/SpamAssassin/ArchiveIterator.pm?rev=432262&r1=432261&r2=432262&view=diff
==============================================================================
--- spamassassin/trunk/lib/Mail/SpamAssassin/ArchiveIterator.pm (original)
+++ spamassassin/trunk/lib/Mail/SpamAssassin/ArchiveIterator.pm Thu Aug 17 08:17:54 2006
@@ -918,7 +918,8 @@
@files = grep { -f } map { "$folder/$_" } @files;
if (!@files) {
- warn "archive-iterator: readdir found no mail in '$folder' directory\n";
+ # this is not a problem; no need to warn about it
+ # warn "archive-iterator: readdir found no mail in '$folder' directory\n";
return;
}
Re: svn commit: r432262 - /spamassassin/trunk/lib/Mail/SpamAssassin/ArchiveIterator.pm
Posted by Theo Van Dinter <fe...@apache.org>.
On Thu, Aug 17, 2006 at 04:54:20PM +0100, Justin Mason wrote:
> since then, the ArchiveIterator code has been extended to support
> glob-patterns and recursion (I think, not quite sure about the latter) --
> so now, the user may not have specified the directory at all.
It doesn't do recursion, but yeah, spam:detect:/path/to/spam/* is
acceptable. As I said, I guess the warn doesn't really matter in the
end, though my personal POV is that I'd want to know there's some random
empty directory that I can remove.
<shrug>
> by the way, it appears performance on the zone has gone to crap :( 1 hour
> to scan the mass-check corpora, with AI caching on? that's atrocious!
fwiw, I have a generally idle dual 2.8GHz Xeon server w/ 4GB of RAM that I've
been trying to find something to do with... ;) My original plan was to get
around to doing multi-machine mass-checks, but thoughts about how to do it
haven't fully congealed in my head yet.
--
Randomly Generated Tagline:
"The PSTN is like a well-manicured neighborhood, (while) the internet
is like a crime-ridden slum." - Phil Zimmermann
Re: svn commit: r432262 - /spamassassin/trunk/lib/Mail/SpamAssassin/ArchiveIterator.pm
Posted by Theo Van Dinter <fe...@apache.org>.
On Thu, Aug 17, 2006 at 03:17:54PM -0000, jm@apache.org wrote:
> no need to warn about 'archive-iterator: readdir found no mail in '/home/bbmass/rawcor/jm/ham/pub.20060715' directory'
Hrm. I believe the thought process there was that if there was a
directory specified without any actual files in it, we should warn so
that it would be known that in the future the directory didn't have to
be specified. Though in the end I guess it doesn't matter.
--
Randomly Generated Tagline:
"It's kind of like wanting to be in a band, but being a roadie ..."
- Instructor Otten