You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/03/18 19:37:48 UTC
[GitHub] [druid] clintropolis opened a new pull request #9534: fix issue
where total limit was being applied even when not configured
clintropolis opened a new pull request #9534: fix issue where total limit was being applied even when not configured
URL: https://github.com/apache/druid/pull/9534
### Description
This PR fixes a mistake in `QueryScheduler` where a [default resilience4j bulkhead config](https://github.com/resilience4j/resilience4j/blob/master/resilience4j-core/src/main/java/io/github/resilience4j/core/registry/AbstractRegistry.java#L38) was applying a [default limit of 25](https://github.com/resilience4j/resilience4j/blob/master/resilience4j-bulkhead/src/main/java/io/github/resilience4j/bulkhead/BulkheadConfig.java#L30) to the 'total' capacity limit which is supposed to come from `druid.query.scheduler.numThreads`, but since was using the same "default" key for the config, it would be set to the resilience4j default if this value was not configured.
I also slightly updated the documentation to clarify the behavior of `druid.query.scheduler.numThreads` and its similarity to `druid.server.http.enableRequestLimit`.
The added test would fail prior to the changes in `QueryScheduler` in this PR.
<hr>
This PR has:
- [x] been self-reviewed.
- [x] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [x] added documentation for new or modified features or behaviors.
- [x] added unit tests or modified existing tests to cover new code paths.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson merged pull request #9534: fix issue where total
limit was being applied even when not configured
Posted by GitBox <gi...@apache.org>.
jihoonson merged pull request #9534: fix issue where total limit was being applied even when not configured
URL: https://github.com/apache/druid/pull/9534
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org