[GitHub] [ignite-3] ibessonov commented on a diff in pull request #1774: IGNITE-18997 Remove redundant future transformations from PartitionReplicaListener

["ibessonov (via GitHub)" <gi...@apache.org>]

ibessonov commented on code in PR #1774:
URL: https://github.com/apache/ignite-3/pull/1774#discussion_r1132096946


##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -714,7 +702,7 @@ private CompletableFuture<List<BinaryRow>> lookupIndex(
                         .thenCompose(indRowLock -> { // Hash index bucket S lock
                             Cursor<RowId> cursor = (Cursor<RowId>) cursors.computeIfAbsent(cursorId, id -> indexStorage.get(exactKey));
 
-                            final ArrayList<BinaryRow> result = new ArrayList<>(batchCount);
+                            ArrayList<BinaryRow> result = new ArrayList<>(batchCount);

Review Comment:
   ```suggestion
                               List<BinaryRow> result = new ArrayList<>(batchCount);
   ```



##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -785,7 +769,7 @@ private CompletableFuture<List<BinaryRow>> scanSortedIndex(
 
                 SortedIndexLocker indexLocker = (SortedIndexLocker) indexesLockers.get().get(indexId);
 
-                final ArrayList<BinaryRow> result = new ArrayList<>(batchCount);
+                ArrayList<BinaryRow> result = new ArrayList<>(batchCount);

Review Comment:
   ```suggestion
                   List<BinaryRow> result = new ArrayList<>(batchCount);
   ```



##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -822,7 +806,7 @@ private CompletableFuture<List<BinaryRow>> scanSortedIndex(
                         flags
                 ));
 
-        final ArrayList<BinaryRow> result = new ArrayList<>(batchCount);
+        ArrayList<BinaryRow> result = new ArrayList<>(batchCount);

Review Comment:
   ```suggestion
           List<BinaryRow> result = new ArrayList<>(batchCount);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org