You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2022/01/27 10:10:27 UTC

[GitHub] [james-project] jeantil commented on a change in pull request #860: JAMES-3708 Invalid mail address: Demonstrate NPE in RemoteDelivery

jeantil commented on a change in pull request #860:
URL: https://github.com/apache/james-project/pull/860#discussion_r793450251



##########
File path: core/src/test/java/org/apache/james/core/MailAddressTest.java
##########
@@ -47,6 +48,7 @@
                 GOOD_ADDRESS,
                 GOOD_QUOTED_LOCAL_PART,
                 "server-dev@james-apache.org",
+                "a..b@domain.com",

Review comment:
       hmm I don't know according to wikipedia  that's not a valid address because the dot occurs twice in a row which seems to match [RFC5322](https://datatracker.ietf.org/doc/html/rfc5322#section-3.2.3) this would need to be quoted to be a valid local part since it is not a dot-atom
   
   For reference examples from wikipedia : 
   good addresses: 
   - Abc@example.com
   - Abc@10.42.0.1
   - Abc.123@example.com
   - user+mailbox/department=shipping@example.com
   - !#$%&'*+-/=?^_`.{|}~@example.com
   - "Abc@def"@example.com
   - "Fred Bloggs"@example.com
   - "Joe.\\Blow"@example.com
   - Loïc.Accentué@voilà.fr8
   - pelé@exemple.com
   - δοκιμή@παράδειγμα.δοκιμή
   - 我買@屋企.香港
   - 二ノ宮@黒川.日本
   - медведь@с-балалайкой.рф
   - संपर्क@डाटामेल.भारत
   
   
   bad addresses
   - Abc.example.com
   - Abc.@example.com
   - Abc..123@example.com




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org