You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/24 13:38:02 UTC

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3177: Move decimal constants from `arrow-data` to `arrow-schema` crate

tustvold commented on code in PR #3177:
URL: https://github.com/apache/arrow-rs/pull/3177#discussion_r1031520794


##########
arrow-schema/src/datatype.rs:
##########
@@ -412,6 +412,108 @@ impl DataType {
     }
 }
 
+/// `MAX_DECIMAL_FOR_EACH_PRECISION[p]` holds the maximum `i128` value that can
+/// be stored in [DataType::Decimal128] value of precision `p`
+pub const MAX_DECIMAL_FOR_EACH_PRECISION: [i128; 38] = [

Review Comment:
   I'm not sure about moving these, as the decimal256 versions are in terms of i256 which is defined in arrow-buffer. Perhaps we could just move the schema constants?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org