You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2020/12/02 18:34:30 UTC
[kudu-CR](branch-1.12.x) [test] Use /tmp for mini-chronyd sockets
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16812
Change subject: [test] Use /tmp for mini-chronyd sockets
......................................................................
[test] Use /tmp for mini-chronyd sockets
To ensure the path is less than 100 bytes this patch uses /tmp instead
of the test directory for chronyd sockets.
Change-Id: I567ff640fca5c56fef3f4400216fc8b23532713e
Reviewed-on: http://gerrit.cloudera.org:8080/16808
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
(cherry picked from commit ef5b5abdcefbc5b7d7edb7170d55b82843926b25)
---
M src/kudu/clock/test/mini_chronyd.cc
1 file changed, 3 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/12/16812/1
--
To view, visit http://gerrit.cloudera.org:8080/16812
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I567ff640fca5c56fef3f4400216fc8b23532713e
Gerrit-Change-Number: 16812
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR](branch-1.12.x) [test] Use /tmp for mini-chronyd sockets
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16812 )
Change subject: [test] Use /tmp for mini-chronyd sockets
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16812
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I567ff640fca5c56fef3f4400216fc8b23532713e
Gerrit-Change-Number: 16812
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 02 Dec 2020 19:56:43 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.12.x) [test] Use /tmp for mini-chronyd sockets
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16812 )
Change subject: [test] Use /tmp for mini-chronyd sockets
......................................................................
Patch Set 2:
Rebased onto the other build patches
--
To view, visit http://gerrit.cloudera.org:8080/16812
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I567ff640fca5c56fef3f4400216fc8b23532713e
Gerrit-Change-Number: 16812
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 02 Dec 2020 19:42:23 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.12.x) [test] Use /tmp for mini-chronyd sockets
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has removed a vote on this change.
Change subject: [test] Use /tmp for mini-chronyd sockets
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/16812
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I567ff640fca5c56fef3f4400216fc8b23532713e
Gerrit-Change-Number: 16812
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.12.x) [test] Use /tmp for mini-chronyd sockets
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16812 )
Change subject: [test] Use /tmp for mini-chronyd sockets
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16812/1/src/kudu/clock/test/mini_chronyd.cc
File src/kudu/clock/test/mini_chronyd.cc:
http://gerrit.cloudera.org:8080/#/c/16812/1/src/kudu/clock/test/mini_chronyd.cc@424
PS1, Line 424: // TODO(aserbin): use some synthetic mount point instead?
> nit: I'd prefer this TODO to stay. Ideally, all test-related files should
Yep, I left it so a better solution could still be considered.
--
To view, visit http://gerrit.cloudera.org:8080/16812
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I567ff640fca5c56fef3f4400216fc8b23532713e
Gerrit-Change-Number: 16812
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 02 Dec 2020 19:38:20 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.12.x) [test] Use /tmp for mini-chronyd sockets
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16812 )
Change subject: [test] Use /tmp for mini-chronyd sockets
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16812
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I567ff640fca5c56fef3f4400216fc8b23532713e
Gerrit-Change-Number: 16812
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 02 Dec 2020 18:39:44 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.12.x) [test] Use /tmp for mini-chronyd sockets
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/16812 )
Change subject: [test] Use /tmp for mini-chronyd sockets
......................................................................
Patch Set 2: Verified+1
Test failure seems unrelated.
--
To view, visit http://gerrit.cloudera.org:8080/16812
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I567ff640fca5c56fef3f4400216fc8b23532713e
Gerrit-Change-Number: 16812
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 02 Dec 2020 20:30:39 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.12.x) [test] Use /tmp for mini-chronyd sockets
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16812 )
Change subject: [test] Use /tmp for mini-chronyd sockets
......................................................................
[test] Use /tmp for mini-chronyd sockets
To ensure the path is less than 100 bytes this patch uses /tmp instead
of the test directory for chronyd sockets.
Change-Id: I567ff640fca5c56fef3f4400216fc8b23532713e
Reviewed-on: http://gerrit.cloudera.org:8080/16808
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
(cherry picked from commit ef5b5abdcefbc5b7d7edb7170d55b82843926b25)
Reviewed-on: http://gerrit.cloudera.org:8080/16812
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/clock/test/mini_chronyd.cc
1 file changed, 3 insertions(+), 4 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Andrew Wong: Verified
--
To view, visit http://gerrit.cloudera.org:8080/16812
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I567ff640fca5c56fef3f4400216fc8b23532713e
Gerrit-Change-Number: 16812
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.12.x) [test] Use /tmp for mini-chronyd sockets
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16812 )
Change subject: [test] Use /tmp for mini-chronyd sockets
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16812/1/src/kudu/clock/test/mini_chronyd.cc
File src/kudu/clock/test/mini_chronyd.cc:
http://gerrit.cloudera.org:8080/#/c/16812/1/src/kudu/clock/test/mini_chronyd.cc@424
PS1, Line 424: // TODO(aserbin): use some synthetic mount point instead?
This TODO can now be removed.
--
To view, visit http://gerrit.cloudera.org:8080/16812
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I567ff640fca5c56fef3f4400216fc8b23532713e
Gerrit-Change-Number: 16812
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 02 Dec 2020 18:55:52 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.12.x) [test] Use /tmp for mini-chronyd sockets
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16812 )
Change subject: [test] Use /tmp for mini-chronyd sockets
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16812/1/src/kudu/clock/test/mini_chronyd.cc
File src/kudu/clock/test/mini_chronyd.cc:
http://gerrit.cloudera.org:8080/#/c/16812/1/src/kudu/clock/test/mini_chronyd.cc@424
PS1, Line 424: // TODO(aserbin): use some synthetic mount point instead?
> Yep, I left it so a better solution could still be considered.
Cool, thanks!
--
To view, visit http://gerrit.cloudera.org:8080/16812
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I567ff640fca5c56fef3f4400216fc8b23532713e
Gerrit-Change-Number: 16812
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 02 Dec 2020 19:56:32 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.12.x) [test] Use /tmp for mini-chronyd sockets
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16812 )
Change subject: [test] Use /tmp for mini-chronyd sockets
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16812/1/src/kudu/clock/test/mini_chronyd.cc
File src/kudu/clock/test/mini_chronyd.cc:
http://gerrit.cloudera.org:8080/#/c/16812/1/src/kudu/clock/test/mini_chronyd.cc@424
PS1, Line 424: // TODO(aserbin): use some synthetic mount point instead?
> This TODO can now be removed.
nit: I'd prefer this TODO to stay. Ideally, all test-related files should be under the test directory, and this TODO is about making it possible. As of now, the sub-dir would not be removed if test fails and the socket is left there, polluting /tmp
--
To view, visit http://gerrit.cloudera.org:8080/16812
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.12.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I567ff640fca5c56fef3f4400216fc8b23532713e
Gerrit-Change-Number: 16812
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 02 Dec 2020 19:05:13 +0000
Gerrit-HasComments: Yes