You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by pa...@apache.org on 2022/06/02 02:27:03 UTC
[shardingsphere] branch master updated: Data consistency check does not require source writing stop (#18140)
This is an automated email from the ASF dual-hosted git repository.
panjuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 365f930db6d Data consistency check does not require source writing stop (#18140)
365f930db6d is described below
commit 365f930db6d964bab28f58f2ff198a2f6932b636
Author: Hongsheng Zhong <sa...@126.com>
AuthorDate: Thu Jun 2 10:26:58 2022 +0800
Data consistency check does not require source writing stop (#18140)
---
.../data/pipeline/core/api/impl/RuleAlteredJobAPIImpl.java | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-core/src/main/java/org/apache/shardingsphere/data/pipeline/core/api/impl/RuleAlteredJobAPIImpl.java b/shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-core/src/main/java/org/apache/shardingsphere/data/pipeline/core/api/impl/RuleAlteredJobAPIImpl.java
index 857086a646b..a4bc5beefd3 100644
--- a/shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-core/src/main/java/org/apache/shardingsphere/data/pipeline/core/api/impl/RuleAlteredJobAPIImpl.java
+++ b/shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-core/src/main/java/org/apache/shardingsphere/data/pipeline/core/api/impl/RuleAlteredJobAPIImpl.java
@@ -162,14 +162,6 @@ public final class RuleAlteredJobAPIImpl extends AbstractPipelineJobAPIImpl impl
}
}
- private void verifySourceWritingStopped(final RuleAlteredJobConfiguration jobConfig) {
- LockContext lockContext = PipelineContext.getContextManager().getInstanceContext().getLockContext();
- String databaseName = jobConfig.getDatabaseName();
- if (!lockContext.isLocked(databaseName)) {
- throw new PipelineVerifyFailedException("Source writing is not stopped. You could run `STOP SCALING SOURCE WRITING {jobId}` to stop it.");
- }
- }
-
@Override
public void stopClusterWriteDB(final String jobId) {
checkModeConfig();
@@ -286,7 +278,6 @@ public final class RuleAlteredJobAPIImpl extends AbstractPipelineJobAPIImpl impl
private void verifyDataConsistencyCheck(final RuleAlteredJobConfiguration jobConfig) {
verifyManualMode(jobConfig);
- verifySourceWritingStopped(jobConfig);
}
@Override