[jira] [Commented] (SYSTEMML-1769) Potential null dereference in PreparedScript#enableFunctionRecompile

["Matthias Boehm (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SYSTEMML-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16088339#comment-16088339 ] 

Matthias Boehm commented on SYSTEMML-1769:
------------------------------------------

thanks for catching this [~tedyu] - may I ask which automated tool you're using to find these implementation issues?

> Potential null dereference in PreparedScript#enableFunctionRecompile
> --------------------------------------------------------------------
>
>                 Key: SYSTEMML-1769
>                 URL: https://issues.apache.org/jira/browse/SYSTEMML-1769
>             Project: SystemML
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Priority: Minor
>
> Here is related code:
> {code}
>     FunctionCallGraph fgraph = _prog.getProgramBlocks().isEmpty() ? null :
>       new FunctionCallGraph(_prog.getProgramBlocks().get(0).getStatementBlock().getDMLProg());
> ...
>       if( !fgraph.isRecursiveFunction(fkey) ) {
> {code}
> The assignment indicates that fgraph may be null.
> In the for loop, we should check fgraph against null before dereferencing.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)