You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/08/03 03:31:53 UTC

[GitHub] [orc] dongjoon-hyun opened a new pull request #807: ORC-901: Remove junit-vintage-engine from `mapreduce/tools` module

dongjoon-hyun opened a new pull request #807:
URL: https://github.com/apache/orc/pull/807


   ### What changes were proposed in this pull request?
   
   This PR aims to remove old dependencies from `mapreduce` and `tools` modules by removing `junit-vintage-engine`.
   
   ### Why are the changes needed?
   
   This will complete the JUnit5 migration in these modules.
   
   ### How was this patch tested?
   
   Pass the CIs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #807: ORC-901: Remove junit-vintage-engine from `mapreduce/tools` module

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #807:
URL: https://github.com/apache/orc/pull/807#issuecomment-891551042


   Thank you, @williamhyun !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun merged pull request #807: ORC-901: Remove junit-vintage-engine from `mapreduce/tools` module

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun merged pull request #807:
URL: https://github.com/apache/orc/pull/807


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on pull request #807: ORC-901: Remove junit-vintage-engine from `mapreduce/tools` module

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #807:
URL: https://github.com/apache/orc/pull/807#issuecomment-891492442


   cc @williamhyun and @pgaref 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] dongjoon-hyun commented on a change in pull request #807: ORC-901: Remove junit-vintage-engine from `mapreduce/tools` module

Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #807:
URL: https://github.com/apache/orc/pull/807#discussion_r681408207



##########
File path: java/mapreduce/src/test/org/apache/orc/mapred/TestOrcFileEvolution.java
##########
@@ -30,25 +30,20 @@
 import org.apache.orc.*;
 import org.apache.orc.TypeDescription.Category;
 import org.apache.orc.impl.SchemaEvolution;
-import org.junit.Before;
-import org.junit.Rule;
-import org.junit.Test;
-import org.junit.rules.ExpectedException;
-import org.junit.rules.TestName;
-import org.junit.runner.RunWith;
-import org.junit.runners.Parameterized;
 
 import java.io.File;
 import java.io.IOException;
 import java.util.*;
 
-import static org.junit.Assert.*;
+import org.junit.jupiter.api.*;
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.ValueSource;
+import static org.junit.jupiter.api.Assertions.*;
 import static org.mockito.Mockito.mock;
 
 /**
  * Test the behavior of ORC's schema evolution
  */
-@RunWith(Parameterized.class)

Review comment:
       JUnit5 only supports parameterized tests.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org