You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Ignasi Barrera <no...@github.com> on 2016/09/21 11:24:39 UTC

[jclouds/jclouds] Better predicate signature for node operations (#1011)

This changes the signature of the compute methods to have better predicates for nodes. Without this, most methods could only use a `Predicate<ComputeMetadata>` or a `Predicate<NodeMetadata>`, which was pretty inconvenient, because generic predicates such as `NodePredicates.all()` or concrete ones like `NodePredicates.inGroup("")` could not be used in all methods.

This change should be backwards compatible regarding client code and will allow to use all node and generic predicates in all node methods.

/cc @andreaturli 
You can view, comment on, or merge this pull request online at:

  https://github.com/jclouds/jclouds/pull/1011

-- Commit Summary --

  * Better predicate signature for node operations

-- File Changes --

    M apis/ec2/src/main/java/org/jclouds/ec2/compute/strategy/EC2ListNodesStrategy.java (2)
    M compute/src/main/java/org/jclouds/compute/ComputeService.java (20)
    M compute/src/main/java/org/jclouds/compute/internal/BaseComputeService.java (22)
    M compute/src/main/java/org/jclouds/compute/strategy/ListNodesStrategy.java (2)
    M compute/src/main/java/org/jclouds/compute/strategy/impl/AdaptingComputeServiceStrategies.java (2)
    M compute/src/test/java/org/jclouds/compute/internal/BaseComputeServiceLiveTest.java (2)
    M providers/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/compute/GoogleComputeEngineService.java (2)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/1011.patch
https://github.com/jclouds/jclouds/pull/1011.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1011

Re: [jclouds/jclouds] Better predicate signature for node operations (#1011)

Posted by Ignasi Barrera <no...@github.com>.
Pushed to master as [d98348d5](http://git-wip-us.apache.org/repos/asf/jclouds/commit/d98348d5).

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1011#issuecomment-249132317

Re: [jclouds/jclouds] Better predicate signature for node operations (#1011)

Posted by Ignasi Barrera <no...@github.com>.
Closed #1011.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/1011#event-800050823