You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "mustafasrepo (via GitHub)" <gi...@apache.org> on 2023/05/09 11:02:56 UTC

[GitHub] [arrow-datafusion] mustafasrepo commented on pull request #6234: Port remainder of `window.rs` to sqllogictest

mustafasrepo commented on PR #6234:
URL: https://github.com/apache/arrow-datafusion/pull/6234#issuecomment-1539964909

   Thanks @alamb for this PR. I added some comments. Other than these this PR is LGTM!. However, I wonder whether we should keep an example test case each file. Because, tests in `.rs` files are quite useful during development. Novices can use these example test cases as starting point when they work on new functionality. I am not really sure, whether it will be helpful. What are you thoughts about it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org