You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/09 03:44:10 UTC
[GitHub] [arrow] rok opened a new pull request #12373: ARROW-15619: [C++] Temporal component extraction function for extracting is_leap_year indicator
rok opened a new pull request #12373:
URL: https://github.com/apache/arrow/pull/12373
This is to resolve [ARROW-15619](https://issues.apache.org/jira/browse/ARROW-15619)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #12373: ARROW-15619: [C++] Temporal component extraction function for extracting is_leap_year indicator
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #12373:
URL: https://github.com/apache/arrow/pull/12373#issuecomment-1034221053
@lidavidm rebased.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #12373: ARROW-15619: [C++] Temporal component extraction function for extracting is_leap_year indicator
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #12373:
URL: https://github.com/apache/arrow/pull/12373#issuecomment-1035283954
@jorisvandenbossche added `Pacific/Pago_Pago` test to show results are different than in `Australia/Broken_Hill`. Also added a Pandas test and noticed I forgot to add one when adding `is_dst` kernel, so I added one for that as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on pull request #12373: ARROW-15619: [C++] Temporal component extraction function for extracting is_leap_year indicator
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on pull request #12373:
URL: https://github.com/apache/arrow/pull/12373#issuecomment-1034818363
Is there a test for a timestamp with timezone where it would give a different result if the timezone was ignored? (to catch that the timezone is properly applied) Such as "2012-01-01 00:00:00+02:00" (which is "2011-12-31 22:00:00" in the underlying UTC value, and then not a leap year)
(didn't check the exact values in the tests, so there might already be a case like this)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on a change in pull request #12373: ARROW-15619: [C++] Temporal component extraction function for extracting is_leap_year indicator
Posted by GitBox <gi...@apache.org>.
rok commented on a change in pull request #12373:
URL: https://github.com/apache/arrow/pull/12373#discussion_r803093936
##########
File path: docs/source/cpp/compute.rst
##########
@@ -1388,6 +1388,8 @@ For timestamps inputs with non-empty timezone, localized timestamp components wi
+--------------------+------------+-------------------+---------------+----------------------------+-------+
| iso_calendar | Unary | Temporal | Struct | | \(3) |
+--------------------+------------+-------------------+---------------+----------------------------+-------+
+| is_leap_year | Unary | Temporal | Boolean | | |
Review comment:
Indeed! Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #12373: ARROW-15619: [C++] Temporal component extraction function for extracting is_leap_year indicator
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #12373:
URL: https://github.com/apache/arrow/pull/12373#issuecomment-1035489332
Benchmark runs are scheduled for baseline = af33dd1157eb8d7d9bfac25ebf61445b793b7943 and contender = cce55b46395ee351835dbb2864772bfa7ba0eb9c. cce55b46395ee351835dbb2864772bfa7ba0eb9c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/d0108217301b4df984eb45df508f1fdb...5e950821761b4a328315f7579af61509/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/95a174de576a448abbf5b9e622c78575...ab1f4323a3e44cfea5f3c2b045b54e89/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/2ffc33b9bd274e8eb19c968ef090db78...8c38997cd01c4520a69c60a80d2ea82a/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/b42f905522eb44fca6093494bd8d81c0...4bdcb82de62d40da8ac6380229b86d24/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12373: ARROW-15619: [C++] Temporal component extraction function for extracting is_leap_year indicator
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12373:
URL: https://github.com/apache/arrow/pull/12373#issuecomment-1035489332
Benchmark runs are scheduled for baseline = af33dd1157eb8d7d9bfac25ebf61445b793b7943 and contender = cce55b46395ee351835dbb2864772bfa7ba0eb9c. cce55b46395ee351835dbb2864772bfa7ba0eb9c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/d0108217301b4df984eb45df508f1fdb...5e950821761b4a328315f7579af61509/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/95a174de576a448abbf5b9e622c78575...ab1f4323a3e44cfea5f3c2b045b54e89/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/2ffc33b9bd274e8eb19c968ef090db78...8c38997cd01c4520a69c60a80d2ea82a/)
[Finished :arrow_down:0.26% :arrow_up:0.13%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/b42f905522eb44fca6093494bd8d81c0...4bdcb82de62d40da8ac6380229b86d24/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #12373: ARROW-15619: [C++] Temporal component extraction function for extracting is_leap_year indicator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #12373:
URL: https://github.com/apache/arrow/pull/12373#issuecomment-1033313598
https://issues.apache.org/jira/browse/ARROW-15619
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on a change in pull request #12373: ARROW-15619: [C++] Temporal component extraction function for extracting is_leap_year indicator
Posted by GitBox <gi...@apache.org>.
lidavidm commented on a change in pull request #12373:
URL: https://github.com/apache/arrow/pull/12373#discussion_r803072673
##########
File path: docs/source/cpp/compute.rst
##########
@@ -1388,6 +1388,8 @@ For timestamps inputs with non-empty timezone, localized timestamp components wi
+--------------------+------------+-------------------+---------------+----------------------------+-------+
| iso_calendar | Unary | Temporal | Struct | | \(3) |
+--------------------+------------+-------------------+---------------+----------------------------+-------+
+| is_leap_year | Unary | Temporal | Boolean | | |
Review comment:
Maybe be explicit and list `Timestamp, Date`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12373: ARROW-15619: [C++] Temporal component extraction function for extracting is_leap_year indicator
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12373:
URL: https://github.com/apache/arrow/pull/12373#issuecomment-1035489332
Benchmark runs are scheduled for baseline = af33dd1157eb8d7d9bfac25ebf61445b793b7943 and contender = cce55b46395ee351835dbb2864772bfa7ba0eb9c. cce55b46395ee351835dbb2864772bfa7ba0eb9c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/d0108217301b4df984eb45df508f1fdb...5e950821761b4a328315f7579af61509/)
[Scheduled] [test-mac-arm](https://conbench.ursa.dev/compare/runs/95a174de576a448abbf5b9e622c78575...ab1f4323a3e44cfea5f3c2b045b54e89/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/2ffc33b9bd274e8eb19c968ef090db78...8c38997cd01c4520a69c60a80d2ea82a/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/b42f905522eb44fca6093494bd8d81c0...4bdcb82de62d40da8ac6380229b86d24/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] rok commented on pull request #12373: ARROW-15619: [C++] Temporal component extraction function for extracting is_leap_year indicator
Posted by GitBox <gi...@apache.org>.
rok commented on pull request #12373:
URL: https://github.com/apache/arrow/pull/12373#issuecomment-1034846562
@jorisvandenbossche good point, I'm not sure either. Will add.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #12373: ARROW-15619: [C++] Temporal component extraction function for extracting is_leap_year indicator
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #12373:
URL: https://github.com/apache/arrow/pull/12373#issuecomment-1034218361
And now the merge conflict is here :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12373: ARROW-15619: [C++] Temporal component extraction function for extracting is_leap_year indicator
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12373:
URL: https://github.com/apache/arrow/pull/12373#issuecomment-1035489332
Benchmark runs are scheduled for baseline = af33dd1157eb8d7d9bfac25ebf61445b793b7943 and contender = cce55b46395ee351835dbb2864772bfa7ba0eb9c. cce55b46395ee351835dbb2864772bfa7ba0eb9c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/d0108217301b4df984eb45df508f1fdb...5e950821761b4a328315f7579af61509/)
[Finished :arrow_down:0.21% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/95a174de576a448abbf5b9e622c78575...ab1f4323a3e44cfea5f3c2b045b54e89/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/2ffc33b9bd274e8eb19c968ef090db78...8c38997cd01c4520a69c60a80d2ea82a/)
[Finished :arrow_down:0.26% :arrow_up:0.13%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/b42f905522eb44fca6093494bd8d81c0...4bdcb82de62d40da8ac6380229b86d24/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #12373: ARROW-15619: [C++] Temporal component extraction function for extracting is_leap_year indicator
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #12373:
URL: https://github.com/apache/arrow/pull/12373#issuecomment-1035489332
Benchmark runs are scheduled for baseline = af33dd1157eb8d7d9bfac25ebf61445b793b7943 and contender = cce55b46395ee351835dbb2864772bfa7ba0eb9c. cce55b46395ee351835dbb2864772bfa7ba0eb9c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/d0108217301b4df984eb45df508f1fdb...5e950821761b4a328315f7579af61509/)
[Finished :arrow_down:0.21% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/95a174de576a448abbf5b9e622c78575...ab1f4323a3e44cfea5f3c2b045b54e89/)
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/2ffc33b9bd274e8eb19c968ef090db78...8c38997cd01c4520a69c60a80d2ea82a/)
[Finished :arrow_down:0.26% :arrow_up:0.13%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/b42f905522eb44fca6093494bd8d81c0...4bdcb82de62d40da8ac6380229b86d24/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm closed pull request #12373: ARROW-15619: [C++] Temporal component extraction function for extracting is_leap_year indicator
Posted by GitBox <gi...@apache.org>.
lidavidm closed pull request #12373:
URL: https://github.com/apache/arrow/pull/12373
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org