You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/12/23 07:51:22 UTC

[GitHub] [apisix-dashboard] starsz opened a new pull request #1107: feat: add spell checker (#1013)

starsz opened a new pull request #1107:
URL: https://github.com/apache/apisix-dashboard/pull/1107


   Please answer these questions before submitting a pull request
   
   - Why submit this pull request?
   - [ ] Bugfix
   - [x] New feature provided
   - [ ] Improve performance
   
   - Related issues
   
   fix #1013


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1107: feat: add spell checker (#1013)

Posted by GitBox <gi...@apache.org>.
starsz commented on a change in pull request #1107:
URL: https://github.com/apache/apisix-dashboard/pull/1107#discussion_r547978789



##########
File path: .github/workflows/spellchecker.yml
##########
@@ -0,0 +1,24 @@
+name: spellchecker
+on:
+  push:
+    branches:
+      - master

Review comment:
       Hmmm. I reference the PR https://github.com/apache/apisix/pull/3011.
   I think it is better to keep both `push` and `pr`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] starsz commented on pull request #1107: feat: add spell checker (#1013)

Posted by GitBox <gi...@apache.org>.
starsz commented on pull request #1107:
URL: https://github.com/apache/apisix-dashboard/pull/1107#issuecomment-750886159


   @tokers Please see again.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1107: feat: add spell checker (#1013)

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1107:
URL: https://github.com/apache/apisix-dashboard/pull/1107#discussion_r548360413



##########
File path: .github/workflows/spellchecker.yml
##########
@@ -0,0 +1,24 @@
+name: spellchecker
+on:
+  push:
+    branches:
+      - master

Review comment:
       There has 1 protection rule to forbidden push directly.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1107: feat: add spell checker (#1013)

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1107:
URL: https://github.com/apache/apisix-dashboard/pull/1107#issuecomment-750719962


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1107?src=pr&el=h1) Report
   > Merging [#1107](https://codecov.io/gh/apache/apisix-dashboard/pull/1107?src=pr&el=desc) (1b9f5f7) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/0895900ce5586fc2cb91ca02adf9ab682eb657ec?el=desc) (0895900) will **decrease** coverage by `0.05%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1107/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1107?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1107      +/-   ##
   ==========================================
   - Coverage   41.40%   41.34%   -0.06%     
   ==========================================
     Files          28       28              
     Lines        1785     1785              
   ==========================================
   - Hits          739      738       -1     
   - Misses        940      941       +1     
     Partials      106      106              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1107?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1107/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `78.57% <0.00%> (-0.65%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1107?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1107?src=pr&el=footer). Last update [0895900...1b9f5f7](https://codecov.io/gh/apache/apisix-dashboard/pull/1107?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1107: feat: add spell checker (#1013)

Posted by GitBox <gi...@apache.org>.
starsz commented on a change in pull request #1107:
URL: https://github.com/apache/apisix-dashboard/pull/1107#discussion_r548362076



##########
File path: .github/workflows/spellchecker.yml
##########
@@ -0,0 +1,24 @@
+name: spellchecker
+on:
+  push:
+    branches:
+      - master

Review comment:
       Got it. I will delete it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1107: feat: add spell checker (#1013)

Posted by GitBox <gi...@apache.org>.
starsz commented on a change in pull request #1107:
URL: https://github.com/apache/apisix-dashboard/pull/1107#discussion_r547979187



##########
File path: .github/workflows/spellchecker.yml
##########
@@ -0,0 +1,24 @@
+name: spellchecker
+on:
+  push:
+    branches:
+      - master
+  pull_request:
+    branches:
+      - master
+jobs:
+  misspell:
+    name: runner / misspell

Review comment:
       Hmmm. I reference the PR https://github.com/apache/apisix/pull/3011.
   It's harmless, right?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1107: feat: add spell checker (#1013)

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1107:
URL: https://github.com/apache/apisix-dashboard/pull/1107#discussion_r548364731



##########
File path: .github/workflows/spellchecker.yml
##########
@@ -0,0 +1,21 @@
+name: spellchecker
+on:
+  pull_request:
+    branches:
+      - master
+jobs:
+  misspell:
+    name: runner/misspell
+    runs-on: ubuntu-latest
+    steps:
+      - name: Check out code.
+        uses: actions/checkout@v1
+      - name: Install
+        run: |
+          wget -O - -q https://git.io/misspell | sh -s -- -b .
+      - name: Misspell
+        run: |
+          find . -type f -maxdepth 1 | xargs ./misspell -error
+          find . -name "*.go" -type f | xargs ./misspell -error
+          find docs -type f | xargs ./misspell -error
+          find web/src web/cypress -type f | xargs ./misspell -error

Review comment:
       oh yes, how about checker for golang?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1107: feat: add spell checker (#1013)

Posted by GitBox <gi...@apache.org>.
starsz commented on a change in pull request #1107:
URL: https://github.com/apache/apisix-dashboard/pull/1107#discussion_r548355850



##########
File path: .github/workflows/spellchecker.yml
##########
@@ -0,0 +1,24 @@
+name: spellchecker
+on:
+  push:
+    branches:
+      - master

Review comment:
       The aim is to avoid the mistake of spelling. 
   So we shouldn't make a mistake of spelling even if pushing to master.

##########
File path: .github/workflows/spellchecker.yml
##########
@@ -0,0 +1,24 @@
+name: spellchecker
+on:
+  push:
+    branches:
+      - master
+  pull_request:
+    branches:
+      - master
+jobs:
+  misspell:
+    name: runner / misspell

Review comment:
       OK, I will fix it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1107: feat: add spell checker (#1013)

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1107:
URL: https://github.com/apache/apisix-dashboard/pull/1107#discussion_r548366594



##########
File path: .github/workflows/spellchecker.yml
##########
@@ -0,0 +1,21 @@
+name: spellchecker
+on:
+  pull_request:
+    branches:
+      - master
+jobs:
+  misspell:
+    name: runner/misspell
+    runs-on: ubuntu-latest
+    steps:
+      - name: Check out code.
+        uses: actions/checkout@v1
+      - name: Install
+        run: |
+          wget -O - -q https://git.io/misspell | sh -s -- -b .
+      - name: Misspell
+        run: |
+          find . -type f -maxdepth 1 | xargs ./misspell -error
+          find . -name "*.go" -type f | xargs ./misspell -error
+          find docs -type f | xargs ./misspell -error
+          find web/src web/cypress -type f | xargs ./misspell -error

Review comment:
       got it 👏




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] tokers commented on pull request #1107: feat: add spell checker (#1013)

Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #1107:
URL: https://github.com/apache/apisix-dashboard/pull/1107#issuecomment-750871636


   @starsz This branch is out of date.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1107: feat: add spell checker (#1013)

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1107:
URL: https://github.com/apache/apisix-dashboard/pull/1107#issuecomment-750719962


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1107?src=pr&el=h1) Report
   > Merging [#1107](https://codecov.io/gh/apache/apisix-dashboard/pull/1107?src=pr&el=desc) (027d770) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/d2b577298d4b86ea120fda718e21478cd94e82eb?el=desc) (d2b5772) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1107/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1107?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #1107   +/-   ##
   =======================================
     Coverage   41.40%   41.40%           
   =======================================
     Files          28       28           
     Lines        1785     1785           
   =======================================
     Hits          739      739           
     Misses        940      940           
     Partials      106      106           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1107?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1107?src=pr&el=footer). Last update [d2b5772...027d770](https://codecov.io/gh/apache/apisix-dashboard/pull/1107?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1107: feat: add spell checker (#1013)

Posted by GitBox <gi...@apache.org>.
starsz commented on a change in pull request #1107:
URL: https://github.com/apache/apisix-dashboard/pull/1107#discussion_r548365743



##########
File path: .github/workflows/spellchecker.yml
##########
@@ -0,0 +1,21 @@
+name: spellchecker
+on:
+  pull_request:
+    branches:
+      - master
+jobs:
+  misspell:
+    name: runner/misspell
+    runs-on: ubuntu-latest
+    steps:
+      - name: Check out code.
+        uses: actions/checkout@v1
+      - name: Install
+        run: |
+          wget -O - -q https://git.io/misspell | sh -s -- -b .
+      - name: Misspell
+        run: |
+          find . -type f -maxdepth 1 | xargs ./misspell -error
+          find . -name "*.go" -type f | xargs ./misspell -error
+          find docs -type f | xargs ./misspell -error
+          find web/src web/cypress -type f | xargs ./misspell -error

Review comment:
       What? I don't get your point.
   `find . -name "*.go" -type f | xargs ./misspell -error` is checker for golang.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io commented on pull request #1107: feat: add spell checker (#1013)

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1107:
URL: https://github.com/apache/apisix-dashboard/pull/1107#issuecomment-750719962


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1107?src=pr&el=h1) Report
   > Merging [#1107](https://codecov.io/gh/apache/apisix-dashboard/pull/1107?src=pr&el=desc) (0c8dfc1) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/46bf1ef9cfe4f4c659752176424151bb4fc4952f?el=desc) (46bf1ef) will **not change** coverage.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1107/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1107?src=pr&el=tree)
   
   ```diff
   @@           Coverage Diff           @@
   ##           master    #1107   +/-   ##
   =======================================
     Coverage   41.06%   41.06%           
   =======================================
     Files          28       28           
     Lines        1773     1773           
   =======================================
     Hits          728      728           
     Misses        939      939           
     Partials      106      106           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1107?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1107?src=pr&el=footer). Last update [46bf1ef...0c8dfc1](https://codecov.io/gh/apache/apisix-dashboard/pull/1107?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1107: feat: add spell checker (#1013)

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1107:
URL: https://github.com/apache/apisix-dashboard/pull/1107#issuecomment-750719962


   # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1107?src=pr&el=h1) Report
   > Merging [#1107](https://codecov.io/gh/apache/apisix-dashboard/pull/1107?src=pr&el=desc) (6038056) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/c3e1d162bbaf19b1cf63c0437b3bec874c988dd5?el=desc) (c3e1d16) will **increase** coverage by `0.05%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/apisix-dashboard/pull/1107/graphs/tree.svg?width=650&height=150&src=pr&token=Q1HERXN96P)](https://codecov.io/gh/apache/apisix-dashboard/pull/1107?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #1107      +/-   ##
   ==========================================
   + Coverage   41.00%   41.06%   +0.05%     
   ==========================================
     Files          28       28              
     Lines        1773     1773              
   ==========================================
   + Hits          727      728       +1     
   + Misses        940      939       -1     
     Partials      106      106              
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1107?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1107/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `79.22% <0.00%> (+0.64%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1107?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1107?src=pr&el=footer). Last update [c3e1d16...6038056](https://codecov.io/gh/apache/apisix-dashboard/pull/1107?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1107: feat: add spell checker (#1013)

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1107:
URL: https://github.com/apache/apisix-dashboard/pull/1107#discussion_r547996906



##########
File path: .github/workflows/spellchecker.yml
##########
@@ -0,0 +1,24 @@
+name: spellchecker
+on:
+  push:
+    branches:
+      - master

Review comment:
       🤔 but when there is a mistake spelling after merging master?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1107: feat: add spell checker (#1013)

Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #1107:
URL: https://github.com/apache/apisix-dashboard/pull/1107


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1107: feat: add spell checker (#1013)

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1107:
URL: https://github.com/apache/apisix-dashboard/pull/1107#discussion_r547898796



##########
File path: .github/workflows/spellchecker.yml
##########
@@ -0,0 +1,24 @@
+name: spellchecker
+on:
+  push:
+    branches:
+      - master

Review comment:
       PR is enough 😊

##########
File path: .github/workflows/spellchecker.yml
##########
@@ -0,0 +1,24 @@
+name: spellchecker
+on:
+  push:
+    branches:
+      - master
+  pull_request:
+    branches:
+      - master
+jobs:
+  misspell:
+    name: runner / misspell

Review comment:
       extra space?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1107: feat: add spell checker (#1013)

Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1107:
URL: https://github.com/apache/apisix-dashboard/pull/1107#discussion_r547999191



##########
File path: .github/workflows/spellchecker.yml
##########
@@ -0,0 +1,24 @@
+name: spellchecker
+on:
+  push:
+    branches:
+      - master
+  pull_request:
+    branches:
+      - master
+jobs:
+  misspell:
+    name: runner / misspell

Review comment:
       ya, it's harmless, but what’s the reason to have spaces and slash for a name?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org