You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Will Berkeley (Code Review)" <ge...@cloudera.org> on 2017/06/20 19:46:49 UTC
[kudu-CR] [java] Rename interface-annotations to kudu-interface-annotations
Will Berkeley has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7234
Change subject: [java] Rename interface-annotations to kudu-interface-annotations
......................................................................
[java] Rename interface-annotations to kudu-interface-annotations
This makes the naming consistent with the other modules.
However, anyone depending on interface-annotations will need to
update their pom. THis probably isn't common-- most dependencies
on interface-annotations should be transitive through
kudu-client.
Change-Id: I4c67f36b0c746b529b2ffd4dd05c58e66a439503
---
M java/kudu-client/pom.xml
R java/kudu-interface-annotations/pom.xml
R java/kudu-interface-annotations/src/main/java/org/apache/kudu/annotations/InterfaceAudience.java
R java/kudu-interface-annotations/src/main/java/org/apache/kudu/annotations/InterfaceStability.java
R java/kudu-interface-annotations/src/main/java/org/apache/kudu/annotations/tools/ExcludePrivateAnnotationsJDiffDoclet.java
R java/kudu-interface-annotations/src/main/java/org/apache/kudu/annotations/tools/ExcludePrivateAnnotationsStandardDoclet.java
R java/kudu-interface-annotations/src/main/java/org/apache/kudu/annotations/tools/IncludePublicAnnotationsStandardDoclet.java
R java/kudu-interface-annotations/src/main/java/org/apache/kudu/annotations/tools/RootDocProcessor.java
R java/kudu-interface-annotations/src/main/java/org/apache/kudu/annotations/tools/StabilityOptions.java
R java/kudu-interface-annotations/src/main/java/org/apache/kudu/annotations/tools/package-info.java
M java/kudu-jepsen/pom.xml
M java/kudu-spark/pom.xml
M java/pom.xml
13 files changed, 7 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/34/7234/1
--
To view, visit http://gerrit.cloudera.org:8080/7234
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4c67f36b0c746b529b2ffd4dd05c58e66a439503
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
[kudu-CR] [java] Rename interface-annotations to kudu-interface-annotations
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: [java] Rename interface-annotations to kudu-interface-annotations
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7234/1//COMMIT_MSG
Commit Message:
Line 7: [java] Rename interface-annotations to kudu-interface-annotations
Did you look into using the Yetus annotations instead? http://yetus.apache.org/documentation/0.4.0/interface-classification/
Dan brought it up on Slack yesterday; we suspect they didn't yet exist when we forked Hadoop's interface-annotations.
--
To view, visit http://gerrit.cloudera.org:8080/7234
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c67f36b0c746b529b2ffd4dd05c58e66a439503
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] [java] Rename interface-annotations to kudu-interface-annotations
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has abandoned this change.
Change subject: [java] Rename interface-annotations to kudu-interface-annotations
......................................................................
Abandoned
Superseded by http://gerrit.cloudera.org:8080/7235
--
To view, visit http://gerrit.cloudera.org:8080/7234
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I4c67f36b0c746b529b2ffd4dd05c58e66a439503
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins