You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hop.apache.org by GitBox <gi...@apache.org> on 2022/06/01 12:07:32 UTC

[GitHub] [hop] sramazzina commented on a diff in pull request #1514: HOP-3870

sramazzina commented on code in PR #1514:
URL: https://github.com/apache/hop/pull/1514#discussion_r886726914


##########
plugins/databases/clickhouse/src/main/java/org/apache/hop/databases/clickhouse/ClickhouseDatabaseMeta.java:
##########
@@ -241,7 +241,7 @@ public boolean isQuoteAllFields() {
   /** @return This indicator separates the normal URL from the options */
   @Override
   public String getExtraOptionIndicator() {
-    return "&";
+    return "?";

Review Comment:
   Yes it is. I verified it on documentation and it is this way: the first parameter is separated by "?" then the remaining parameters by "&". 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org