You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Marton Greber (Code Review)" <ge...@cloudera.org> on 2022/09/09 18:05:59 UTC

[kudu-CR] KUDU-3379 Add column comments to table describe

Hello Zoltan Chovan, Alexey Serbin, Yingchun Lai, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18903

to look at the new patch set (#7).

Change subject: KUDU-3379 Add column comments to table describe
......................................................................

KUDU-3379 Add column comments to table describe

This patch adds -show_column_comment flag to kudu table describe. If
there are column comments specified, this can be used to show them.

Schema and ColumnSchema use the ToStringMode enum to control how they
are stringified. Previously these were used to signal a single mode of
the stringification. Now both are populated through bit shifting. This
way the enum can be used as a holder of multiple binary flags. We can
check for the presence of a flag through 'bitwise and' operator, and set
a given flag through the 'bitwise or' operator.

A new test case is added to check whether the column describing flags
work, alone and together as well.

Change-Id: Id8b751bd821a5f50490caa6f1aaf1fc767de0222
---
M src/kudu/client/schema.cc
M src/kudu/common/schema.cc
M src/kudu/common/schema.h
M src/kudu/tools/kudu-admin-test.cc
M src/kudu/tools/tool_action_table.cc
5 files changed, 120 insertions(+), 22 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/03/18903/7
-- 
To view, visit http://gerrit.cloudera.org:8080/18903
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id8b751bd821a5f50490caa6f1aaf1fc767de0222
Gerrit-Change-Number: 18903
Gerrit-PatchSet: 7
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>