[GitHub] [ozone] ChenSammi commented on a change in pull request #1642: HDDS-4519. Return forbidden instead of interval server error from s3g…

[GitBox <gi...@apache.org>]

ChenSammi commented on a change in pull request #1642:
URL: https://github.com/apache/ozone/pull/1642#discussion_r539801024



##########
File path: hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/exception/S3ErrorTable.java
##########
@@ -105,6 +106,9 @@ private S3ErrorTable() {
       "InternalError", "We encountered an internal error. Please try again.",
       HTTP_SERVER_ERROR);
 
+  public static final OS3Exception PERMISSION_DENIED = new OS3Exception(

Review comment:
       Good catch, I will change the description to "AccessDenied".  
   
   Although where are multiple Error Codes map to  "HTTP 403 Forbidden" ,  "AccessDenied" is the most appropriate description for this ACL case. 
   https://docs.aws.amazon.com/AmazonS3/latest/API/ErrorResponses.html#RESTErrorResponses
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org