You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2019/01/18 04:20:02 UTC
[kudu-CR] check session when applying operation
Hello Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/12237
to review the following change.
Change subject: check session when applying operation
......................................................................
check session when applying operation
Change-Id: I0fe221fedbb91959985f5ee374f1b691be2426a9
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
2 files changed, 22 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/12237/1
--
To view, visit http://gerrit.cloudera.org:8080/12237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0fe221fedbb91959985f5ee374f1b691be2426a9
Gerrit-Change-Number: 12237
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [java] log warning if applying operation on a closed session
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/12237 )
Change subject: [java] log warning if applying operation on a closed session
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0fe221fedbb91959985f5ee374f1b691be2426a9
Gerrit-Change-Number: 12237
Gerrit-PatchSet: 5
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 23 Jan 2019 18:58:10 +0000
Gerrit-HasComments: No
[kudu-CR] [java] log warning if applying operation on a closed session
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12237 )
Change subject: [java] log warning if applying operation on a closed session
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12237/4//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12237/4//COMMIT_MSG@14
PS4, Line 14: a breaking change for clients that relied on the old broken behavior.
:
> I ended up going with Hao's suggestion: soften this into a warning instead.
SGTM
--
To view, visit http://gerrit.cloudera.org:8080/12237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0fe221fedbb91959985f5ee374f1b691be2426a9
Gerrit-Change-Number: 12237
Gerrit-PatchSet: 5
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 23 Jan 2019 18:23:41 +0000
Gerrit-HasComments: Yes
[kudu-CR] check session when applying operation
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12237 )
Change subject: check session when applying operation
......................................................................
Patch Set 2:
PS1 is the original pull request from Karl Manong (https://github.com/apache/kudu/pull/15).
PS2 includes a few cosmetic changes from me.
--
To view, visit http://gerrit.cloudera.org:8080/12237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0fe221fedbb91959985f5ee374f1b691be2426a9
Gerrit-Change-Number: 12237
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 18 Jan 2019 04:25:18 +0000
Gerrit-HasComments: No
[kudu-CR] [java] log warning if applying operation on a closed session
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12237 )
Change subject: [java] log warning if applying operation on a closed session
......................................................................
[java] log warning if applying operation on a closed session
Closed sessions won't flush on another close() call, so it's somewhat
dubious to apply() an operation to a closed session. This change adds a
warning if apply() is used with a closed session.
Originally this patch enforced the new behavior via precondition, but that's
a breaking change for clients that relied on the old broken behavior.
Change-Id: I0fe221fedbb91959985f5ee374f1b691be2426a9
Reviewed-on: http://gerrit.cloudera.org:8080/12237
Tested-by: Kudu Jenkins
Reviewed-by: Grant Henke <gr...@apache.org>
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
2 files changed, 30 insertions(+), 2 deletions(-)
Approvals:
Kudu Jenkins: Verified
Grant Henke: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I0fe221fedbb91959985f5ee374f1b691be2426a9
Gerrit-Change-Number: 12237
Gerrit-PatchSet: 7
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] check session when applying operation
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Anonymous Coward (314),
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12237
to look at the new patch set (#3).
Change subject: check session when applying operation
......................................................................
check session when applying operation
Change-Id: I0fe221fedbb91959985f5ee374f1b691be2426a9
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
2 files changed, 24 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/12237/3
--
To view, visit http://gerrit.cloudera.org:8080/12237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0fe221fedbb91959985f5ee374f1b691be2426a9
Gerrit-Change-Number: 12237
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (314)
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [java] throw exception if applying operation on a closed session
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Anonymous Coward (314), Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12237
to look at the new patch set (#4).
Change subject: [java] throw exception if applying operation on a closed session
......................................................................
[java] throw exception if applying operation on a closed session
Closed sessions won't flush on another close() call, so it's somewhat
dubious to apply() an operation to a closed session. This change adds a
precondition that prevents apply() from working if the session has been
closed. There's a new test, and a fix to a non-compliant existing test.
This is a breaking change for clients that relied on the old broken
behavior; they will now throw. Thus I'm not sure we actually want this.
Change-Id: I0fe221fedbb91959985f5ee374f1b691be2426a9
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
2 files changed, 24 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/12237/4
--
To view, visit http://gerrit.cloudera.org:8080/12237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0fe221fedbb91959985f5ee374f1b691be2426a9
Gerrit-Change-Number: 12237
Gerrit-PatchSet: 4
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (314)
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [java] throw exception if applying operation on a closed session
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/12237 )
Change subject: [java] throw exception if applying operation on a closed session
......................................................................
Patch Set 4:
> Like you said, this is a breaking change given user code could
> start failing at runtime on upgrade.
>
> A hacky alternative to make the re-use bug safer could be to add
> the session back to the client on re-use. It defeats the purpose of
> closing, but prevents a bug without breaking the api.
Or can we log a warning instead if to avoid breaking changes?
--
To view, visit http://gerrit.cloudera.org:8080/12237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0fe221fedbb91959985f5ee374f1b691be2426a9
Gerrit-Change-Number: 12237
Gerrit-PatchSet: 4
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 18 Jan 2019 06:14:50 +0000
Gerrit-HasComments: No
[kudu-CR] check session when applying operation
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12237 )
Change subject: check session when applying operation
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12237/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12237/2//COMMIT_MSG@7
PS2, Line 7: check session when applying operation
Nit: [java] Check that the session is not closed when applying operation
Could a bit more description be added here? What was the behavior/error seen before this fix?
--
To view, visit http://gerrit.cloudera.org:8080/12237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0fe221fedbb91959985f5ee374f1b691be2426a9
Gerrit-Change-Number: 12237
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (314)
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 18 Jan 2019 05:34:06 +0000
Gerrit-HasComments: Yes
[kudu-CR] check session when applying operation
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12237
to look at the new patch set (#2).
Change subject: check session when applying operation
......................................................................
check session when applying operation
Change-Id: I0fe221fedbb91959985f5ee374f1b691be2426a9
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
2 files changed, 24 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/12237/2
--
To view, visit http://gerrit.cloudera.org:8080/12237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0fe221fedbb91959985f5ee374f1b691be2426a9
Gerrit-Change-Number: 12237
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [java] throw exception if applying operation on a closed session
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12237 )
Change subject: [java] throw exception if applying operation on a closed session
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12237/4//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12237/4//COMMIT_MSG@14
PS4, Line 14: This is a breaking change for clients that relied on the old broken
: behavior; they will now throw. Thus I'm not sure we actually want this.
Could throwing an exception in the specified case be optional? I guess by default we want to throw, but if some property specified for Kudu client, then there will be just a warning message logged?
--
To view, visit http://gerrit.cloudera.org:8080/12237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0fe221fedbb91959985f5ee374f1b691be2426a9
Gerrit-Change-Number: 12237
Gerrit-PatchSet: 4
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Sat, 19 Jan 2019 01:00:04 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] throw exception if applying operation on a closed session
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has removed Anonymous Coward (314) from this change. ( http://gerrit.cloudera.org:8080/12237 )
Change subject: [java] throw exception if applying operation on a closed session
......................................................................
Removed reviewer null.
--
To view, visit http://gerrit.cloudera.org:8080/12237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: I0fe221fedbb91959985f5ee374f1b691be2426a9
Gerrit-Change-Number: 12237
Gerrit-PatchSet: 4
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [java] throw exception if applying operation on a closed session
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12237 )
Change subject: [java] throw exception if applying operation on a closed session
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12237/2//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12237/2//COMMIT_MSG@7
PS2, Line 7: [java] throw exception if applying operation on a closed session
> Nit: [java] Check that the session is not closed when applying operation
Added description.
--
To view, visit http://gerrit.cloudera.org:8080/12237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0fe221fedbb91959985f5ee374f1b691be2426a9
Gerrit-Change-Number: 12237
Gerrit-PatchSet: 4
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (314)
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 18 Jan 2019 05:43:53 +0000
Gerrit-HasComments: Yes
[kudu-CR] check session when applying operation
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12237 )
Change subject: check session when applying operation
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0fe221fedbb91959985f5ee374f1b691be2426a9
Gerrit-Change-Number: 12237
Gerrit-PatchSet: 3
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (314)
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 18 Jan 2019 05:34:25 +0000
Gerrit-HasComments: No
[kudu-CR] [java] log warning if applying operation on a closed session
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12237 )
Change subject: [java] log warning if applying operation on a closed session
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0fe221fedbb91959985f5ee374f1b691be2426a9
Gerrit-Change-Number: 12237
Gerrit-PatchSet: 6
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 23 Jan 2019 20:23:08 +0000
Gerrit-HasComments: No
[kudu-CR] [java] throw exception if applying operation on a closed session
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12237 )
Change subject: [java] throw exception if applying operation on a closed session
......................................................................
Patch Set 4:
Like you said, this is a breaking change given user code could start failing at runtime on upgrade.
A hacky alternative to make the re-use bug safer could be to add the session back to the client on re-use. It defeats the purpose of closing, but prevents a bug without breaking the api.
--
To view, visit http://gerrit.cloudera.org:8080/12237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0fe221fedbb91959985f5ee374f1b691be2426a9
Gerrit-Change-Number: 12237
Gerrit-PatchSet: 4
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward (314)
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 18 Jan 2019 05:45:43 +0000
Gerrit-HasComments: No
[kudu-CR] [java] log warning if applying operation on a closed session
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12237 )
Change subject: [java] log warning if applying operation on a closed session
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12237/4//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12237/4//COMMIT_MSG@14
PS4, Line 14: a breaking change for clients that relied on the old broken behavior.
:
> Could throwing an exception in the specified case be optional? I guess by
I ended up going with Hao's suggestion: soften this into a warning instead.
--
To view, visit http://gerrit.cloudera.org:8080/12237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0fe221fedbb91959985f5ee374f1b691be2426a9
Gerrit-Change-Number: 12237
Gerrit-PatchSet: 5
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 23 Jan 2019 18:15:05 +0000
Gerrit-HasComments: Yes
[kudu-CR] [java] log warning if applying operation on a closed session
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Hello Alexey Serbin, Kudu Jenkins, Grant Henke, Hao Hao,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12237
to look at the new patch set (#5).
Change subject: [java] log warning if applying operation on a closed session
......................................................................
[java] log warning if applying operation on a closed session
Closed sessions won't flush on another close() call, so it's somewhat
dubious to apply() an operation to a closed session. This change adds a
warning if apply() is used with a closed session.
Originally this patch enforced the new behavior via precondition, but that's
a breaking change for clients that relied on the old broken behavior.
Change-Id: I0fe221fedbb91959985f5ee374f1b691be2426a9
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
2 files changed, 30 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/37/12237/5
--
To view, visit http://gerrit.cloudera.org:8080/12237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I0fe221fedbb91959985f5ee374f1b691be2426a9
Gerrit-Change-Number: 12237
Gerrit-PatchSet: 5
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)