You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "amogh-jahagirdar (via GitHub)" <gi...@apache.org> on 2023/04/24 17:33:45 UTC
[GitHub] [iceberg] amogh-jahagirdar opened a new pull request, #7421: API, Core: Move schemaID from ViewRepresentation to ViewVersion and make it required
amogh-jahagirdar opened a new pull request, #7421:
URL: https://github.com/apache/iceberg/pull/7421
Follow up from https://github.com/apache/iceberg/pull/6559#discussion_r1161329781 . The conclusion was that it's better to make schema required and part of the ViewVersion since all representations should share the same schema.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] amogh-jahagirdar commented on pull request #7421: API, Core: Move schemaID from ViewRepresentation to ViewVersion and make it required
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar commented on PR #7421:
URL: https://github.com/apache/iceberg/pull/7421#issuecomment-1520569507
I'll wait for https://github.com/apache/iceberg/pull/7417 to go in with all the cleanup and then rebase my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #7421: API, Core: Move schemaID from ViewRepresentation to ViewVersion and make it required
Posted by "amogh-jahagirdar (via GitHub)" <gi...@apache.org>.
amogh-jahagirdar commented on code in PR #7421:
URL: https://github.com/apache/iceberg/pull/7421#discussion_r1176020582
##########
core/src/main/java/org/apache/iceberg/view/ViewVersionParser.java:
##########
@@ -42,7 +43,7 @@ static void toJson(ViewVersion version, JsonGenerator generator) throws IOExcept
generator.writeNumberField(VERSION_ID, version.versionId());
generator.writeNumberField(TIMESTAMP_MS, version.timestampMillis());
-
+ generator.writeNumberField(SCHEMA_ID, version.schemaId());
Review Comment:
Fixed!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 merged pull request #7421: API, Core: Move schemaID from ViewRepresentation to ViewVersion and make it required
Posted by "jackye1995 (via GitHub)" <gi...@apache.org>.
jackye1995 merged PR #7421:
URL: https://github.com/apache/iceberg/pull/7421
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on pull request #7421: API, Core: Move schemaID from ViewRepresentation to ViewVersion and make it required
Posted by "jackye1995 (via GitHub)" <gi...@apache.org>.
jackye1995 commented on PR #7421:
URL: https://github.com/apache/iceberg/pull/7421#issuecomment-1522151569
Thanks for the quick fix! I will merge this to continue the conversations in #6559
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on a diff in pull request #7421: API, Core: Move schemaID from ViewRepresentation to ViewVersion and make it required
Posted by "jackye1995 (via GitHub)" <gi...@apache.org>.
jackye1995 commented on code in PR #7421:
URL: https://github.com/apache/iceberg/pull/7421#discussion_r1176013227
##########
core/src/main/java/org/apache/iceberg/view/ViewVersionParser.java:
##########
@@ -42,7 +43,7 @@ static void toJson(ViewVersion version, JsonGenerator generator) throws IOExcept
generator.writeNumberField(VERSION_ID, version.versionId());
generator.writeNumberField(TIMESTAMP_MS, version.timestampMillis());
-
+ generator.writeNumberField(SCHEMA_ID, version.schemaId());
Review Comment:
nit: we should probably not remove the newline before starting to write summary part
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org