[GitHub] [incubator-druid] leventov edited a comment on issue #7233: Set "is_published" to false for overshadowed segments in sys.segments table

[GitBox <gi...@apache.org>]

leventov edited a comment on issue #7233: Set "is_published" to false for overshadowed segments in sys.segments table
URL: https://github.com/apache/incubator-druid/issues/7233#issuecomment-476879411
 
 
   I don't like `is_active`. Active is a very overloaded term, and it's not obvious what's the difference between "active" and "published". I would suggest `is_overshadowed`, and if somebody wants "active", they need to write `is_published = true AND is_overshadowed = false`. `is_overshadowed` is defined as "overshadowed by other published segments *that are loaded in the cluster*". I suggest to add it only in `sys.segments`, but not in metadata store. In the codebase, all occurrences of "overshadowed" should be aligned with the above definition. "Overshadowed by published but not yet loaded segments" should be called somehow else (if it is used in the codebase), like "preOvershadowed".

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org