[GitHub] maven-surefire pull request #81: Create better report for AssumptionFailure

[Tibor17 <gi...@git.apache.org>]

Github user Tibor17 commented on a diff in the pull request:

    https://github.com/apache/maven-surefire/pull/81#discussion_r75205391
  
    --- Diff: surefire-providers/common-junit4/src/main/java/org/apache/maven/surefire/common/junit4/JUnit4RunListener.java ---
    @@ -128,11 +128,11 @@ protected StackTraceWriter createStackTraceWriter( Failure failure )
         @SuppressWarnings( { "UnusedDeclaration" } )
         public void testAssumptionFailure( Failure failure )
         {
    -        this.reporter.testAssumptionFailure( createReportEntry( failure.getDescription() ) );
    +        this.reporter.testAssumptionFailure( SimpleReportEntry.ignored( getClassName( failure.getDescription() ) , 
    --- End diff --
    
    @jimma 
    Can you please introduce a new constructor `public SimpleReportEntry( String source, String name, String message )` and call it instead of `SimpleReportEntry.ignored`? Can you call that constructor in `SimpleReportEntry.ignored` as well? Thx.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org