Re: [PR] [GOBBLIN-1996] Add ability for Yarn app to terminate on finishing of temporal flow [gobblin]

["homatthew (via GitHub)" <gi...@apache.org>]

homatthew commented on code in PR #3865:
URL: https://github.com/apache/gobblin/pull/3865#discussion_r1479055766


##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/joblauncher/GobblinJobLauncher.java:
##########
@@ -206,6 +206,13 @@ public void launchJob(@Nullable JobListener jobListener) throws JobException {
         cancelJob(jobListener);
       }
     } finally {
+      // NOTE: This code only makes sense when there is 1 source / workflow being launched per application. This is a stop-gap
+      // for recreating batch job behavior in GaaS. Given the current constraints of yarn applications requiring a static proxy user
+      // during application creation, it is not possible to have multiple workflows running in the same application.

Review Comment:
   Im sticking it into the GobblinTemporalJobLauncher. Any deriving flow can override this default behavior if they want. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org