You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by David Robinson <dr...@twitter.com> on 2014/07/08 03:18:21 UTC

Review Request 23330: replace 143 kB favicon with 318 byte version

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23330/
-----------------------------------------------------------

Review request for Aurora, David McLaughlin and Brian Wickman.


Bugs: AURORA-577
    https://issues.apache.org/jira/browse/AURORA-577


Repository: aurora


Description
-------

replace 143 kB favicon with 318 byte version.

$ file src/main/python/apache/thermos/observer/http/assets/favicon.ico
src/main/python/apache/thermos/observer/http/assets/favicon.ico: MS Windows icon resource - 2 icons, 229x201
$ ll -h src/main/python/apache/thermos/observer/http/assets/favicon.ico
-rw-rw-r--. 1 drobinson drobinson 143K Jul  7 17:42 src/main/python/apache/thermos/observer/http/assets/favicon.ico

$ file src/main/python/apache/thermos/observer/http/assets/favicon.ico
src/main/python/apache/thermos/observer/http/assets/favicon.ico: MS Windows icon resource - 1 icon, 16x16, 16 colors
$ ll src/main/python/apache/thermos/observer/http/assets/favicon.ico
-rw-rw-r--. 1 drobinson drobinson 318 Jul  7 17:42 src/main/python/apache/thermos/observer/http/assets/favicon.ico


Diffs
-----

  src/main/python/apache/thermos/observer/http/assets/favicon.ico 048d2e4b17a7a2d69dd1320efdebe14cb6095376 
  src/main/python/apache/thermos/observer/http/templates/filebrowse.tpl 511d7c06206ae5fd8a4206683f09348e1276b8c4 
  src/main/python/apache/thermos/observer/http/templates/index.tpl 3ccb6e841c932cb8bcb43b765e0b5aa8bc567f88 
  src/main/python/apache/thermos/observer/http/templates/logbrowse.tpl b182a4b331fbe8b9dd437194d195d220184a2f7c 

Diff: https://reviews.apache.org/r/23330/diff/


Testing
-------


Thanks,

David Robinson


Re: Review Request 23330: replace 143 kB favicon with 318 byte version

Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23330/#review49043
-----------------------------------------------------------


Reviewers - ping?

- Bill Farner


On July 8, 2014, 1:18 a.m., David Robinson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23330/
> -----------------------------------------------------------
> 
> (Updated July 8, 2014, 1:18 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Brian Wickman.
> 
> 
> Bugs: AURORA-577
>     https://issues.apache.org/jira/browse/AURORA-577
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> replace 143 kB favicon with 318 byte version.
> 
> $ file src/main/python/apache/thermos/observer/http/assets/favicon.ico
> src/main/python/apache/thermos/observer/http/assets/favicon.ico: MS Windows icon resource - 2 icons, 229x201
> $ ll -h src/main/python/apache/thermos/observer/http/assets/favicon.ico
> -rw-rw-r--. 1 drobinson drobinson 143K Jul  7 17:42 src/main/python/apache/thermos/observer/http/assets/favicon.ico
> 
> $ file src/main/python/apache/thermos/observer/http/assets/favicon.ico
> src/main/python/apache/thermos/observer/http/assets/favicon.ico: MS Windows icon resource - 1 icon, 16x16, 16 colors
> $ ll src/main/python/apache/thermos/observer/http/assets/favicon.ico
> -rw-rw-r--. 1 drobinson drobinson 318 Jul  7 17:42 src/main/python/apache/thermos/observer/http/assets/favicon.ico
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/thermos/observer/http/assets/favicon.ico 048d2e4b17a7a2d69dd1320efdebe14cb6095376 
>   src/main/python/apache/thermos/observer/http/templates/filebrowse.tpl 511d7c06206ae5fd8a4206683f09348e1276b8c4 
>   src/main/python/apache/thermos/observer/http/templates/index.tpl 3ccb6e841c932cb8bcb43b765e0b5aa8bc567f88 
>   src/main/python/apache/thermos/observer/http/templates/logbrowse.tpl b182a4b331fbe8b9dd437194d195d220184a2f7c 
> 
> Diff: https://reviews.apache.org/r/23330/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Robinson
> 
>


Re: Review Request 23330: replace 143 kB favicon with 318 byte version

Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23330/#review54550
-----------------------------------------------------------

Ship it!


Ship It!

- Brian Wickman


On July 31, 2014, 12:13 a.m., David Robinson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23330/
> -----------------------------------------------------------
> 
> (Updated July 31, 2014, 12:13 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Brian Wickman.
> 
> 
> Bugs: AURORA-577
>     https://issues.apache.org/jira/browse/AURORA-577
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> replace 143 kB favicon with 318 byte version.
> 
> $ file src/main/python/apache/thermos/observer/http/assets/favicon.ico
> src/main/python/apache/thermos/observer/http/assets/favicon.ico: MS Windows icon resource - 2 icons, 229x201
> $ ll -h src/main/python/apache/thermos/observer/http/assets/favicon.ico
> -rw-rw-r--. 1 drobinson drobinson 143K Jul  7 17:42 src/main/python/apache/thermos/observer/http/assets/favicon.ico
> 
> $ file src/main/python/apache/thermos/observer/http/assets/favicon.ico
> src/main/python/apache/thermos/observer/http/assets/favicon.ico: MS Windows icon resource - 1 icon, 16x16, 16 colors
> $ ll src/main/python/apache/thermos/observer/http/assets/favicon.ico
> -rw-rw-r--. 1 drobinson drobinson 318 Jul  7 17:42 src/main/python/apache/thermos/observer/http/assets/favicon.ico
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/thermos/observer/http/assets/favicon.ico 048d2e4b17a7a2d69dd1320efdebe14cb6095376 
>   src/main/python/apache/thermos/observer/http/templates/filebrowse.tpl 511d7c06206ae5fd8a4206683f09348e1276b8c4 
>   src/main/python/apache/thermos/observer/http/templates/index.tpl 3ccb6e841c932cb8bcb43b765e0b5aa8bc567f88 
>   src/main/python/apache/thermos/observer/http/templates/logbrowse.tpl b182a4b331fbe8b9dd437194d195d220184a2f7c 
> 
> Diff: https://reviews.apache.org/r/23330/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Robinson
> 
>


Re: Review Request 23330: replace 143 kB favicon with 318 byte version

Posted by David Robinson <dr...@twitter.com>.

> On Sept. 29, 2014, 4:31 p.m., Brian Wickman wrote:
> > david -- could you publish a remote branch somewhere that i can use to merge this to master?  the reviewboard diff does not contain the .ico and ./rbt patch does not support binary diffs.

https://github.com/zxvdr/incubator-aurora/tree/favicon


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23330/#review54819
-----------------------------------------------------------


On July 31, 2014, 12:13 a.m., David Robinson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23330/
> -----------------------------------------------------------
> 
> (Updated July 31, 2014, 12:13 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Brian Wickman.
> 
> 
> Bugs: AURORA-577
>     https://issues.apache.org/jira/browse/AURORA-577
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> replace 143 kB favicon with 318 byte version.
> 
> $ file src/main/python/apache/thermos/observer/http/assets/favicon.ico
> src/main/python/apache/thermos/observer/http/assets/favicon.ico: MS Windows icon resource - 2 icons, 229x201
> $ ll -h src/main/python/apache/thermos/observer/http/assets/favicon.ico
> -rw-rw-r--. 1 drobinson drobinson 143K Jul  7 17:42 src/main/python/apache/thermos/observer/http/assets/favicon.ico
> 
> $ file src/main/python/apache/thermos/observer/http/assets/favicon.ico
> src/main/python/apache/thermos/observer/http/assets/favicon.ico: MS Windows icon resource - 1 icon, 16x16, 16 colors
> $ ll src/main/python/apache/thermos/observer/http/assets/favicon.ico
> -rw-rw-r--. 1 drobinson drobinson 318 Jul  7 17:42 src/main/python/apache/thermos/observer/http/assets/favicon.ico
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/thermos/observer/http/assets/favicon.ico 048d2e4b17a7a2d69dd1320efdebe14cb6095376 
>   src/main/python/apache/thermos/observer/http/templates/filebrowse.tpl 511d7c06206ae5fd8a4206683f09348e1276b8c4 
>   src/main/python/apache/thermos/observer/http/templates/index.tpl 3ccb6e841c932cb8bcb43b765e0b5aa8bc567f88 
>   src/main/python/apache/thermos/observer/http/templates/logbrowse.tpl b182a4b331fbe8b9dd437194d195d220184a2f7c 
> 
> Diff: https://reviews.apache.org/r/23330/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Robinson
> 
>


Re: Review Request 23330: replace 143 kB favicon with 318 byte version

Posted by Brian Wickman <wi...@apache.org>.

> On Sept. 29, 2014, 4:31 p.m., Brian Wickman wrote:
> > david -- could you publish a remote branch somewhere that i can use to merge this to master?  the reviewboard diff does not contain the .ico and ./rbt patch does not support binary diffs.
> 
> David Robinson wrote:
>     https://github.com/zxvdr/incubator-aurora/tree/favicon

pushed amended commit

commit 25b7b3cc87ae31793bd0c1bb69515418feedb2e8
Author: David Robinson <dr...@twitter.com>
Date:   Mon Sep 29 11:28:21 2014 -0700

    replace 143 kB favicon with 2 kB version.


- Brian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23330/#review54819
-----------------------------------------------------------


On July 31, 2014, 12:13 a.m., David Robinson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23330/
> -----------------------------------------------------------
> 
> (Updated July 31, 2014, 12:13 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Brian Wickman.
> 
> 
> Bugs: AURORA-577
>     https://issues.apache.org/jira/browse/AURORA-577
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> replace 143 kB favicon with 318 byte version.
> 
> $ file src/main/python/apache/thermos/observer/http/assets/favicon.ico
> src/main/python/apache/thermos/observer/http/assets/favicon.ico: MS Windows icon resource - 2 icons, 229x201
> $ ll -h src/main/python/apache/thermos/observer/http/assets/favicon.ico
> -rw-rw-r--. 1 drobinson drobinson 143K Jul  7 17:42 src/main/python/apache/thermos/observer/http/assets/favicon.ico
> 
> $ file src/main/python/apache/thermos/observer/http/assets/favicon.ico
> src/main/python/apache/thermos/observer/http/assets/favicon.ico: MS Windows icon resource - 1 icon, 16x16, 16 colors
> $ ll src/main/python/apache/thermos/observer/http/assets/favicon.ico
> -rw-rw-r--. 1 drobinson drobinson 318 Jul  7 17:42 src/main/python/apache/thermos/observer/http/assets/favicon.ico
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/thermos/observer/http/assets/favicon.ico 048d2e4b17a7a2d69dd1320efdebe14cb6095376 
>   src/main/python/apache/thermos/observer/http/templates/filebrowse.tpl 511d7c06206ae5fd8a4206683f09348e1276b8c4 
>   src/main/python/apache/thermos/observer/http/templates/index.tpl 3ccb6e841c932cb8bcb43b765e0b5aa8bc567f88 
>   src/main/python/apache/thermos/observer/http/templates/logbrowse.tpl b182a4b331fbe8b9dd437194d195d220184a2f7c 
> 
> Diff: https://reviews.apache.org/r/23330/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Robinson
> 
>


Re: Review Request 23330: replace 143 kB favicon with 318 byte version

Posted by Brian Wickman <wi...@apache.org>.

> On Sept. 29, 2014, 4:31 p.m., Brian Wickman wrote:
> > david -- could you publish a remote branch somewhere that i can use to merge this to master?  the reviewboard diff does not contain the .ico and ./rbt patch does not support binary diffs.
> 
> David Robinson wrote:
>     https://github.com/zxvdr/incubator-aurora/tree/favicon
> 
> Brian Wickman wrote:
>     pushed amended commit
>     
>     commit 25b7b3cc87ae31793bd0c1bb69515418feedb2e8
>     Author: David Robinson <dr...@twitter.com>
>     Date:   Mon Sep 29 11:28:21 2014 -0700
>     
>         replace 143 kB favicon with 2 kB version.

argh forgot to add 'Reviewed at' link...my bad.


- Brian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23330/#review54819
-----------------------------------------------------------


On July 31, 2014, 12:13 a.m., David Robinson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23330/
> -----------------------------------------------------------
> 
> (Updated July 31, 2014, 12:13 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Brian Wickman.
> 
> 
> Bugs: AURORA-577
>     https://issues.apache.org/jira/browse/AURORA-577
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> replace 143 kB favicon with 318 byte version.
> 
> $ file src/main/python/apache/thermos/observer/http/assets/favicon.ico
> src/main/python/apache/thermos/observer/http/assets/favicon.ico: MS Windows icon resource - 2 icons, 229x201
> $ ll -h src/main/python/apache/thermos/observer/http/assets/favicon.ico
> -rw-rw-r--. 1 drobinson drobinson 143K Jul  7 17:42 src/main/python/apache/thermos/observer/http/assets/favicon.ico
> 
> $ file src/main/python/apache/thermos/observer/http/assets/favicon.ico
> src/main/python/apache/thermos/observer/http/assets/favicon.ico: MS Windows icon resource - 1 icon, 16x16, 16 colors
> $ ll src/main/python/apache/thermos/observer/http/assets/favicon.ico
> -rw-rw-r--. 1 drobinson drobinson 318 Jul  7 17:42 src/main/python/apache/thermos/observer/http/assets/favicon.ico
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/thermos/observer/http/assets/favicon.ico 048d2e4b17a7a2d69dd1320efdebe14cb6095376 
>   src/main/python/apache/thermos/observer/http/templates/filebrowse.tpl 511d7c06206ae5fd8a4206683f09348e1276b8c4 
>   src/main/python/apache/thermos/observer/http/templates/index.tpl 3ccb6e841c932cb8bcb43b765e0b5aa8bc567f88 
>   src/main/python/apache/thermos/observer/http/templates/logbrowse.tpl b182a4b331fbe8b9dd437194d195d220184a2f7c 
> 
> Diff: https://reviews.apache.org/r/23330/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Robinson
> 
>


Re: Review Request 23330: replace 143 kB favicon with 318 byte version

Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23330/#review54819
-----------------------------------------------------------


david -- could you publish a remote branch somewhere that i can use to merge this to master?  the reviewboard diff does not contain the .ico and ./rbt patch does not support binary diffs.

- Brian Wickman


On July 31, 2014, 12:13 a.m., David Robinson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23330/
> -----------------------------------------------------------
> 
> (Updated July 31, 2014, 12:13 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Brian Wickman.
> 
> 
> Bugs: AURORA-577
>     https://issues.apache.org/jira/browse/AURORA-577
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> replace 143 kB favicon with 318 byte version.
> 
> $ file src/main/python/apache/thermos/observer/http/assets/favicon.ico
> src/main/python/apache/thermos/observer/http/assets/favicon.ico: MS Windows icon resource - 2 icons, 229x201
> $ ll -h src/main/python/apache/thermos/observer/http/assets/favicon.ico
> -rw-rw-r--. 1 drobinson drobinson 143K Jul  7 17:42 src/main/python/apache/thermos/observer/http/assets/favicon.ico
> 
> $ file src/main/python/apache/thermos/observer/http/assets/favicon.ico
> src/main/python/apache/thermos/observer/http/assets/favicon.ico: MS Windows icon resource - 1 icon, 16x16, 16 colors
> $ ll src/main/python/apache/thermos/observer/http/assets/favicon.ico
> -rw-rw-r--. 1 drobinson drobinson 318 Jul  7 17:42 src/main/python/apache/thermos/observer/http/assets/favicon.ico
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/thermos/observer/http/assets/favicon.ico 048d2e4b17a7a2d69dd1320efdebe14cb6095376 
>   src/main/python/apache/thermos/observer/http/templates/filebrowse.tpl 511d7c06206ae5fd8a4206683f09348e1276b8c4 
>   src/main/python/apache/thermos/observer/http/templates/index.tpl 3ccb6e841c932cb8bcb43b765e0b5aa8bc567f88 
>   src/main/python/apache/thermos/observer/http/templates/logbrowse.tpl b182a4b331fbe8b9dd437194d195d220184a2f7c 
> 
> Diff: https://reviews.apache.org/r/23330/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Robinson
> 
>


Re: Review Request 23330: replace 143 kB favicon with 318 byte version

Posted by David Robinson <dr...@twitter.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23330/
-----------------------------------------------------------

(Updated July 31, 2014, 12:13 a.m.)


Review request for Aurora, David McLaughlin and Brian Wickman.


Changes
-------

Thought the 318 byte version was fine, but it's not (my browser had the previous version cached), it strips out too much detail.

This update fixes the problem, but the favicon is slightly larger (2 KB).


Bugs: AURORA-577
    https://issues.apache.org/jira/browse/AURORA-577


Repository: aurora


Description
-------

replace 143 kB favicon with 318 byte version.

$ file src/main/python/apache/thermos/observer/http/assets/favicon.ico
src/main/python/apache/thermos/observer/http/assets/favicon.ico: MS Windows icon resource - 2 icons, 229x201
$ ll -h src/main/python/apache/thermos/observer/http/assets/favicon.ico
-rw-rw-r--. 1 drobinson drobinson 143K Jul  7 17:42 src/main/python/apache/thermos/observer/http/assets/favicon.ico

$ file src/main/python/apache/thermos/observer/http/assets/favicon.ico
src/main/python/apache/thermos/observer/http/assets/favicon.ico: MS Windows icon resource - 1 icon, 16x16, 16 colors
$ ll src/main/python/apache/thermos/observer/http/assets/favicon.ico
-rw-rw-r--. 1 drobinson drobinson 318 Jul  7 17:42 src/main/python/apache/thermos/observer/http/assets/favicon.ico


Diffs (updated)
-----

  src/main/python/apache/thermos/observer/http/assets/favicon.ico 048d2e4b17a7a2d69dd1320efdebe14cb6095376 
  src/main/python/apache/thermos/observer/http/templates/filebrowse.tpl 511d7c06206ae5fd8a4206683f09348e1276b8c4 
  src/main/python/apache/thermos/observer/http/templates/index.tpl 3ccb6e841c932cb8bcb43b765e0b5aa8bc567f88 
  src/main/python/apache/thermos/observer/http/templates/logbrowse.tpl b182a4b331fbe8b9dd437194d195d220184a2f7c 

Diff: https://reviews.apache.org/r/23330/diff/


Testing
-------


Thanks,

David Robinson


Re: Review Request 23330: replace 143 kB favicon with 318 byte version

Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23330/#review47430
-----------------------------------------------------------

Ship it!


Ship It!

- Kevin Sweeney


On July 7, 2014, 6:18 p.m., David Robinson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23330/
> -----------------------------------------------------------
> 
> (Updated July 7, 2014, 6:18 p.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Brian Wickman.
> 
> 
> Bugs: AURORA-577
>     https://issues.apache.org/jira/browse/AURORA-577
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> replace 143 kB favicon with 318 byte version.
> 
> $ file src/main/python/apache/thermos/observer/http/assets/favicon.ico
> src/main/python/apache/thermos/observer/http/assets/favicon.ico: MS Windows icon resource - 2 icons, 229x201
> $ ll -h src/main/python/apache/thermos/observer/http/assets/favicon.ico
> -rw-rw-r--. 1 drobinson drobinson 143K Jul  7 17:42 src/main/python/apache/thermos/observer/http/assets/favicon.ico
> 
> $ file src/main/python/apache/thermos/observer/http/assets/favicon.ico
> src/main/python/apache/thermos/observer/http/assets/favicon.ico: MS Windows icon resource - 1 icon, 16x16, 16 colors
> $ ll src/main/python/apache/thermos/observer/http/assets/favicon.ico
> -rw-rw-r--. 1 drobinson drobinson 318 Jul  7 17:42 src/main/python/apache/thermos/observer/http/assets/favicon.ico
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/thermos/observer/http/assets/favicon.ico 048d2e4b17a7a2d69dd1320efdebe14cb6095376 
>   src/main/python/apache/thermos/observer/http/templates/filebrowse.tpl 511d7c06206ae5fd8a4206683f09348e1276b8c4 
>   src/main/python/apache/thermos/observer/http/templates/index.tpl 3ccb6e841c932cb8bcb43b765e0b5aa8bc567f88 
>   src/main/python/apache/thermos/observer/http/templates/logbrowse.tpl b182a4b331fbe8b9dd437194d195d220184a2f7c 
> 
> Diff: https://reviews.apache.org/r/23330/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Robinson
> 
>


Re: Review Request 23330: replace 143 kB favicon with 318 byte version

Posted by David McLaughlin <da...@dmclaughlin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23330/#review49147
-----------------------------------------------------------

Ship it!


Ship It!

- David McLaughlin


On July 8, 2014, 1:18 a.m., David Robinson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23330/
> -----------------------------------------------------------
> 
> (Updated July 8, 2014, 1:18 a.m.)
> 
> 
> Review request for Aurora, David McLaughlin and Brian Wickman.
> 
> 
> Bugs: AURORA-577
>     https://issues.apache.org/jira/browse/AURORA-577
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> replace 143 kB favicon with 318 byte version.
> 
> $ file src/main/python/apache/thermos/observer/http/assets/favicon.ico
> src/main/python/apache/thermos/observer/http/assets/favicon.ico: MS Windows icon resource - 2 icons, 229x201
> $ ll -h src/main/python/apache/thermos/observer/http/assets/favicon.ico
> -rw-rw-r--. 1 drobinson drobinson 143K Jul  7 17:42 src/main/python/apache/thermos/observer/http/assets/favicon.ico
> 
> $ file src/main/python/apache/thermos/observer/http/assets/favicon.ico
> src/main/python/apache/thermos/observer/http/assets/favicon.ico: MS Windows icon resource - 1 icon, 16x16, 16 colors
> $ ll src/main/python/apache/thermos/observer/http/assets/favicon.ico
> -rw-rw-r--. 1 drobinson drobinson 318 Jul  7 17:42 src/main/python/apache/thermos/observer/http/assets/favicon.ico
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/thermos/observer/http/assets/favicon.ico 048d2e4b17a7a2d69dd1320efdebe14cb6095376 
>   src/main/python/apache/thermos/observer/http/templates/filebrowse.tpl 511d7c06206ae5fd8a4206683f09348e1276b8c4 
>   src/main/python/apache/thermos/observer/http/templates/index.tpl 3ccb6e841c932cb8bcb43b765e0b5aa8bc567f88 
>   src/main/python/apache/thermos/observer/http/templates/logbrowse.tpl b182a4b331fbe8b9dd437194d195d220184a2f7c 
> 
> Diff: https://reviews.apache.org/r/23330/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Robinson
> 
>