You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/07/06 01:57:34 UTC

[GitHub] [incubator-eventmesh] xwm1992 commented on a diff in pull request #976: [MINOR] Use Apache release rather than Github release in README

xwm1992 commented on code in PR #976:
URL: https://github.com/apache/incubator-eventmesh/pull/976#discussion_r914344526


##########
docs/en/installation/01-runtime.md:
##########
@@ -40,20 +40,21 @@ bash bin/start.sh
 
 Gradle is the build automation tool used by Apache EventMesh (Incubating). Please refer to the [offical guide](https://docs.gradle.org/current/userguide/installation.html) to install the latest release of Gradle.
 
-Download and extract the source code of the latest release (v1.4.0) from [GitHub releases](https://github.com/apache/incubator-eventmesh/releases).
+Download and extract the source code of the latest release from [EventMesh download](https://eventmesh.apache.org/download).
 
 ```console
-wget https://github.com/apache/incubator-eventmesh/archive/refs/tags/v1.4.0.tar.gz
+wget https://dlcdn.apache.org/incubator/eventmesh/1.4.0-incubating/apache-eventmesh-{version}-source.tar.gz
 
-tar -xvzf v1.4.0.tar.gz
+tar -xvzf apache-eventmesh-{version}-source.tar.gz

Review Comment:
   change apache-eventmesh-{version}-source.tar.gz -> apache-eventmesh-{version}-incubating-source.tar.gz



##########
docs/en/installation/01-runtime.md:
##########
@@ -40,20 +40,21 @@ bash bin/start.sh
 
 Gradle is the build automation tool used by Apache EventMesh (Incubating). Please refer to the [offical guide](https://docs.gradle.org/current/userguide/installation.html) to install the latest release of Gradle.
 
-Download and extract the source code of the latest release (v1.4.0) from [GitHub releases](https://github.com/apache/incubator-eventmesh/releases).
+Download and extract the source code of the latest release from [EventMesh download](https://eventmesh.apache.org/download).
 
 ```console
-wget https://github.com/apache/incubator-eventmesh/archive/refs/tags/v1.4.0.tar.gz
+wget https://dlcdn.apache.org/incubator/eventmesh/1.4.0-incubating/apache-eventmesh-{version}-source.tar.gz

Review Comment:
   please change this to https://dlcdn.apache.org/incubator/eventmesh/{version}-incubating/apache-eventmesh-{version}-incubating-source.tar.gz



##########
docs/en/installation/01-runtime.md:
##########
@@ -40,20 +40,21 @@ bash bin/start.sh
 
 Gradle is the build automation tool used by Apache EventMesh (Incubating). Please refer to the [offical guide](https://docs.gradle.org/current/userguide/installation.html) to install the latest release of Gradle.
 
-Download and extract the source code of the latest release (v1.4.0) from [GitHub releases](https://github.com/apache/incubator-eventmesh/releases).
+Download and extract the source code of the latest release from [EventMesh download](https://eventmesh.apache.org/download).
 
 ```console
-wget https://github.com/apache/incubator-eventmesh/archive/refs/tags/v1.4.0.tar.gz
+wget https://dlcdn.apache.org/incubator/eventmesh/1.4.0-incubating/apache-eventmesh-{version}-source.tar.gz
 
-tar -xvzf v1.4.0.tar.gz
+tar -xvzf apache-eventmesh-{version}-source.tar.gz
 ```
 
 Build the source code with Gradle.
 
 ```console
-cd incubator-eventmesh-1.4.0
-gradle clean build
+cd apache-eventmesh-{version}-source

Review Comment:
   change apache-eventmesh-{version}-source -> apache-eventmesh-{version}-incubating-source



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org