You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/09/27 16:58:24 UTC

[GitHub] [spark] gengliangwang commented on a change in pull request #34111: [SPARK-36856][BUILD] Get correct JAVA_HOME for macOS

gengliangwang commented on a change in pull request #34111:
URL: https://github.com/apache/spark/pull/34111#discussion_r716878945



##########
File path: build/mvn
##########
@@ -21,7 +21,11 @@ SELF=$(cd $(dirname $0) && pwd)
 . "$SELF/util.sh"
 
 if [ -z "${JAVA_HOME}" -a "$(command -v javac)" ]; then
-  export JAVA_HOME="$(dirname $(dirname $(realpath $(command -v javac))))"
+  if [ "$(uname -s)" = "Darwin" ]; then

Review comment:
       Nit: add one line comment here 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org