You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/18 03:12:58 UTC
[GitHub] [airflow] chinwobble opened a new pull request #19668: Fix argument error in AzureContainerInstancesOperator
chinwobble opened a new pull request #19668:
URL: https://github.com/apache/airflow/pull/19668
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
Closes #18074
The code was producing the error `TypeError: __init__() got multiple values for argument 'sdk_client'`.
I created this small test to understand the problem.
```python
from typing import Any, Dict, List, Optional, Sequence, Union
class BaseHook:
pass
class AzureBaseHook(BaseHook):
def __init__(self, sdk_client: Any, conn_id: str = 'azure_default'):
print(sdk_client)
self.sdk_client = sdk_client
self.conn_id = conn_id
super().__init__()
class AzureContainerInstanceHook(AzureBaseHook):
def __init__(self, *args, **kwargs):
super().__init__(*args, **kwargs, sdk_client="Container Instances")
# self.connection = self.get_conn()
myhook = AzureContainerInstanceHook("abc")
```
When the keyword is missing from `AzureContainerInstanceHook` the first positional argument is assumed to be `sdk_client`.
When you change the code to `AzureContainerInstanceHook(conn_id="abc")`, this issue is fixed.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] chinwobble commented on pull request #19668: Fix argument error in AzureContainerInstancesOperator
Posted by GitBox <gi...@apache.org>.
chinwobble commented on pull request #19668:
URL: https://github.com/apache/airflow/pull/19668#issuecomment-978494383
@potiuk do you know when this can be released?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #19668: Fix argument error in AzureContainerInstancesOperator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19668:
URL: https://github.com/apache/airflow/pull/19668#issuecomment-972661507
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #19668: Fix argument error in AzureContainerInstancesOperator
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #19668:
URL: https://github.com/apache/airflow/pull/19668#issuecomment-972701086
Awesome work, congrats on your first merged pull request!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #19668: Fix argument error in AzureContainerInstancesOperator
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #19668:
URL: https://github.com/apache/airflow/pull/19668#issuecomment-979011021
We release providers ~end of month so soon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #19668: Fix argument error in AzureContainerInstancesOperator
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #19668:
URL: https://github.com/apache/airflow/pull/19668#issuecomment-972540700
Thanks for catching this! Cna you also add a test to make sure `AzureContainerInstancesOperator` will not break again if someone adds a new hook argument?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #19668: Fix argument error in AzureContainerInstancesOperator
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #19668:
URL: https://github.com/apache/airflow/pull/19668#issuecomment-972476966
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on pull request #19668: Fix argument error in AzureContainerInstancesOperator
Posted by GitBox <gi...@apache.org>.
uranusjr commented on pull request #19668:
URL: https://github.com/apache/airflow/pull/19668#issuecomment-972660590
Actually I considered a bit and didn’t have a very good idea how to test this. Maybe someone can suggest a way, but if not, I think it’s OK to merge this as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #19668: Fix argument error in AzureContainerInstancesOperator
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #19668:
URL: https://github.com/apache/airflow/pull/19668
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr edited a comment on pull request #19668: Fix argument error in AzureContainerInstancesOperator
Posted by GitBox <gi...@apache.org>.
uranusjr edited a comment on pull request #19668:
URL: https://github.com/apache/airflow/pull/19668#issuecomment-972540700
Thanks for catching this! Can you also add a test to make sure `AzureContainerInstancesOperator` will not break again if someone adds a new hook argument?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] chinwobble edited a comment on pull request #19668: Fix argument error in AzureContainerInstancesOperator
Posted by GitBox <gi...@apache.org>.
chinwobble edited a comment on pull request #19668:
URL: https://github.com/apache/airflow/pull/19668#issuecomment-972604616
>
>
> Thanks for catching this! Can you also add a test to make sure `AzureContainerInstancesOperator` will not break again if someone adds a new hook argument?
Happy to add some unit tests.
I'm not very familiar with python unit testing. Could you show me how to do that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] chinwobble commented on pull request #19668: Fix argument error in AzureContainerInstancesOperator
Posted by GitBox <gi...@apache.org>.
chinwobble commented on pull request #19668:
URL: https://github.com/apache/airflow/pull/19668#issuecomment-972604616
>
>
> Thanks for catching this! Can you also add a test to make sure `AzureContainerInstancesOperator` will not break again if someone adds a new hook argument?
> hook
Happy to add some unit tests.
I'm not very familiar with python unit testing. Could you show me how to do that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org