You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/07/17 13:04:13 UTC

[GitHub] [flink] twalthr opened a new pull request #12928: [FLINK-18628][table-common] Fix error message for overloaded function with same parameter names

twalthr opened a new pull request #12928:
URL: https://github.com/apache/flink/pull/12928


   ## What is the purpose of the change
   
   Fixes error message for overloaded function with same parameter names.
   
   ## Brief change log
   
   - We only print named arguments if there are corresponding typed arguments.
   
   ## Verifying this change
   
   This change added tests and can be verified as follows: `InputStrategiesTest`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12928: [FLINK-18628][table-common] Fix error message for overloaded function with same parameter names

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12928:
URL: https://github.com/apache/flink/pull/12928#issuecomment-660104096


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "df64d781ddfc294df6d9682124d992d97e6980da",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "df64d781ddfc294df6d9682124d992d97e6980da",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * df64d781ddfc294df6d9682124d992d97e6980da UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] fhueske commented on pull request #12928: [FLINK-18628][table-common] Fix error message for overloaded function with same parameter names

Posted by GitBox <gi...@apache.org>.
fhueske commented on pull request #12928:
URL: https://github.com/apache/flink/pull/12928#issuecomment-660107764


   Thanks for the fix @twalthr.
   
   The change and test look good to me.
   Let's wait for the build to complete.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] twalthr closed pull request #12928: [FLINK-18628][table-common] Fix error message for overloaded function with same parameter names

Posted by GitBox <gi...@apache.org>.
twalthr closed pull request #12928:
URL: https://github.com/apache/flink/pull/12928


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12928: [FLINK-18628][table-common] Fix error message for overloaded function with same parameter names

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12928:
URL: https://github.com/apache/flink/pull/12928#issuecomment-660104096


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "df64d781ddfc294df6d9682124d992d97e6980da",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4601",
       "triggerID" : "df64d781ddfc294df6d9682124d992d97e6980da",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * df64d781ddfc294df6d9682124d992d97e6980da Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4601) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot edited a comment on pull request #12928: [FLINK-18628][table-common] Fix error message for overloaded function with same parameter names

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #12928:
URL: https://github.com/apache/flink/pull/12928#issuecomment-660104096


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "df64d781ddfc294df6d9682124d992d97e6980da",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4601",
       "triggerID" : "df64d781ddfc294df6d9682124d992d97e6980da",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * df64d781ddfc294df6d9682124d992d97e6980da Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=4601) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #12928: [FLINK-18628][table-common] Fix error message for overloaded function with same parameter names

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #12928:
URL: https://github.com/apache/flink/pull/12928#issuecomment-660096531


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit df64d781ddfc294df6d9682124d992d97e6980da (Fri Jul 17 13:07:00 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org