You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "gbloisi-openaire (via GitHub)" <gi...@apache.org> on 2023/09/18 20:26:57 UTC

[GitHub] [spark] gbloisi-openaire commented on a diff in pull request #42913: [SPARK-45081][SQL][3.4] Encoders.bean does no longer work with read-only properties

gbloisi-openaire commented on code in PR #42913:
URL: https://github.com/apache/spark/pull/42913#discussion_r1329237187


##########
sql/core/src/test/java/test/org/apache/spark/sql/JavaDatasetSuite.java:
##########
@@ -1711,6 +1711,23 @@ public void testEmptyBean() {
     Assert.assertEquals(1, df.collectAsList().size());
   }
 
+  public static class ReadOnlyPropertyBean implements Serializable {
+      public boolean isEmpty() {

Review Comment:
   I just committed the required changes, also for [PR-42634](https://github.com/apache/spark/pull/42829) that is the same patch against master and 3.5.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org