You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2021/10/12 12:52:27 UTC

[GitHub] [echarts] pissang opened a new pull request #15870: fix(performance): optimize progressive rendering performance

pissang opened a new pull request #15870:
URL: https://github.com/apache/echarts/pull/15870


   <!-- Please fill in the following information to help us review your PR more efficiently. -->
   
   ## Brief Information
   
   This pull request is in the type of:
   
   - [ ] bug fixing
   - [ ] new feature
   - [x] others
   
   ### What does this PR do?
   
   Before this change for each frame during progressive rendering, we will traverse all elements in the storage to update z, blend, states, etc. Which brings lots of unnecessary extra cost because we only have to update the new rendered elements.
   
   So this PR we add `eachRendered` method to traverse the new rendered elements in `view/Chart.ts`. And for the series that support progressive rendering will be responsible to manage which elements are rendered in this frame. When updating z, blend, states, we can simply use `eachRendered` instead of previously `view.group.traverse`.
   
   Besides this major change. We also drop the use of `IncrementalDisplayable`. It seems to be an overdesign. We only use it in `LargeSymbolDraw` and `LargeLineDraw`. For these two cases, we can merge the points to reduce the number of elements. The code is simpler, and we can have tooltip and event on the large mode with progressive rendering now:)
   
   Also we brings a new strategy to support series being separated in an individual `zlevel` automatically. Progressive rendered scatter and lines series will be used. And for a long time developers need to configure zlevel manually for lines with trail effect, now it can be done automatically.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org

[GitHub] [echarts] echarts-bot[bot] commented on pull request #15870: fix(performance): optimize progressive rendering performance

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on pull request #15870:
URL: https://github.com/apache/echarts/pull/15870#issuecomment-940983485


   Thanks for your contribution!
   The community will review it ASAP. In the meanwhile, please checkout [the coding standard](https://echarts.apache.org/en/coding-standard.html) and Wiki about [How to make a pull request](https://github.com/apache/echarts/wiki/How-to-make-a-pull-request).
   
   The pull request is marked to be `PR: author is committer` because you are a committer of this project.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org