[GitHub] [arrow] houqp commented on a change in pull request #11858: ARROW-14737: [C++][Dataset] Support URI-decoding partition keys

[GitBox <gi...@apache.org>]

houqp commented on a change in pull request #11858:
URL: https://github.com/apache/arrow/pull/11858#discussion_r764562077



##########
File path: cpp/src/arrow/dataset/partition.h
##########
@@ -106,6 +106,8 @@ struct ARROW_DS_EXPORT KeyValuePartitioningOptions {
   /// After splitting a path into components, decode the path components
   /// before parsing according to this scheme.
   SegmentEncoding segment_encoding = SegmentEncoding::Uri;
+  // Should the key be decoded according to the scheme above too
+  bool decode_key = false;

Review comment:
       @zijie0 has a minimal reproducible example at: https://github.com/delta-io/delta-rs/issues/495#issue-1051108818. I would also prefer we do decode by default. If this could lead to breaking changes, then it makes sense to make it configurable, otherwise, it would be good to remove the option entirely.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org