You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jmeter-dev@jakarta.apache.org by se...@apache.org on 2009/04/08 13:38:51 UTC
svn commit: r763192 - in /jakarta/jmeter/trunk:
src/protocol/http/org/apache/jmeter/protocol/http/control/HeaderManager.java
xdocs/changes.xml
Author: sebb
Date: Wed Apr 8 11:38:51 2009
New Revision: 763192
URL: http://svn.apache.org/viewvc?rev=763192&view=rev
Log:
Bug 46993 - Saving from Header Manager generates ClassCastException
Modified:
jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/HeaderManager.java
jakarta/jmeter/trunk/xdocs/changes.xml
Modified: jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/HeaderManager.java
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/HeaderManager.java?rev=763192&r1=763191&r2=763192&view=diff
==============================================================================
--- jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/HeaderManager.java (original)
+++ jakarta/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/HeaderManager.java Wed Apr 8 11:38:51 2009
@@ -33,6 +33,7 @@
import org.apache.jmeter.config.ConfigTestElement;
import org.apache.jmeter.testelement.TestElement;
import org.apache.jmeter.testelement.property.CollectionProperty;
+import org.apache.jmeter.testelement.property.JMeterProperty;
import org.apache.jorphan.util.JOrphanUtils;
/**
@@ -69,6 +70,11 @@
setProperty(new CollectionProperty(HEADERS, new ArrayList()));
}
+ /**
+ * Get the collection of JMeterProperty entries representing the headers.
+ *
+ * @return the header collection property
+ */
public CollectionProperty getHeaders() {
return (CollectionProperty) getProperty(HEADERS);
}
@@ -100,8 +106,10 @@
}
PrintWriter writer = new PrintWriter(new FileWriter(file));
writer.println("# JMeter generated Header file");// $NON-NLS-1$
- for (int i = 0; i < getHeaders().size(); i++) {
- Header head = (Header) getHeaders().get(i);
+ final CollectionProperty hdrs = getHeaders();
+ for (int i = 0; i < hdrs.size(); i++) {
+ final JMeterProperty hdr = hdrs.get(i);
+ Header head = (Header) hdr.getObjectValue();
writer.println(head.toString());
}
writer.flush();
Modified: jakarta/jmeter/trunk/xdocs/changes.xml
URL: http://svn.apache.org/viewvc/jakarta/jmeter/trunk/xdocs/changes.xml?rev=763192&r1=763191&r2=763192&view=diff
==============================================================================
--- jakarta/jmeter/trunk/xdocs/changes.xml (original)
+++ jakarta/jmeter/trunk/xdocs/changes.xml Wed Apr 8 11:38:51 2009
@@ -200,6 +200,7 @@
<li>Bug 46844 - "Library" label in test plan are not I18N</li>
<li>Bug 46977 - JMeter does not handle HTTP headers not delimited by whitespace</li>
<li>Remove Host from headers saved by the Proxy server, as that will normally be generated by the HTTP stack</li>
+<li>Bug 46993 - Saving from Header Manager generates ClassCastException</li>
</ul>
<h3>Improvements</h3>
---------------------------------------------------------------------
To unsubscribe, e-mail: jmeter-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: jmeter-dev-help@jakarta.apache.org