You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/10/12 12:33:26 UTC
[GitHub] [incubator-kyuubi] cfmcgrady opened a new pull request, #3618: [KYUUBI #3615] Retry opening the engine when encountering a special error
cfmcgrady opened a new pull request, #3618:
URL: https://github.com/apache/incubator-kyuubi/pull/3618
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
TODO
### _How was this patch tested?_
- [x] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 closed pull request #3618: [KYUUBI #3615] Retry opening the engine when encountering a special error
Posted by GitBox <gi...@apache.org>.
pan3793 closed pull request #3618: [KYUUBI #3615] Retry opening the engine when encountering a special error
URL: https://github.com/apache/incubator-kyuubi/pull/3618
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #3618: [KYUUBI #3615] Retry opening the engine when encountering a special error
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #3618:
URL: https://github.com/apache/incubator-kyuubi/pull/3618#issuecomment-1285010117
Thanks, merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #3618: [KYUUBI #3615] Retry opening the engine when encountering a special error
Posted by GitBox <gi...@apache.org>.
turboFei commented on code in PR #3618:
URL: https://github.com/apache/incubator-kyuubi/pull/3618#discussion_r995327124
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala:
##########
@@ -117,26 +117,45 @@ class KyuubiSessionImpl(
openEngineSessionConf =
optimizedConf ++ Map(KYUUBI_ENGINE_CREDENTIALS_KEY -> engineCredentials)
}
- val (host, port) = engine.getOrCreate(discoveryClient, extraEngineLog)
val passwd =
if (sessionManager.getConf.get(ENGINE_SECURITY_ENABLED)) {
InternalSecurityAccessor.get().issueToken()
} else {
Option(password).filter(_.nonEmpty).getOrElse("anonymous")
}
- try {
- _client = KyuubiSyncThriftClient.createClient(user, passwd, host, port, sessionConf)
- _engineSessionHandle = _client.openSession(protocol, user, passwd, openEngineSessionConf)
- } catch {
- case e: Throwable =>
- error(
- s"Opening engine [${engine.defaultEngineName} $host:$port]" +
- s" for $user session failed",
- e)
- throw e
+
+ val maxAttempts = sessionManager.getConf.get(ENGINE_OPEN_MAX_ATTEMPTS)
+ val retryInterval = sessionManager.getConf.get(ENGINE_OPEN_INTERVAL)
Review Comment:
retryInterval -> retryWait
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #3618: [KYUUBI #3615] Retry opening the engine when encountering a special error
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3618:
URL: https://github.com/apache/incubator-kyuubi/pull/3618#issuecomment-1280241893
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/3618?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3618](https://codecov.io/gh/apache/incubator-kyuubi/pull/3618?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a1395a6) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/f3244ad30b6eee9567a0d7016ec40936293983e0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f3244ad) will **increase** coverage by `0.00%`.
> The diff coverage is `71.05%`.
> :exclamation: Current head a1395a6 differs from pull request most recent head 96acd66. Consider uploading reports for the commit 96acd66 to get more accurate results
```diff
@@ Coverage Diff @@
## master #3618 +/- ##
=========================================
Coverage 51.88% 51.88%
Complexity 13 13
=========================================
Files 484 484
Lines 27074 27102 +28
Branches 3782 3787 +5
=========================================
+ Hits 14047 14062 +15
- Misses 11663 11669 +6
- Partials 1364 1371 +7
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/3618?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../org/apache/kyuubi/session/KyuubiSessionImpl.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3618/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXNzaW9uL0t5dXViaVNlc3Npb25JbXBsLnNjYWxh) | `75.22% <60.71%> (-0.57%)` | :arrow_down: |
| [...in/scala/org/apache/kyuubi/config/KyuubiConf.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3618/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jb25maWcvS3l1dWJpQ29uZi5zY2FsYQ==) | `97.36% <100.00%> (+0.02%)` | :arrow_up: |
| [.../kyuubi/server/mysql/constant/MySQLErrorCode.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3618/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvbXlzcWwvY29uc3RhbnQvTXlTUUxFcnJvckNvZGUuc2NhbGE=) | `13.84% <0.00%> (-6.16%)` | :arrow_down: |
| [...ache/kyuubi/server/mysql/MySQLCommandHandler.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3618/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvbXlzcWwvTXlTUUxDb21tYW5kSGFuZGxlci5zY2FsYQ==) | `75.00% <0.00%> (-4.55%)` | :arrow_down: |
| [...ache/kyuubi/server/mysql/MySQLGenericPackets.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3618/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvbXlzcWwvTXlTUUxHZW5lcmljUGFja2V0cy5zY2FsYQ==) | `76.59% <0.00%> (-2.13%)` | :arrow_down: |
| [...ain/scala/org/apache/kyuubi/engine/EngineRef.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3618/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvRW5naW5lUmVmLnNjYWxh) | `72.26% <0.00%> (-0.85%)` | :arrow_down: |
| [...yuubi/server/metadata/jdbc/JDBCMetadataStore.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3618/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9zZXJ2ZXIvbWV0YWRhdGEvamRiYy9KREJDTWV0YWRhdGFTdG9yZS5zY2FsYQ==) | `89.27% <0.00%> (-0.70%)` | :arrow_down: |
| [.../org/apache/kyuubi/operation/KyuubiOperation.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/3618/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uLnNjYWxh) | `77.77% <0.00%> (+4.93%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #3618: [KYUUBI #3615] Retry opening the engine when encountering a special error
Posted by GitBox <gi...@apache.org>.
turboFei commented on code in PR #3618:
URL: https://github.com/apache/incubator-kyuubi/pull/3618#discussion_r995326593
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -955,6 +955,20 @@ object KyuubiConf {
.timeConf
.createWithDefault(Duration.ofSeconds(120).toMillis)
+ val ENGINE_OPEN_MAX_ATTEMPTS: ConfigEntry[Int] =
+ buildConf("kyuubi.session.engine.open.max.attempts")
+ .doc("The number of times an open engine will retry when encountering a special error.")
+ .version("1.7.0")
+ .intConf
+ .createWithDefault(9)
+
+ val ENGINE_OPEN_INTERVAL: ConfigEntry[Long] =
+ buildConf("kyuubi.session.engine.open.interval")
+ .doc("The interval for opening engine.")
Review Comment:
kyuubi.session.engine.open.retry.wait
.doc("How long to wait before retrying to open engine after a failure.")
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #3618: [KYUUBI #3615] Retry opening the engine when encountering a special error
Posted by GitBox <gi...@apache.org>.
turboFei commented on code in PR #3618:
URL: https://github.com/apache/incubator-kyuubi/pull/3618#discussion_r995327875
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala:
##########
@@ -117,26 +117,45 @@ class KyuubiSessionImpl(
openEngineSessionConf =
optimizedConf ++ Map(KYUUBI_ENGINE_CREDENTIALS_KEY -> engineCredentials)
}
- val (host, port) = engine.getOrCreate(discoveryClient, extraEngineLog)
val passwd =
if (sessionManager.getConf.get(ENGINE_SECURITY_ENABLED)) {
InternalSecurityAccessor.get().issueToken()
} else {
Option(password).filter(_.nonEmpty).getOrElse("anonymous")
}
- try {
- _client = KyuubiSyncThriftClient.createClient(user, passwd, host, port, sessionConf)
- _engineSessionHandle = _client.openSession(protocol, user, passwd, openEngineSessionConf)
- } catch {
- case e: Throwable =>
- error(
- s"Opening engine [${engine.defaultEngineName} $host:$port]" +
- s" for $user session failed",
- e)
- throw e
+
+ val maxAttempts = sessionManager.getConf.get(ENGINE_OPEN_MAX_ATTEMPTS)
+ val retryInterval = sessionManager.getConf.get(ENGINE_OPEN_INTERVAL)
+ var attempt = 0
+ var shouldRetry = true
+ while (attempt <= maxAttempts && shouldRetry) {
+ val (host, port) = engine.getOrCreate(discoveryClient, extraEngineLog)
+ try {
+ _client = KyuubiSyncThriftClient.createClient(user, passwd, host, port, sessionConf)
+ _engineSessionHandle = _client.openSession(protocol, user, passwd, openEngineSessionConf)
+ logSessionInfo(s"Connected to engine [$host:$port]/[${client.engineId.getOrElse("")}]" +
+ s" with ${_engineSessionHandle}]")
+ shouldRetry = false
+ } catch {
+ case e: org.apache.thrift.transport.TTransportException
+ if attempt < maxAttempts && e.getCause.isInstanceOf[java.net.ConnectException] &&
+ e.getCause.getMessage.contains("Connection refused (Connection refused)") =>
+ warn(
+ s"Failed to opening [${engine.defaultEngineName} $host:$port] after" +
Review Comment:
nit: Failed to open
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] turboFei commented on a diff in pull request #3618: [KYUUBI #3615] Retry opening the engine when encountering a special error
Posted by GitBox <gi...@apache.org>.
turboFei commented on code in PR #3618:
URL: https://github.com/apache/incubator-kyuubi/pull/3618#discussion_r1018601675
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/session/KyuubiSessionImpl.scala:
##########
@@ -117,26 +117,45 @@ class KyuubiSessionImpl(
openEngineSessionConf =
optimizedConf ++ Map(KYUUBI_ENGINE_CREDENTIALS_KEY -> engineCredentials)
}
- val (host, port) = engine.getOrCreate(discoveryClient, extraEngineLog)
val passwd =
if (sessionManager.getConf.get(ENGINE_SECURITY_ENABLED)) {
InternalSecurityAccessor.get().issueToken()
} else {
Option(password).filter(_.nonEmpty).getOrElse("anonymous")
}
- try {
- _client = KyuubiSyncThriftClient.createClient(user, passwd, host, port, sessionConf)
- _engineSessionHandle = _client.openSession(protocol, user, passwd, openEngineSessionConf)
- } catch {
- case e: Throwable =>
- error(
- s"Opening engine [${engine.defaultEngineName} $host:$port]" +
- s" for $user session failed",
- e)
- throw e
+
+ val maxAttempts = sessionManager.getConf.get(ENGINE_OPEN_MAX_ATTEMPTS)
+ val retryWait = sessionManager.getConf.get(ENGINE_OPEN_RETRY_WAIT)
Review Comment:
It is better that we can set the max attempts and retry wait for session level?
Now, we can only set it in server side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org