You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/01/05 08:48:41 UTC
[GitHub] [flink] becketqin opened a new pull request #14557: [FLINK-20781] Avoid NPE after SourceOperator is closed.
becketqin opened a new pull request #14557:
URL: https://github.com/apache/flink/pull/14557
## What is the purpose of the change
This patch is a band-aid patch that prevent NPE thrown from SourceOperator after it is closed.
The root cause of the NPE is in the out of order mailbox task shutdown sequence which may result in method invocation on `SourceOperator` after it is closed. A proper fix would be fix the the mailbox shutdown sequence.
## Brief change log
- Avoid NPE after SourceOperator is closed.
## Verifying this change
Ran `UnalignedCheckpointITCase` for over 1500 times in IDE without failure.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (**no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (**no**)
- The serializers: (**no**)
- The runtime per-record code paths (performance sensitive): (**no**)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (**no**)
- The S3 file system connector: (**no**)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] becketqin commented on pull request #14557: [FLINK-20781] Avoid NPE after SourceOperator is closed.
Posted by GitBox <gi...@apache.org>.
becketqin commented on pull request #14557:
URL: https://github.com/apache/flink/pull/14557#issuecomment-756008444
@xintongsong Maybe we don't have to wait for this CI test. The CI test from my personal Azure pipeline has passed. https://dev.azure.com/becketqin/apache-flink/_build/results?buildId=131
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] becketqin closed pull request #14557: [FLINK-20781] Avoid NPE after SourceOperator is closed.
Posted by GitBox <gi...@apache.org>.
becketqin closed pull request #14557:
URL: https://github.com/apache/flink/pull/14557
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14557: [FLINK-20781] Avoid NPE after SourceOperator is closed.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14557:
URL: https://github.com/apache/flink/pull/14557#issuecomment-754510928
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4d66e1dd7d08d10ffb01a48912657d365e37fed8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11642",
"triggerID" : "4d66e1dd7d08d10ffb01a48912657d365e37fed8",
"triggerType" : "PUSH"
}, {
"hash" : "4d66e1dd7d08d10ffb01a48912657d365e37fed8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11642",
"triggerID" : "755263794",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 4d66e1dd7d08d10ffb01a48912657d365e37fed8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11642)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xintongsong commented on pull request #14557: [FLINK-20781] Avoid NPE after SourceOperator is closed.
Posted by GitBox <gi...@apache.org>.
xintongsong commented on pull request #14557:
URL: https://github.com/apache/flink/pull/14557#issuecomment-755263794
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14557: [FLINK-20781] Avoid NPE after SourceOperator is closed.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14557:
URL: https://github.com/apache/flink/pull/14557#issuecomment-754498276
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit bd51013d93c5b1b116a246a29de800714f576ce6 (Fri May 28 07:02:04 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14557: [FLINK-20781] Avoid NPE after SourceOperator is closed.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14557:
URL: https://github.com/apache/flink/pull/14557#issuecomment-754510928
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4d66e1dd7d08d10ffb01a48912657d365e37fed8",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11642",
"triggerID" : "4d66e1dd7d08d10ffb01a48912657d365e37fed8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4d66e1dd7d08d10ffb01a48912657d365e37fed8 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11642)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] becketqin commented on pull request #14557: [FLINK-20781] Avoid NPE after SourceOperator is closed.
Posted by GitBox <gi...@apache.org>.
becketqin commented on pull request #14557:
URL: https://github.com/apache/flink/pull/14557#issuecomment-755830677
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14557: [FLINK-20781] Avoid NPE after SourceOperator is closed.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14557:
URL: https://github.com/apache/flink/pull/14557#issuecomment-754510928
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4d66e1dd7d08d10ffb01a48912657d365e37fed8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11642",
"triggerID" : "4d66e1dd7d08d10ffb01a48912657d365e37fed8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4d66e1dd7d08d10ffb01a48912657d365e37fed8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11642)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xintongsong commented on pull request #14557: [FLINK-20781] Avoid NPE after SourceOperator is closed.
Posted by GitBox <gi...@apache.org>.
xintongsong commented on pull request #14557:
URL: https://github.com/apache/flink/pull/14557#issuecomment-756020131
Sounds good.
+1 for merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14557: [FLINK-20781] Avoid NPE after SourceOperator is closed.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14557:
URL: https://github.com/apache/flink/pull/14557#issuecomment-754510928
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4d66e1dd7d08d10ffb01a48912657d365e37fed8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11642",
"triggerID" : "4d66e1dd7d08d10ffb01a48912657d365e37fed8",
"triggerType" : "PUSH"
}, {
"hash" : "4d66e1dd7d08d10ffb01a48912657d365e37fed8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11642",
"triggerID" : "755263794",
"triggerType" : "MANUAL"
}, {
"hash" : "4d66e1dd7d08d10ffb01a48912657d365e37fed8",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11642",
"triggerID" : "755830677",
"triggerType" : "MANUAL"
}, {
"hash" : "bd51013d93c5b1b116a246a29de800714f576ce6",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11726",
"triggerID" : "bd51013d93c5b1b116a246a29de800714f576ce6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* bd51013d93c5b1b116a246a29de800714f576ce6 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11726)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14557: [FLINK-20781] Avoid NPE after SourceOperator is closed.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14557:
URL: https://github.com/apache/flink/pull/14557#issuecomment-754510928
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4d66e1dd7d08d10ffb01a48912657d365e37fed8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11642",
"triggerID" : "4d66e1dd7d08d10ffb01a48912657d365e37fed8",
"triggerType" : "PUSH"
}, {
"hash" : "4d66e1dd7d08d10ffb01a48912657d365e37fed8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11642",
"triggerID" : "755263794",
"triggerType" : "MANUAL"
}, {
"hash" : "4d66e1dd7d08d10ffb01a48912657d365e37fed8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "755830677",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 4d66e1dd7d08d10ffb01a48912657d365e37fed8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11642)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14557: [FLINK-20781] Avoid NPE after SourceOperator is closed.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14557:
URL: https://github.com/apache/flink/pull/14557#issuecomment-754510928
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4d66e1dd7d08d10ffb01a48912657d365e37fed8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11642",
"triggerID" : "4d66e1dd7d08d10ffb01a48912657d365e37fed8",
"triggerType" : "PUSH"
}, {
"hash" : "4d66e1dd7d08d10ffb01a48912657d365e37fed8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11642",
"triggerID" : "755263794",
"triggerType" : "MANUAL"
}, {
"hash" : "4d66e1dd7d08d10ffb01a48912657d365e37fed8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11642",
"triggerID" : "755830677",
"triggerType" : "MANUAL"
}, {
"hash" : "bd51013d93c5b1b116a246a29de800714f576ce6",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bd51013d93c5b1b116a246a29de800714f576ce6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4d66e1dd7d08d10ffb01a48912657d365e37fed8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11642)
* bd51013d93c5b1b116a246a29de800714f576ce6 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14557: [FLINK-20781] Avoid NPE after SourceOperator is closed.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14557:
URL: https://github.com/apache/flink/pull/14557#issuecomment-754510928
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4d66e1dd7d08d10ffb01a48912657d365e37fed8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11642",
"triggerID" : "4d66e1dd7d08d10ffb01a48912657d365e37fed8",
"triggerType" : "PUSH"
}, {
"hash" : "4d66e1dd7d08d10ffb01a48912657d365e37fed8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "755263794",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 4d66e1dd7d08d10ffb01a48912657d365e37fed8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11642)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14557: [FLINK-20781] Avoid NPE after SourceOperator is closed.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14557:
URL: https://github.com/apache/flink/pull/14557#issuecomment-754498276
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 4d66e1dd7d08d10ffb01a48912657d365e37fed8 (Tue Jan 05 08:51:36 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #14557: [FLINK-20781] Avoid NPE after SourceOperator is closed.
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #14557:
URL: https://github.com/apache/flink/pull/14557#issuecomment-755147374
I reported the build failure here: https://issues.apache.org/jira/browse/FLINK-17441
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14557: [FLINK-20781] Avoid NPE after SourceOperator is closed.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14557:
URL: https://github.com/apache/flink/pull/14557#issuecomment-754510928
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4d66e1dd7d08d10ffb01a48912657d365e37fed8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11642",
"triggerID" : "4d66e1dd7d08d10ffb01a48912657d365e37fed8",
"triggerType" : "PUSH"
}, {
"hash" : "4d66e1dd7d08d10ffb01a48912657d365e37fed8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11642",
"triggerID" : "755263794",
"triggerType" : "MANUAL"
}, {
"hash" : "4d66e1dd7d08d10ffb01a48912657d365e37fed8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11642",
"triggerID" : "755830677",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 4d66e1dd7d08d10ffb01a48912657d365e37fed8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11642)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #14557: [FLINK-20781] Avoid NPE after SourceOperator is closed.
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14557:
URL: https://github.com/apache/flink/pull/14557#issuecomment-754510928
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4d66e1dd7d08d10ffb01a48912657d365e37fed8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11642",
"triggerID" : "4d66e1dd7d08d10ffb01a48912657d365e37fed8",
"triggerType" : "PUSH"
}, {
"hash" : "4d66e1dd7d08d10ffb01a48912657d365e37fed8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11642",
"triggerID" : "755263794",
"triggerType" : "MANUAL"
}, {
"hash" : "4d66e1dd7d08d10ffb01a48912657d365e37fed8",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11642",
"triggerID" : "755830677",
"triggerType" : "MANUAL"
}, {
"hash" : "bd51013d93c5b1b116a246a29de800714f576ce6",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11726",
"triggerID" : "bd51013d93c5b1b116a246a29de800714f576ce6",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4d66e1dd7d08d10ffb01a48912657d365e37fed8 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11642)
* bd51013d93c5b1b116a246a29de800714f576ce6 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=11726)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] xintongsong commented on pull request #14557: [FLINK-20781] Avoid NPE after SourceOperator is closed.
Posted by GitBox <gi...@apache.org>.
xintongsong commented on pull request #14557:
URL: https://github.com/apache/flink/pull/14557#issuecomment-755937641
It's weird that the flinkbot command is not working.
I've rebased the latest master and pushed to trigger the ci tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #14557: [FLINK-20781] Avoid NPE after SourceOperator is closed.
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14557:
URL: https://github.com/apache/flink/pull/14557#issuecomment-754510928
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "4d66e1dd7d08d10ffb01a48912657d365e37fed8",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4d66e1dd7d08d10ffb01a48912657d365e37fed8",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4d66e1dd7d08d10ffb01a48912657d365e37fed8 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] becketqin commented on pull request #14557: [FLINK-20781] Avoid NPE after SourceOperator is closed.
Posted by GitBox <gi...@apache.org>.
becketqin commented on pull request #14557:
URL: https://github.com/apache/flink/pull/14557#issuecomment-756243826
Patch merged.
master: 9720e5633cf6b85f78a3b6d6f92ed22a7479658e
release-1.12: 7c7f0839f5d13147c24a9e33fb93a7a6758e844b
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org