You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "He-Pin (via GitHub)" <gi...@apache.org> on 2024/01/23 13:00:25 UTC
[PR] chore: Update java-formatter ignore lists [incubator-pekko]
He-Pin opened a new pull request, #1030:
URL: https://github.com/apache/incubator-pekko/pull/1030
Motivation:
Add these files so they are not been formatted when run `sbt javafmtAll`.
Result:
There files are ignored.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: Update java-formatter ignore lists [incubator-pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #1030:
URL: https://github.com/apache/incubator-pekko/pull/1030#issuecomment-1906026753
This should be backport to 1.0.x too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: Update java-formatter ignore lists [incubator-pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #1030:
URL: https://github.com/apache/incubator-pekko/pull/1030#discussion_r1463351485
##########
actor-tests/src/test/java/org/apache/pekko/dispatch/JavaFutureTests.java:
##########
@@ -40,25 +40,31 @@ public class JavaFutureTests extends JUnitSuite {
@ClassRule
public static PekkoJUnitActorSystemResource actorSystemResource =
- new PekkoJUnitActorSystemResource("JavaFutureTests", PekkoSpec.testConf());
+ new PekkoJUnitActorSystemResource("JavaFutureTests", PekkoSpec.testConf());
private final ActorSystem system = actorSystemResource.getSystem();
private final Duration timeout = Duration.create(5, TimeUnit.SECONDS);
@Test
public void mustBeAbleToMapAFuture() throws Exception {
- Future<String> f1 = Futures.future(new Callable<String>() {
- public String call() {
- return "Hello";
- }
- }, system.dispatcher());
-
- Future<String> f2 = f1.map(new Mapper<String, String>() {
- public String apply(String s) {
- return s + " World";
- }
- }, system.dispatcher());
+ Future<String> f1 =
+ Futures.future(
+ new Callable<String>() {
+ public String call() {
+ return "Hello";
+ }
+ },
+ system.dispatcher());
Review Comment:
I will merge, this thanks everyone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: Update java-formatter ignore lists [incubator-pekko]
Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on code in PR #1030:
URL: https://github.com/apache/incubator-pekko/pull/1030#discussion_r1463289891
##########
actor-tests/src/test/java/org/apache/pekko/dispatch/JavaFutureTests.java:
##########
@@ -40,25 +40,31 @@ public class JavaFutureTests extends JUnitSuite {
@ClassRule
public static PekkoJUnitActorSystemResource actorSystemResource =
- new PekkoJUnitActorSystemResource("JavaFutureTests", PekkoSpec.testConf());
+ new PekkoJUnitActorSystemResource("JavaFutureTests", PekkoSpec.testConf());
private final ActorSystem system = actorSystemResource.getSystem();
private final Duration timeout = Duration.create(5, TimeUnit.SECONDS);
@Test
public void mustBeAbleToMapAFuture() throws Exception {
- Future<String> f1 = Futures.future(new Callable<String>() {
- public String call() {
- return "Hello";
- }
- }, system.dispatcher());
-
- Future<String> f2 = f1.map(new Mapper<String, String>() {
- public String apply(String s) {
- return s + " World";
- }
- }, system.dispatcher());
+ Future<String> f1 =
+ Futures.future(
+ new Callable<String>() {
+ public String call() {
+ return "Hello";
+ }
+ },
+ system.dispatcher());
Review Comment:
These formats seem to have reduced readability, have they change dby `javafmt`?
##########
actor-tests/src/test/java/org/apache/pekko/dispatch/JavaFutureTests.java:
##########
@@ -40,25 +40,31 @@ public class JavaFutureTests extends JUnitSuite {
@ClassRule
public static PekkoJUnitActorSystemResource actorSystemResource =
- new PekkoJUnitActorSystemResource("JavaFutureTests", PekkoSpec.testConf());
+ new PekkoJUnitActorSystemResource("JavaFutureTests", PekkoSpec.testConf());
private final ActorSystem system = actorSystemResource.getSystem();
private final Duration timeout = Duration.create(5, TimeUnit.SECONDS);
@Test
public void mustBeAbleToMapAFuture() throws Exception {
- Future<String> f1 = Futures.future(new Callable<String>() {
- public String call() {
- return "Hello";
- }
- }, system.dispatcher());
-
- Future<String> f2 = f1.map(new Mapper<String, String>() {
- public String apply(String s) {
- return s + " World";
- }
- }, system.dispatcher());
+ Future<String> f1 =
+ Futures.future(
+ new Callable<String>() {
+ public String call() {
+ return "Hello";
+ }
+ },
+ system.dispatcher());
Review Comment:
These formats seem to have reduced readability, have they changed by `javafmt`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: Update java-formatter ignore lists [incubator-pekko]
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #1030:
URL: https://github.com/apache/incubator-pekko/pull/1030#discussion_r1463293962
##########
actor-tests/src/test/java/org/apache/pekko/dispatch/JavaFutureTests.java:
##########
@@ -40,25 +40,31 @@ public class JavaFutureTests extends JUnitSuite {
@ClassRule
public static PekkoJUnitActorSystemResource actorSystemResource =
- new PekkoJUnitActorSystemResource("JavaFutureTests", PekkoSpec.testConf());
+ new PekkoJUnitActorSystemResource("JavaFutureTests", PekkoSpec.testConf());
private final ActorSystem system = actorSystemResource.getSystem();
private final Duration timeout = Duration.create(5, TimeUnit.SECONDS);
@Test
public void mustBeAbleToMapAFuture() throws Exception {
- Future<String> f1 = Futures.future(new Callable<String>() {
- public String call() {
- return "Hello";
- }
- }, system.dispatcher());
-
- Future<String> f2 = f1.map(new Mapper<String, String>() {
- public String apply(String s) {
- return s + " World";
- }
- }, system.dispatcher());
+ Future<String> f1 =
+ Futures.future(
+ new Callable<String>() {
+ public String call() {
+ return "Hello";
+ }
+ },
+ system.dispatcher());
Review Comment:
I think the format is ok. It is just more spread out - I would actually marginally prefer the new one.
The key thing is that we get the format to match what is defined in the format config instead of having some files that have different formats.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: Update java-formatter ignore lists [incubator-pekko]
Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on code in PR #1030:
URL: https://github.com/apache/incubator-pekko/pull/1030#discussion_r1463336686
##########
actor-tests/src/test/java/org/apache/pekko/dispatch/JavaFutureTests.java:
##########
@@ -40,25 +40,31 @@ public class JavaFutureTests extends JUnitSuite {
@ClassRule
public static PekkoJUnitActorSystemResource actorSystemResource =
- new PekkoJUnitActorSystemResource("JavaFutureTests", PekkoSpec.testConf());
+ new PekkoJUnitActorSystemResource("JavaFutureTests", PekkoSpec.testConf());
private final ActorSystem system = actorSystemResource.getSystem();
private final Duration timeout = Duration.create(5, TimeUnit.SECONDS);
@Test
public void mustBeAbleToMapAFuture() throws Exception {
- Future<String> f1 = Futures.future(new Callable<String>() {
- public String call() {
- return "Hello";
- }
- }, system.dispatcher());
-
- Future<String> f2 = f1.map(new Mapper<String, String>() {
- public String apply(String s) {
- return s + " World";
- }
- }, system.dispatcher());
+ Future<String> f1 =
+ Futures.future(
+ new Callable<String>() {
+ public String call() {
+ return "Hello";
+ }
+ },
+ system.dispatcher());
Review Comment:
I am okay with that because it breaks the development experience.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: Update java-formatter ignore lists [incubator-pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #1030:
URL: https://github.com/apache/incubator-pekko/pull/1030#discussion_r1463296763
##########
actor-tests/src/test/java/org/apache/pekko/dispatch/JavaFutureTests.java:
##########
@@ -40,25 +40,31 @@ public class JavaFutureTests extends JUnitSuite {
@ClassRule
public static PekkoJUnitActorSystemResource actorSystemResource =
- new PekkoJUnitActorSystemResource("JavaFutureTests", PekkoSpec.testConf());
+ new PekkoJUnitActorSystemResource("JavaFutureTests", PekkoSpec.testConf());
private final ActorSystem system = actorSystemResource.getSystem();
private final Duration timeout = Duration.create(5, TimeUnit.SECONDS);
@Test
public void mustBeAbleToMapAFuture() throws Exception {
- Future<String> f1 = Futures.future(new Callable<String>() {
- public String call() {
- return "Hello";
- }
- }, system.dispatcher());
-
- Future<String> f2 = f1.map(new Mapper<String, String>() {
- public String apply(String s) {
- return s + " World";
- }
- }, system.dispatcher());
+ Future<String> f1 =
+ Futures.future(
+ new Callable<String>() {
+ public String call() {
+ return "Hello";
+ }
+ },
+ system.dispatcher());
Review Comment:
You can test it with sbt javafmtAll .I have to revert everytime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: Update java-formatter ignore lists [incubator-pekko]
Posted by "Roiocam (via GitHub)" <gi...@apache.org>.
Roiocam commented on code in PR #1030:
URL: https://github.com/apache/incubator-pekko/pull/1030#discussion_r1463289891
##########
actor-tests/src/test/java/org/apache/pekko/dispatch/JavaFutureTests.java:
##########
@@ -40,25 +40,31 @@ public class JavaFutureTests extends JUnitSuite {
@ClassRule
public static PekkoJUnitActorSystemResource actorSystemResource =
- new PekkoJUnitActorSystemResource("JavaFutureTests", PekkoSpec.testConf());
+ new PekkoJUnitActorSystemResource("JavaFutureTests", PekkoSpec.testConf());
private final ActorSystem system = actorSystemResource.getSystem();
private final Duration timeout = Duration.create(5, TimeUnit.SECONDS);
@Test
public void mustBeAbleToMapAFuture() throws Exception {
- Future<String> f1 = Futures.future(new Callable<String>() {
- public String call() {
- return "Hello";
- }
- }, system.dispatcher());
-
- Future<String> f2 = f1.map(new Mapper<String, String>() {
- public String apply(String s) {
- return s + " World";
- }
- }, system.dispatcher());
+ Future<String> f1 =
+ Futures.future(
+ new Callable<String>() {
+ public String call() {
+ return "Hello";
+ }
+ },
+ system.dispatcher());
Review Comment:
These formats seem to have reduced readability, did they change by `javafmt`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] chore: Update java-formatter ignore lists [incubator-pekko]
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin merged PR #1030:
URL: https://github.com/apache/incubator-pekko/pull/1030
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org