You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/11 13:43:11 UTC
[GitHub] [superset] kgabryje opened a new pull request #13575: feat: Implement drag and drop for metrics
kgabryje opened a new pull request #13575:
URL: https://github.com/apache/superset/pull/13575
### SUMMARY
This PR implements creating adhoc metrics by dragging columns and saved metrics from datasource panel to metrics control.
When user drops a column or saved metric, a popover opens pre-filled with values - if a metric was dropped, a "Saved metrics" tab is open by default with a proper metric selected, otherwise "Simple" tab is open with a column selected.
The old functionality of creating a metric by clicking a "plus" button has ben removed.
To use the feature, enable `ENABLE_EXPLORE_DRAG_AND_DROP` feature flag and use changes from https://github.com/apache-superset/superset-ui/pull/1004.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
https://user-images.githubusercontent.com/15073128/110795291-f7330580-8276-11eb-95bc-5255d7f50c83.mov
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
CC: @villebro @junlincc @zhaoyongjie
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on pull request #13575: feat: Implement drag and drop for metrics
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #13575:
URL: https://github.com/apache/superset/pull/13575#issuecomment-797276428
@ktmud all your counter arguments make sense.
Questions:
Have we done any research on the real need of addressing accessibility issue? Is the number big enough to justify investing 2X(engineer + design + product)to achieve the same feature goal? Superset is an OSS so to me, even 0.1% of users is a big enough number. Those challenges need to be categorized and looked at separately. And have we done enough exploration to prove that there's absolutely no way to solve these challenges within DND? What about keyboard shortcut? Have we done research on how the biggest BI tool in the market,Tableau, solved these challenges? @Steejay @mihir174
we have been constantly balancing requests for fixing broken NVD3 charts vs adding new Echarts, fixing broken FilterBox vs enhancing new native filter. We all have the same goal which is to provide the best UX to our users(i take back my statement of 'our goal is to get rid of select') It's the divided attention or lack of focus stopping us from getting to the ultimate goal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on pull request #13575: feat: Implement drag and drop for metrics
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #13575:
URL: https://github.com/apache/superset/pull/13575#issuecomment-797195068
> If users can click the persistent ghost button to add an item, then the "+" button on the right corner would not be needed.
The goal is not about where to click. The goal is to solve accessibility problem within dnd, and get rid of click-to-select!!!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #13575: feat: Implement drag and drop for metrics
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #13575:
URL: https://github.com/apache/superset/pull/13575#issuecomment-797038073
I think we do still need to ghost button to indicate users can drop more metrics/columns.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on pull request #13575: feat: Implement drag and drop for metrics
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on pull request #13575:
URL: https://github.com/apache/superset/pull/13575#issuecomment-797190078
Some corner issue in title
https://user-images.githubusercontent.com/2016594/110882867-885cb780-831d-11eb-989a-d1ed0dece25e.mp4
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on pull request #13575: feat: Implement drag and drop for metrics
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on pull request #13575:
URL: https://github.com/apache/superset/pull/13575#issuecomment-797188236
We should replace all the metric-like target control, such as `sort by`, `percentage metric`. but this is enough for a POC.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on pull request #13575: feat: Implement drag and drop for metrics
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #13575:
URL: https://github.com/apache/superset/pull/13575#issuecomment-797082613
Hi @steejay thanks for chiming in.
I'm afraid that _click-to-select_ will not support some of the new advanced features we are adding e.g. hierarchy at all. from business standpoint, we are also not gonna invest in maintaining two sets of feature that basically do the same thing. there are more reasons why we need to completely move away from select, comments can be found in
https://github.com/apache/superset/pull/13210
I understand _accessibility_ e.g. color blind, is the main concern, and we need your help to solve it within DND.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on pull request #13575: feat: Implement drag and drop for metrics
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on pull request #13575:
URL: https://github.com/apache/superset/pull/13575#issuecomment-797227720
@kgabryje please bumping the superset-ui in the main repo.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #13575: feat: Implement drag and drop for metrics
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #13575:
URL: https://github.com/apache/superset/pull/13575#issuecomment-797831138
> @ktmud all your counter arguments make sense.
> Questions:
> Have we done any research on the real need of addressing accessibility issue? Is the number big enough to justify investing 2X(engineer + design + product)to achieve the same feature goal? Superset is an OSS so to me, even 0.1% of users is a big enough number. Those challenges need to be categorized and looked at separately. And have we done enough exploration to prove that there's absolutely no way to solve these challenges within DND? What about keyboard shortcut? Have we done research on how the biggest BI tool in the market,Tableau, solved these challenges? @Steejay @mihir174
>
> we have been constantly balancing requests for fixing broken NVD3 charts vs adding new Echarts, fixing broken FilterBox vs enhancing new native filter. We all have the same goal which is to provide the best UX to our users(i take back my statement of 'our goal is to get rid of select') It's the divided attention or lack of focus stopping us from getting to the ultimate goal.
There is a movement called [Inclusive Design](https://en.wikipedia.org/wiki/Inclusive_design) I'm not sure if you have heard of. Basically it says instead of thinking things like accessibility as an investment that benefits only a small fraction of users, we should have the mindset of being inclusive from the very beginning. It doesn't necessary slow you down in the process, but will help you reach to more users.
I have yet to see how supporting click-to-select would slow things down or introduce the so-called 2x maintenance cost. If we want to get rid of it because it doesn't sit well with the DnD experience, that's fine, but in terms of code maintenance, I find it hard to believe it'd be 2x the effort.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #13575: feat: Implement drag and drop for metrics
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #13575:
URL: https://github.com/apache/superset/pull/13575#issuecomment-797175803
If users can click the persistent ghost button to add an item, then the "+" button on the right corner would not be needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on pull request #13575: feat: Implement drag and drop for metrics
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #13575:
URL: https://github.com/apache/superset/pull/13575#issuecomment-797276428
@ktmud all your counter arguments make sense.
Questions:
Have we done any research on the real need to address accessibility issue? Is the number big enough to justify investing 2X to achieve the same feature goal? To me, even 0.1% of users is big enough. And have we done enough exploration to prove that there's absolutely no way to solve these challenges within DND? What about keyboard shortcut?
When we have a clear destination, there could be million ways to get there, let's get creative!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on pull request #13575: feat: Implement drag and drop for metrics
Posted by GitBox <gi...@apache.org>.
kgabryje commented on pull request #13575:
URL: https://github.com/apache/superset/pull/13575#issuecomment-797392897
@junlincc @ktmud @mihir174 I like the idea of displaying the ghost button to indicate that the user can drop more columns and metrics. However, I feel that it requires a design input as in my opinion it looks a bit strange when we display values and the ghost button in current form. Details like misaligned "+" and "x" buttons, maybe a dashed border might need some polishing to make the component look more appealing. WDYT?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on pull request #13575: feat: Implement drag and drop for metrics
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #13575:
URL: https://github.com/apache/superset/pull/13575#issuecomment-797082613
Hi @steejay thanks for chiming in.
I'm afraid that _click-to-select_ will not support some of the new advanced features we are adding e.g. hierarchy at all. from business standpoint, we are also not gonna invest in maintaining two sets of feature that basically do the same thing. there are more reasons why we need to completely move away from select, comments can be found in
https://github.com/apache/superset/pull/13210
I understand _accessibility_ e.g. color blind, is the main concern, and we need your help to solve it within DND.
Can the ghost button persist even when the field is populated with a metric(s)?
I believe that's what ktmud suggested. I'm not sure that's ideal though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on pull request #13575: feat: Implement drag and drop for metrics
Posted by GitBox <gi...@apache.org>.
kgabryje commented on pull request #13575:
URL: https://github.com/apache/superset/pull/13575#issuecomment-797406714
> just one comment, do we still need to open the popover + clicking save when a saved metrics is dropped?
@junlincc Good idea! I'll try to include that in a follow-up PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on pull request #13575: feat: Implement drag and drop for metrics
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #13575:
URL: https://github.com/apache/superset/pull/13575#issuecomment-797276428
@ktmud all your counter arguments make sense.
Questions:
Have we done any research on the real need of addressing accessibility issue? Is the number big enough to justify investing 2X(engineer + design + product)to achieve the same feature goal? Superset is an OSS so to me, even 0.1% of users is a big enough number. And have we done enough exploration to prove that there's absolutely no way to solve these challenges within DND? What about keyboard shortcut? Have we done research on how the biggest BI tool in the market,Tableau, solved these challenges? @Steejay @mihir174
we have been constantly balancing requests for fixing broken NVD3 charts vs adding new Echarts, fixing broken FilterBox vs enhancing new native filter. We all have the same goal which is to provide the best UX to our users(i take back my statement of 'our goal is to get rid of select') It's the divided attention or lack of focus stopping us from getting to the ultimate goal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie edited a comment on pull request #13575: feat: Implement drag and drop for metrics
Posted by GitBox <gi...@apache.org>.
zhaoyongjie edited a comment on pull request #13575:
URL: https://github.com/apache/superset/pull/13575#issuecomment-797227720
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie merged pull request #13575: feat: Implement drag and drop for metrics
Posted by GitBox <gi...@apache.org>.
zhaoyongjie merged pull request #13575:
URL: https://github.com/apache/superset/pull/13575
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #13575: feat: Implement drag and drop for metrics
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13575:
URL: https://github.com/apache/superset/pull/13575#issuecomment-796779682
# [Codecov](https://codecov.io/gh/apache/superset/pull/13575?src=pr&el=h1) Report
> Merging [#13575](https://codecov.io/gh/apache/superset/pull/13575?src=pr&el=desc) (561951a) into [master](https://codecov.io/gh/apache/superset/commit/5fca19da565cae1e70a0dff66007828dbe9fc8ed?el=desc) (5fca19d) will **decrease** coverage by `4.34%`.
> The diff coverage is `14.07%`.
[](https://codecov.io/gh/apache/superset/pull/13575?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13575 +/- ##
==========================================
- Coverage 77.53% 73.19% -4.35%
==========================================
Files 904 604 -300
Lines 45986 21529 -24457
Branches 5552 5682 +130
==========================================
- Hits 35657 15758 -19899
+ Misses 10195 5636 -4559
- Partials 134 135 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.84% <7.43%> (-0.37%)` | :arrow_down: |
| hive | `?` | |
| javascript | `63.08% <14.17%> (-0.31%)` | :arrow_down: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `?` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13575?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...controls/DndColumnSelectControl/DndSelectLabel.tsx](https://codecov.io/gh/apache/superset/pull/13575/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZFNlbGVjdExhYmVsLnRzeA==) | `36.84% <0.00%> (-2.05%)` | :arrow_down: |
| [...s/controls/MetricControl/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/superset/pull/13575/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL01ldHJpY0RlZmluaXRpb25WYWx1ZS5qc3g=) | `100.00% <ø> (+5.88%)` | :arrow_up: |
| [...-frontend/src/explore/components/controls/index.js](https://codecov.io/gh/apache/superset/pull/13575/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9pbmRleC5qcw==) | `100.00% <ø> (ø)` | |
| [...ontrols/DndColumnSelectControl/DndMetricSelect.tsx](https://codecov.io/gh/apache/superset/pull/13575/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZE1ldHJpY1NlbGVjdC50c3g=) | `10.40% <10.40%> (ø)` | |
| [...ontrols/DndColumnSelectControl/DndFilterSelect.tsx](https://codecov.io/gh/apache/superset/pull/13575/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL0RuZEZpbHRlclNlbGVjdC50c3g=) | `9.23% <50.00%> (ø)` | |
| [...ntrols/MetricControl/AdhocMetricPopoverTrigger.tsx](https://codecov.io/gh/apache/superset/pull/13575/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljUG9wb3ZlclRyaWdnZXIudHN4) | `93.33% <75.00%> (-1.41%)` | :arrow_down: |
| [...omponents/controls/DndColumnSelectControl/index.ts](https://codecov.io/gh/apache/superset/pull/13575/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EbmRDb2x1bW5TZWxlY3RDb250cm9sL2luZGV4LnRz) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engine\_specs/solr.py](https://codecov.io/gh/apache/superset/pull/13575/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3NvbHIucHk=) | | |
| [superset/connectors/connector\_registry.py](https://codecov.io/gh/apache/superset/pull/13575/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9jb25uZWN0b3JfcmVnaXN0cnkucHk=) | | |
| [superset/common/query\_context.py](https://codecov.io/gh/apache/superset/pull/13575/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2NvbnRleHQucHk=) | | |
| ... and [299 more](https://codecov.io/gh/apache/superset/pull/13575/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13575?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13575?src=pr&el=footer). Last update [5fca19d...54be16b](https://codecov.io/gh/apache/superset/pull/13575?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on pull request #13575: feat: Implement drag and drop for metrics
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #13575:
URL: https://github.com/apache/superset/pull/13575#issuecomment-797276428
@ktmud all your counter arguments make sense.
Questions:
Have we done any research on the real need to address accessibility issue? Is the number big enough to justify investing 2X(engineer + design + product)to achieve the same feature goal? Superset is an OSS so to me, even 0.1% of users is a big enough number. And have we done enough exploration to prove that there's absolutely no way to solve these challenges within DND? What about keyboard shortcut?
We have been constantly balancing requests for fixing broken NVD3 charts vs adding new Echarts, fixing broken FilterBox vs enhancing new native filter. We all have the same goal which is to provide the best UX to our users. It's the divided attention and focus stopping us from getting to the ultimate goal sooner.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on pull request #13575: feat: Implement drag and drop for metrics
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #13575:
URL: https://github.com/apache/superset/pull/13575#issuecomment-797082613
Hi @steejay thanks for chiming in.
I'm afraid that _click-to-select_ will not support some of the new advanced features we are adding e.g. hierarchy at all. from business standpoint, we are also not gonna invest in maintaining two sets of feature that basically do the same thing. there are more reasons why we need to completely move away from select, comments can be found in
https://github.com/apache/superset/pull/13210
I understand _accessibility_ e.g. color blind, is the main concern, and we need your help to solve it within DND.
Can the ghost button persist even when the field is populated with a metric(s)?
I believe that's what ktmud suggested. I'm not sure though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on pull request #13575: feat: Implement drag and drop for metrics
Posted by GitBox <gi...@apache.org>.
kgabryje commented on pull request #13575:
URL: https://github.com/apache/superset/pull/13575#issuecomment-797397213
However, if you think that the ghost button looks fine as it is, I'll open a PR with that change
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a change in pull request #13575: feat: Implement drag and drop for metrics
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #13575:
URL: https://github.com/apache/superset/pull/13575#discussion_r592818978
##########
File path: superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndFilterSelect.tsx
##########
@@ -17,12 +17,12 @@
* under the License.
*/
import React, { useEffect, useMemo, useState } from 'react';
-import { logging, SupersetClient } from '@superset-ui/core';
+import { logging, SupersetClient, t } from '@superset-ui/core';
import { ColumnMeta, Metric } from '@superset-ui/chart-controls';
Review comment:
Bycatch: I believe `Metric` is originally defined in `@superset-ui/core` (probably better to import from there, as I'm unsure why it's exported by `@superset-ui/chart-controls`)
##########
File path: superset-frontend/src/explore/components/controls/DndColumnSelectControl/DndMetricSelect.tsx
##########
@@ -0,0 +1,301 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with work for additional information
+ * regarding copyright ownership. The ASF licenses file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import React, { useCallback, useEffect, useMemo, useState } from 'react';
+import { ensureIsArray, Metric, t } from '@superset-ui/core';
+import { ColumnMeta } from '@superset-ui/chart-controls';
+import { isEqual } from 'lodash';
+import { usePrevious } from 'src/common/hooks/usePrevious';
+import AdhocMetric from '../MetricControl/AdhocMetric';
+import AdhocMetricPopoverTrigger from '../MetricControl/AdhocMetricPopoverTrigger';
+import MetricDefinitionValue from '../MetricControl/MetricDefinitionValue';
+import { OptionValueType } from './types';
+import { DatasourcePanelDndItem } from '../../DatasourcePanel/types';
+import { DndItemType } from '../../DndItemType';
+import DndSelectLabel from './DndSelectLabel';
+import { savedMetricType } from '../MetricControl/types';
+
+const isDictionaryForAdhocMetric = (value: any) =>
+ value && !(value instanceof AdhocMetric) && value.expressionType;
+
+const coerceAdhocMetrics = (value: any) => {
+ if (!value) {
+ return [];
+ }
+ if (!Array.isArray(value)) {
+ if (isDictionaryForAdhocMetric(value)) {
+ return [new AdhocMetric(value)];
+ }
+ return [value];
+ }
+ return value.map(val => {
+ if (isDictionaryForAdhocMetric(val)) {
+ return new AdhocMetric(val);
+ }
+ return val;
+ });
+};
+
+const getOptionsForSavedMetrics = (
+ savedMetrics: savedMetricType[],
+ currentMetricValues: (string | AdhocMetric)[],
+ currentMetric?: string,
+) =>
+ savedMetrics?.filter(savedMetric =>
+ Array.isArray(currentMetricValues)
+ ? !currentMetricValues.includes(savedMetric.metric_name ?? '') ||
+ savedMetric.metric_name === currentMetric
+ : savedMetric,
+ ) ?? [];
+
+const columnsContainAllMetrics = (
+ value: (string | AdhocMetric | ColumnMeta)[],
+ columns: ColumnMeta[],
+ savedMetrics: savedMetricType[],
+) => {
+ const columnNames = new Set(
+ [...(columns || []), ...(savedMetrics || [])]
+ // eslint-disable-next-line camelcase
+ .map(
+ item =>
+ (item as ColumnMeta).column_name ||
+ (item as savedMetricType).metric_name,
+ ),
+ );
+
+ return (
+ ensureIsArray(value)
+ .filter(metric => metric)
+ // find column names
+ .map(metric =>
+ (metric as AdhocMetric).column
+ ? (metric as AdhocMetric).column.column_name
+ : (metric as ColumnMeta).column_name || metric,
+ )
+ .filter(name => name && typeof name === 'string')
+ .every(name => columnNames.has(name))
Review comment:
It would be nice to add type guards for the types in `value` to be able to separate between the different metrics types (`string | AdhocMetric | ColumnMeta`). We could then add a `getMetricName(metric)` helper function which would return the name based on which type it is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on pull request #13575: feat: Implement drag and drop for metrics
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #13575:
URL: https://github.com/apache/superset/pull/13575#issuecomment-797276428
@ktmud all your counter arguments make sense.
Questions:
Have we done any research on the real need of addressing accessibility issue? Is the number big enough to justify investing 2X(engineer + design + product)to achieve the same feature goal? Superset is an OSS so to me, even 0.1% of users is a big enough number. And have we done enough exploration to prove that there's absolutely no way to solve these challenges within DND? What about keyboard shortcut? Have we done research on how the biggest BI tool in the market,Tableau, solved these challenges?
We have been constantly balancing requests for fixing broken NVD3 charts vs adding new Echarts, fixing broken FilterBox vs enhancing new native filter. We all have the same goal which is to provide the best UX to our users. It's the divided attention and focus stopping us from getting to the ultimate goal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on pull request #13575: feat: Implement drag and drop for metrics
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #13575:
URL: https://github.com/apache/superset/pull/13575#issuecomment-797276428
@ktmud all your counter arguments make sense.
Questions:
Have we done any research on the real need to address accessibility issue? Is the number big enough to justify investing 2X to achieve the same feature goal? To me, even 0.001% is big enough. And have we done enough exploration to prove that there's absolutely no way to solve these challenges within DND?
When we have a clear destination, there could be million ways to get there, let's get creative!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #13575: feat: Implement drag and drop for metrics
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #13575:
URL: https://github.com/apache/superset/pull/13575#issuecomment-797195068
> If users can click the persistent ghost button to add an item, then the "+" button on the right corner would not be needed.
The goal is not about where to click. The goal is to solve accessibility within dnd, and get rid of click-to-select!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on pull request #13575: feat: Implement drag and drop for metrics
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #13575:
URL: https://github.com/apache/superset/pull/13575#issuecomment-797195068
> If users can click the persistent ghost button to add an item, then the "+" button on the right corner would not be needed.
It is not about where or what to click. The goal is to solve accessibility problems within dnd, and get rid of click-to-select!!!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #13575: feat: Implement drag and drop for metrics
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #13575:
URL: https://github.com/apache/superset/pull/13575#issuecomment-797245128
@junlincc I don't understand why the goal is get rid of click-to-select, though. As I responded [in the earlier PR](https://github.com/apache/superset/pull/13210#discussion_r582207003), there seems to be a counter-argument to everything you mentioned.
Hierarchical columns sounds like a very advanced feature that I'm not even sure what it is or why we need it, but I'd imagine we could get something working in a popover eventually. Have we heard from designers that it is not possible to add these features without drag & drop?
Re: accessibility, it's more than just colorblind and visual-impairment, but also easiness to interact. As @Steejay mentioned, DnD simply isn't possible for some users in certain scenarios (e.g. people with poor motor control). An DnD only UI will never achieve the same level of accessibility than a clickable Ui.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud edited a comment on pull request #13575: feat: Implement drag and drop for metrics
Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on pull request #13575:
URL: https://github.com/apache/superset/pull/13575#issuecomment-797038073
I think we do still need that ghost button to indicate users can drop more metrics/columns.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #13575: feat: Implement drag and drop for metrics
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #13575:
URL: https://github.com/apache/superset/pull/13575#issuecomment-797190835
> Some corner issue in title
no need to worry about it, those issues will all be addressed in refactoring and redesign.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on pull request #13575: feat: Implement drag and drop for metrics
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #13575:
URL: https://github.com/apache/superset/pull/13575#issuecomment-797195068
> If users can click the persistent ghost button to add an item, then the "+" button on the right corner would not be needed.
The goal is not about where to click. The goal is to solve accessibility problem within dnd, and get rid of click-to-select!!!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on pull request #13575: feat: Implement drag and drop for metrics
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #13575:
URL: https://github.com/apache/superset/pull/13575#issuecomment-797082613
Hi @steejay thanks for chiming in.
I'm afraid that _click-to-select_ will not support some of the new advanced features we are adding e.g. hierarchy at all. from business standpoint, we are also not gonna invest in maintaining two sets of feature that basically do the same thing. there are more reasons why we need to completely move away from select, comments can be found in
https://github.com/apache/superset/pull/13210
I understand _accessibility_ e.g. color blind, is the main concern, and we need your help to solve it within DND.
Can the ghost button persist even when the field is populated with a metric(s)?
I believe that's what mud suggested. I'm not sure that's ideal though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #13575: feat: Implement drag and drop for metrics
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #13575:
URL: https://github.com/apache/superset/pull/13575#issuecomment-797276428
@ktmud all your counter arguments make sense.
Questions:
Have we done any research on the real need to address accessibility issue? Is the number big enough to justify investing 2X to achieve the same feature goal? And have we done enough exploration to prove that there's absolutely no way to solve these challenges within DND?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #13575: feat: Implement drag and drop for metrics
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #13575:
URL: https://github.com/apache/superset/pull/13575#issuecomment-797082613
Hi @steejay thanks for chiming in.
I'm afraid that _click-to-select_ will not support some of the new advanced features we are adding e.g. hierarchy at all. from business standpoint, we are also not gonna invest in maintaining two sets of feature that basically do the same thing. there are more reasons why we need to completely move away from select, comments can be found in
https://github.com/apache/superset/pull/13210
I understand _accessibility_ e.g. color blind, is the main concerns, and we need your help to solve it within DND.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #13575: feat: Implement drag and drop for metrics
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #13575:
URL: https://github.com/apache/superset/pull/13575#issuecomment-797548617
> > Another potential improvement is to display coloured dash border when user starts dragging an element, not only when it's hovering over a control component. That might help users understand where they can drop columns and metrics
> > Screen.Recording.2021-03-12.at.11.43.40.mov
>
> I like this design.
Yeah, me too. I was just thinking to myself that when fully and properly implemented (good scrolling/filtering on column/metric tab, highlighting during dragging etc), DND offers so many small UX improvements that it make the select feature seem almost confusing and awkward. Not sure what I said a few weeks ago, but after careful deliberation, I vote for deprecating the select control as soon as possible :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on pull request #13575: feat: Implement drag and drop for metrics
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #13575:
URL: https://github.com/apache/superset/pull/13575#issuecomment-797276428
@ktmud all your counter arguments make sense.
Questions:
Have we done any research on the real need of addressing accessibility issue? Is the number big enough to justify investing 2X(engineer + design + product)to achieve the same feature goal? Superset is an OSS so to me, even 0.1% of users is a big enough number. And have we done enough exploration to prove that there's absolutely no way to solve these challenges within DND? What about keyboard shortcut? Have we done research on how the biggest BI tool in the market,Tableau, solved these challenges? @Steejay @mihir174
We have been constantly balancing requests for fixing broken NVD3 charts vs adding new Echarts, fixing broken FilterBox vs enhancing new native filter. We all have the same goal which is to provide the best UX to our users. It's the divided attention and focus stopping us from getting to the ultimate goal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie commented on pull request #13575: feat: Implement drag and drop for metrics
Posted by GitBox <gi...@apache.org>.
zhaoyongjie commented on pull request #13575:
URL: https://github.com/apache/superset/pull/13575#issuecomment-797545367
> Another potential improvement is to display coloured dash border when user starts dragging an element, not only when it's hovering over a control component. That might help users understand where they can drop columns and metrics
> Screen.Recording.2021-03-12.at.11.43.40.mov
I like this design.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Steejay commented on pull request #13575: feat: Implement drag and drop for metrics
Posted by GitBox <gi...@apache.org>.
Steejay commented on pull request #13575:
URL: https://github.com/apache/superset/pull/13575#issuecomment-797047034
re the + button: I think having a secondary way to add metrics besides dragging and dropping is still important especially when considering accessibility. Having a simple click button/action provides users that may have some physical disability (whether temporary, situational or permanent) a way to complete the action more easily. Can the ghost button persist even when the field is populated with a metric(s)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #13575: feat: Implement drag and drop for metrics
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #13575:
URL: https://github.com/apache/superset/pull/13575#issuecomment-797040694
@kgabryje for your context - the only concern about the ghost button is the additional vertical space they take in each drop field.
https://github.com/apache/superset/issues/12631,
https://github.com/apache/superset/discussions/13071
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on pull request #13575: feat: Implement drag and drop for metrics
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #13575:
URL: https://github.com/apache/superset/pull/13575#issuecomment-797276428
@ktmud all your counter arguments make sense.
Questions:
Have we done any research on the real need to address accessibility issue? Is the number big enough to justify investing 2X to achieve the same feature goal? To me, even 0.001% of users is big enough. And have we done enough exploration to prove that there's absolutely no way to solve these challenges within DND?
When we have a clear destination, there could be million ways to get there, let's get creative!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on pull request #13575: feat: Implement drag and drop for metrics
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #13575:
URL: https://github.com/apache/superset/pull/13575#issuecomment-797276428
@ktmud all your counter arguments make sense.
Questions:
Have we done any research on the real need to address accessibility issue? Is the number big enough to justify investing 2X to achieve the same feature goal? To me, even 0.1% of users is big enough. And have we done enough exploration to prove that there's absolutely no way to solve these challenges within DND?
When we have a clear destination, there could be million ways to get there, let's get creative!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on pull request #13575: feat: Implement drag and drop for metrics
Posted by GitBox <gi...@apache.org>.
kgabryje commented on pull request #13575:
URL: https://github.com/apache/superset/pull/13575#issuecomment-797405480
Another potential improvement is to display coloured dash border when user starts dragging an element, not only when it's hovering over a control component. That might help users understand where they can drop columns and metrics
https://user-images.githubusercontent.com/15073128/110929658-7cc2be00-8328-11eb-8485-a153000f96f6.mov
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on pull request #13575: feat: Implement drag and drop for metrics
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #13575:
URL: https://github.com/apache/superset/pull/13575#issuecomment-797195068
> If users can click the persistent ghost button to add an item, then the "+" button on the right corner would not be needed.
Reason why we may need the blue button -> accessibility
Reason why we may need the ghost button -> indicate droppable field
It is not about where or what to click. The goal is to solve these two above within dnd, and get rid of click-to-select!!!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc edited a comment on pull request #13575: feat: Implement drag and drop for metrics
Posted by GitBox <gi...@apache.org>.
junlincc edited a comment on pull request #13575:
URL: https://github.com/apache/superset/pull/13575#issuecomment-797276428
@ktmud all your counter arguments make sense.
Questions:
Have we done any research on the real need of addressing accessibility issue? Is the number big enough to justify investing 2X(engineer + design + product)to achieve the same feature goal? Superset is an OSS so to me, even 0.1% of users is a big enough number. And have we done enough exploration to prove that there's absolutely no way to solve these challenges within DND? What about keyboard shortcut?
We have been constantly balancing requests for fixing broken NVD3 charts vs adding new Echarts, fixing broken FilterBox vs enhancing new native filter. We all have the same goal which is to provide the best UX to our users. It's the divided attention and focus stopping us from getting to the ultimate goal.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on pull request #13575: feat: Implement drag and drop for metrics
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #13575:
URL: https://github.com/apache/superset/pull/13575#issuecomment-797404291
FWIW, I think the ghost button is awesome, much better than the plus button, both aesthetically and functionally (but I agree it needs some polish).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org