[jira] [Commented] (SLING-10900) Update graphl-java to version 17

["Andreas Schaefer (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-10900?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17691777#comment-17691777 ] 

Andreas Schaefer commented on SLING-10900:
------------------------------------------

All graphql-java version newer that 17.4 have an issue with the released JAR file as the MANIFEST.MF entry is not the first one in the JAR file making it not deploy when using a Feature Model.
I create a branch on Sling Graphql Core *issue/SLING-10900-201* that allows to test it with the latest fixes in graphql-java. These are the instructions.

 
 # Checkout my branch: **issue/manifest-mf.order** from Github: https://github.com/schaefa/graphql-java/tree/issue/manifest-mf.order
 # Go to its folder
 # Change to Java 11
 # Set release version with: `export RELEASE_VERSION="20.1-SNAPSHOT"`
 # Build with: `./gradlew clean publishToMavenLocal  -x signGraphqlJavaPublication`
 # Copy the folder **com/graphql-java/graphql-java/20.1-SNAPSHOT** from your local .m2 repository to a folder **respository** inside the Sling Graphql Core
 ## Make sure all the sub folders are created or copied to there to (this is the path to the JAR file: `respository/com/graphql-java/graphql-java/20.1-SNAPSHOT/graphql-java-20.1-SNAPSHOT.jar`)

 

> Update graphl-java to version 17
> --------------------------------
>
>                 Key: SLING-10900
>                 URL: https://issues.apache.org/jira/browse/SLING-10900
>             Project: Sling
>          Issue Type: Improvement
>          Components: GraphQL
>            Reporter: Radu Cotescu
>            Assignee: Andreas Schaefer
>            Priority: Major
>             Fix For: GraphQL Core 0.0.16
>
>
> {{graphql-java}} 17 brings a set of performance improvements [0] which could benefit the GraphQL Core bundle:
> * [2067|https://github.com/graphql-java/graphql-java/pull/2067] Support for Streams and Iterators
> * Dramatic performance improvements in GraphQLSchema building
> * Dramatic performance improvements in DataFetchingFieldSelectionSet
> * Dramatic performance improvements in large query validation
> [0] - https://github.com/graphql-java/graphql-java/releases/tag/v17.0



--
This message was sent by Atlassian Jira
(v8.20.10#820010)