[GitHub] [iceberg] hililiwei commented on a diff in pull request #6394: Flink: Port Support read options in flink source to 1.14 & 1.16

[GitBox <gi...@apache.org>]

hililiwei commented on code in PR #6394:
URL: https://github.com/apache/iceberg/pull/6394#discussion_r1044146164


##########
flink/v1.15/flink/src/main/java/org/apache/iceberg/flink/FlinkConfParser.java:
##########
@@ -35,7 +34,7 @@ class FlinkConfParser {
   private final ReadableConfig readableConfig;
 
   FlinkConfParser(Table table, Map<String, String> options, ReadableConfig readableConfig) {
-    this.tableProperties = table == null ? Maps.newHashMap() : table.properties();
+    this.tableProperties = table.properties();

Review Comment:
   Reverted https://github.com/apache/iceberg/pull/5967#discussion_r1043812449
   cc @stevenzwu 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org