You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/03/10 22:42:16 UTC

[kudu-CR] Replace uses of gutil/atomicops with c++11 atomics

Todd Lipcon has posted comments on this change.

Change subject: Replace uses of gutil/atomicops with c++11 atomics
......................................................................


Patch Set 3:

just a note on this in case we come back to it at some point: I found a report that when chromium tried to switch from the inline-asm based atomics to std::atomic, they saw a big perf regression in some benchmarks. So, this may not be a great idea unless we take a lot of care.

-- 
To view, visit http://gerrit.cloudera.org:8080/1842
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I249b64ff5efd6c8acbd2c6ff0811f66ff2c4d73f
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No