You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by GitBox <gi...@apache.org> on 2022/04/05 09:53:22 UTC

[GitHub] [wicket] renoth opened a new pull request, #508: Add Resource key to be logged on Warning in Localizer.java

renoth opened a new pull request, #508:
URL: https://github.com/apache/wicket/pull/508

   Suggestion: It would be very helpful to log the Resource key as well to easier identify the problem. 
   
   Is this be security-sensitive? Can this be exploited somehow?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [wicket] martin-g commented on pull request #508: [WICKET-6972] Add Resource key to be logged on Warning in Localizer.java

Posted by GitBox <gi...@apache.org>.
martin-g commented on PR #508:
URL: https://github.com/apache/wicket/pull/508#issuecomment-1100101048

   Thank you, @renoth !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [wicket] martin-g merged pull request #508: [WICKET-6972] Add Resource key to be logged on Warning in Localizer.java

Posted by GitBox <gi...@apache.org>.
martin-g merged PR #508:
URL: https://github.com/apache/wicket/pull/508


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [wicket] martin-g commented on pull request #508: Add Resource key to be logged on Warning in Localizer.java

Posted by GitBox <gi...@apache.org>.
martin-g commented on PR #508:
URL: https://github.com/apache/wicket/pull/508#issuecomment-1094736272

   @renoth Thanks for the PR!
   I think it is safe to log the key.
   
   We also need a ticket in JIRA for the release changelog. Once you have a ticket id please update the PR title and the commit message with it. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@wicket.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org