[GitHub] [flink] luoyuxia commented on a change in pull request #19017: [FLINK-26542][hive] fix "schema of both sides of union should match" exception with Hive dialect

[GitBox <gi...@apache.org>]

luoyuxia commented on a change in pull request #19017:
URL: https://github.com/apache/flink/pull/19017#discussion_r841055875



##########
File path: flink-connectors/flink-connector-hive/src/test/resources/query-test/join.q
##########
@@ -26,7 +26,7 @@ select * from foo left semi join bar on foo.y=bar.i;
 
 select * from (select a.value, a.* from (select * from src) a join (select * from src) b on a.key = b.key) t;
 
-[+I[val1, 1], +I[val2, 2], +I[val3, 3]]
+[+I[val1, 1, val1], +I[val2, 2, val2], +I[val3, 3, val3]]

Review comment:
       Run the sql in Hive CLI, the result is 
   `[+I[val1, 1, val1], +I[val2, 2, val2], +I[val3, 3, val3]]`.
   So, make the change for the previous is wrong




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org