You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Daniel Shahaf <da...@elego.de> on 2012/07/31 12:12:02 UTC

Re: [Issue 4031] is-fresh-txn-root in FSFS rev files

sf@tigris.org wrote on Tue, Jul 31, 2012 at 01:33:51 -0700:
> http://subversion.tigris.org/issues/show_bug.cgi?id=4031
> 
> 
> 
> User sf changed the following:
> 
>                 What    |Old value                 |New value
> ================================================================================
>                 Priority|P3                        |P2
> --------------------------------------------------------------------------------
>         Target milestone|---                       |1.8.0
> --------------------------------------------------------------------------------
> 
> 
> 
> 
> ------- Additional comments from sf@tigris.org Tue Jul 31 01:33:50 -0700 2012 -------
> With Daniel's fix for #4129, this will cause a verification error: If a root
> nodes' (rN) predecessor (rN-1) has the flag set, it will not report its revision
> (N-1) but it's respective predecessor's revision (N-2).
> 

I'm lost, my fix simply looks up the node-rev for / in successive
revisions and asks for the 'pred' field, it doesn't care at all about
the is-fresh-txn-root field, why are you saying it's related?

> Raising prio to P2, setting milestone to 1.8.

Re: [Issue 4031] is-fresh-txn-root in FSFS rev files

Posted by Philip Martin <ph...@wandisco.com>.
Daniel Shahaf <da...@elego.de> writes:

> sf@tigris.org wrote on Tue, Jul 31, 2012 at 01:33:51 -0700:
>> With Daniel's fix for #4129, this will cause a verification error: If
>> a root nodes' (rN) predecessor (rN-1) has the flag set, it will not
>> report its revision (N-1) but it's respective predecessor's revision
>> (N-2).
>> 
>
> I'm lost, my fix simply looks up the node-rev for / in successive
> revisions and asks for the 'pred' field, it doesn't care at all about
> the is-fresh-txn-root field, why are you saying it's related?

Although the 'pred' field appears to be set correctly the presence of
'is-fresh-txn-root' interferes with the calculation of the predecessor
revision.

-- 
Certified & Supported Apache Subversion Downloads:
http://www.wandisco.com/subversion/download