You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by pe...@apache.org on 2010/09/08 03:09:24 UTC
svn commit: r993570 -
/wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/http/WebRequest.java
Author: pete
Date: Wed Sep 8 01:09:24 2010
New Revision: 993570
URL: http://svn.apache.org/viewvc?rev=993570&view=rev
Log:
fix broken test if web request is "ajax". The test for ajax expected a request header to contain the value "true" but in fact there are more values like "yes", "wicket-ajax" and so forth.
this will break a few test cases which are wrong anyway, so please don't hate me :-)
Modified:
wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/http/WebRequest.java
Modified: wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/http/WebRequest.java
URL: http://svn.apache.org/viewvc/wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/http/WebRequest.java?rev=993570&r1=993569&r2=993570&view=diff
==============================================================================
--- wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/http/WebRequest.java (original)
+++ wicket/trunk/wicket-request/src/main/java/org/apache/wicket/request/http/WebRequest.java Wed Sep 8 01:09:24 2010
@@ -26,6 +26,7 @@ import javax.servlet.http.Cookie;
import org.apache.wicket.request.IRequestParameters;
import org.apache.wicket.request.Request;
import org.apache.wicket.request.Url;
+import org.apache.wicket.util.string.Strings;
/**
@@ -114,7 +115,7 @@ public abstract class WebRequest extends
*/
public boolean isAjax()
{
- return "true".equalsIgnoreCase(getHeader(HEADER_AJAX)) ||
+ return (Strings.isEmpty(getHeader(HEADER_AJAX)) == false) ||
getRequestParameters().getParameterValue(PARAM_AJAX).toBoolean(false);
}