You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/11/12 01:49:04 UTC

[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #7754: fixing javadoc to compatible with jdk8 source

Jackie-Jiang commented on a change in pull request #7754:
URL: https://github.com/apache/pinot/pull/7754#discussion_r747926014



##########
File path: pom.xml
##########
@@ -1417,15 +1437,6 @@
           <artifactId>maven-dependency-plugin</artifactId>
           <version>2.8</version>
         </plugin>
-        <plugin>
-          <groupId>org.apache.maven.plugins</groupId>
-          <artifactId>maven-javadoc-plugin</artifactId>
-          <version>3.2.0</version>
-          <configuration>
-            <!-- Remove this after fixing all javadoc warnings -->
-            <doclint>none</doclint>

Review comment:
       Does it work if we add `<source>${jdk.version}</source>` to it?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org