You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/06/03 23:02:24 UTC
[GitHub] [superset] junlincc opened a new issue #14977: [native-filters]upscope chart if the filter uses a different dataset?
junlincc opened a new issue #14977:
URL: https://github.com/apache/superset/issues/14977
When creating a new filter, in the scoping tab, should we uncheck the checkbox if the chart is using a different dataset than the filter uses. In this case, the default radio select should be set in `Apply to specific panels`.
Currently with the new out of scope filter section, even if a filter is completely incompatible with a chart, user can still scope it and the incompatible filter would show in the scoped section(on the top open by default), which is somewhat confusing.
<img width="1784" alt="Screen Shot 2021-06-03 at 3 56 29 PM" src="https://user-images.githubusercontent.com/67837651/120722508-ad784680-c484-11eb-92e2-d7055a4ecd26.png">
@villebro @kgabryje @michael-s-molina this proposed solution may not be ideal either, anything thoughts team?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on issue #14977: [native-filters]upscope chart if the filter uses a different dataset?
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on issue #14977:
URL: https://github.com/apache/superset/issues/14977#issuecomment-854656454
I can help with the scoping tab.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje closed issue #14977: [native-filters]upscope chart if the filter uses a different dataset?
Posted by GitBox <gi...@apache.org>.
kgabryje closed issue #14977:
URL: https://github.com/apache/superset/issues/14977
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on issue #14977: [native-filters]upscope chart if the filter uses a different dataset?
Posted by GitBox <gi...@apache.org>.
kgabryje commented on issue #14977:
URL: https://github.com/apache/superset/issues/14977#issuecomment-854658800
I agree that it is confusing and the chart is definitely not _in scope_ of those filters. In my opinion we should implicitly exclude from filter's scope charts that use a different dataset than the filter (even when user selects "Apply to all panels"). If user selects "Apply to specific panels", charts that use a different dataset should not be shown in the tree. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on issue #14977: [native-filters]upscope chart if the filter uses a different dataset?
Posted by GitBox <gi...@apache.org>.
villebro commented on issue #14977:
URL: https://github.com/apache/superset/issues/14977#issuecomment-854681758
My suggestion would be as follows:
- Reword the subheader "All panels with this column will be affected by this filter" to "All panels with referencing this dataset will be affected by this filter"
- Do the following pruning to the scoping tree:
1. Add the certification icon to charts that reference the same dataset
2. Show the charts that are referencing a *different* dataset but containing the same column name. These would be unchecked by default, but could be forcefully applied, e.g. in the case where we want to construct a filter from a small static dimension table but should apply to a large fact table. This is a common use case, so it should be possible, but not the default behavior IMO.
3. Hide charts that don't feature the same column name.
A few miscellaneous thoughts:
- Time grain and time column should probably only be applicable to charts with a dataset that features a temporal column (I'd leave this out of scope for now).
- We need to figure out a good way to encode this behavior into the dashboard metadata. Right now I believe we're always recording the excluded charts in the metadata; AFAIK the "Apply to all panels" option isn't explicitly recorded in the metadata and separable from the "Apply to specific panels" option. Let's discuss this more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on issue #14977: [native-filters]upscope chart if the filter uses a different dataset?
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on issue #14977:
URL: https://github.com/apache/superset/issues/14977#issuecomment-854873006
As discussed, let's freeze this issue for now until we have more context to work on a solution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro edited a comment on issue #14977: [native-filters]upscope chart if the filter uses a different dataset?
Posted by GitBox <gi...@apache.org>.
villebro edited a comment on issue #14977:
URL: https://github.com/apache/superset/issues/14977#issuecomment-854681758
My suggestion would be as follows:
- Reword the subheader "All panels with this column will be affected by this filter" to "All panels referencing this dataset will be affected by this filter"
- Do the following pruning to the scoping tree:
1. Add the certification icon to charts that reference the same dataset
2. Show the charts that are referencing a *different* dataset but containing the same column name. These would be unchecked by default, but could be forcefully applied, e.g. in the case where we want to construct a filter from a small static dimension table but should apply to a large fact table. This is a common use case, so it should be possible, but not the default behavior IMO.
3. Hide charts that don't feature the same column name.
A few miscellaneous thoughts:
- Time grain and time column should probably only be applicable to charts with a dataset that features a temporal column (I'd leave this out of scope for now).
- We need to figure out a good way to encode this behavior into the dashboard metadata. Right now I believe we're always recording the excluded charts in the metadata; AFAIK the "Apply to all panels" option isn't explicitly recorded in the metadata and separable from the "Apply to specific panels" option. Let's discuss this more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro edited a comment on issue #14977: [native-filters]upscope chart if the filter uses a different dataset?
Posted by GitBox <gi...@apache.org>.
villebro edited a comment on issue #14977:
URL: https://github.com/apache/superset/issues/14977#issuecomment-854681758
My suggestion would be as follows:
- Reword the subheader "All panels with this column will be affected by this filter" to "All panels referencing this dataset will be affected by this filter"
- Do the following pruning/fine tuning to the scoping tree:
1. Add the certification icon to charts that reference the same dataset
2. Show the charts that are referencing a *different* dataset but containing the same column name. These would be unchecked by default, but could be forcefully applied, e.g. in the case where we want to construct a filter from a small static dimension table but should apply to a large fact table. This is a common use case, so it should be possible, but not the default behavior IMO.
3. Hide charts that don't feature the same column name.
A few miscellaneous thoughts:
- Time grain and time column should probably only be applicable to charts with a dataset that features a temporal column (I'd leave this out of scope for now).
- We need to figure out a good way to encode this behavior into the dashboard metadata. Right now I believe we're always recording the excluded charts in the metadata; AFAIK the "Apply to all panels" option isn't explicitly recorded in the metadata and separable from the "Apply to specific panels" option. Let's discuss this more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org