[GitHub] [helix] junkaixue commented on a diff in pull request #2462: Enabling INFO level for helix logs for TestClusterStatusMonitorLifecycle integration test.

["junkaixue (via GitHub)" <gi...@apache.org>]

junkaixue commented on code in PR #2462:
URL: https://github.com/apache/helix/pull/2462#discussion_r1181900319


##########
helix-core/src/test/java/org/apache/helix/LogHelper.java:
##########
@@ -0,0 +1,26 @@
+package org.apache.helix;
+
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.core.LoggerContext;
+import org.apache.logging.log4j.core.config.Configuration;
+import org.apache.logging.log4j.core.config.LoggerConfig;
+
+/**
+ * Helper class for Logging related stuff.
+ */
+public class LogHelper {

Review Comment:
   This is not needed for new class creation. Just move the function as a private function in that test class.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org