You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Charles Chen (JIRA)" <ji...@apache.org> on 2011/09/02 07:45:09 UTC
[jira] [Created] (HIVE-2426) Test that views with joins work
properly
Test that views with joins work properly
----------------------------------------
Key: HIVE-2426
URL: https://issues.apache.org/jira/browse/HIVE-2426
Project: Hive
Issue Type: Test
Reporter: Charles Chen
With the testcase
{noformat}
drop table invites;
drop table invites2;
create table invites (foo int, bar string) partitioned by (ds string);
create table invites2 (foo int, bar string) partitioned by (ds string);
set hive.mapred.mode=strict;
-- test join views: see HIVE-1989
create view v as select invites.bar, invites2.foo, invites2.ds from invites join invites2 on invites.ds=invites2.ds;
explain select * from v where ds='2011-09-01';
drop view v;
drop table invites;
drop table invites2;
{noformat}
We should not have the partition pruner complain about invites.ds not having a predicate because the predicate invites2.ds='2011-09-01' will be inferred with the ppd transitivity optimization
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2426) Test that views with joins work
properly
Posted by "Charles Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Charles Chen updated HIVE-2426:
-------------------------------
Fix Version/s: 0.9.0
Status: Patch Available (was: Open)
> Test that views with joins work properly
> ----------------------------------------
>
> Key: HIVE-2426
> URL: https://issues.apache.org/jira/browse/HIVE-2426
> Project: Hive
> Issue Type: Test
> Reporter: Charles Chen
> Assignee: Charles Chen
> Fix For: 0.9.0
>
> Attachments: HIVE-2426v2.patch
>
>
> With the testcase
> {noformat}
> drop table invites;
> drop table invites2;
> create table invites (foo int, bar string) partitioned by (ds string);
> create table invites2 (foo int, bar string) partitioned by (ds string);
> set hive.mapred.mode=strict;
> -- test join views: see HIVE-1989
> create view v as select invites.bar, invites2.foo, invites2.ds from invites join invites2 on invites.ds=invites2.ds;
> explain select * from v where ds='2011-09-01';
> drop view v;
> drop table invites;
> drop table invites2;
> {noformat}
> We should not have the partition pruner complain about invites.ds not having a predicate because the predicate invites2.ds='2011-09-01' will be inferred with the ppd transitivity optimization
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2426) Test that views with joins work
properly
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13099674#comment-13099674 ]
Hudson commented on HIVE-2426:
------------------------------
Integrated in Hive-trunk-h0.21 #940 (See [https://builds.apache.org/job/Hive-trunk-h0.21/940/])
HIVE-2426. Test that views with joins work properly.
(Charles Chen via jvs)
jvs : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1166293
Files :
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/UnparseTranslator.java
* /hive/trunk/ql/src/test/queries/clientpositive/join_view.q
* /hive/trunk/ql/src/test/results/clientpositive/join_view.q.out
> Test that views with joins work properly
> ----------------------------------------
>
> Key: HIVE-2426
> URL: https://issues.apache.org/jira/browse/HIVE-2426
> Project: Hive
> Issue Type: Test
> Reporter: Charles Chen
> Assignee: Charles Chen
> Fix For: 0.9.0
>
> Attachments: HIVE-2426.3.patch, HIVE-2426v2.patch
>
>
> With the testcase
> {noformat}
> drop table invites;
> drop table invites2;
> create table invites (foo int, bar string) partitioned by (ds string);
> create table invites2 (foo int, bar string) partitioned by (ds string);
> set hive.mapred.mode=strict;
> -- test join views: see HIVE-1989
> create view v as select invites.bar, invites2.foo, invites2.ds from invites join invites2 on invites.ds=invites2.ds;
> explain select * from v where ds='2011-09-01';
> drop view v;
> drop table invites;
> drop table invites2;
> {noformat}
> We should not have the partition pruner complain about invites.ds not having a predicate because the predicate invites2.ds='2011-09-01' will be inferred with the ppd transitivity optimization
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2426) Test that views with joins work
properly
Posted by "John Sichi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Sichi updated HIVE-2426:
-----------------------------
Attachment: HIVE-2426.3.patch
Made a few minor improvements to the overlap handling code and comments.
> Test that views with joins work properly
> ----------------------------------------
>
> Key: HIVE-2426
> URL: https://issues.apache.org/jira/browse/HIVE-2426
> Project: Hive
> Issue Type: Test
> Reporter: Charles Chen
> Assignee: Charles Chen
> Fix For: 0.9.0
>
> Attachments: HIVE-2426.3.patch, HIVE-2426v2.patch
>
>
> With the testcase
> {noformat}
> drop table invites;
> drop table invites2;
> create table invites (foo int, bar string) partitioned by (ds string);
> create table invites2 (foo int, bar string) partitioned by (ds string);
> set hive.mapred.mode=strict;
> -- test join views: see HIVE-1989
> create view v as select invites.bar, invites2.foo, invites2.ds from invites join invites2 on invites.ds=invites2.ds;
> explain select * from v where ds='2011-09-01';
> drop view v;
> drop table invites;
> drop table invites2;
> {noformat}
> We should not have the partition pruner complain about invites.ds not having a predicate because the predicate invites2.ds='2011-09-01' will be inferred with the ppd transitivity optimization
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2426) Test that views with joins work
properly
Posted by "John Sichi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
John Sichi updated HIVE-2426:
-----------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
+1, passed tests, committed to trunk. Thanks Charles!
> Test that views with joins work properly
> ----------------------------------------
>
> Key: HIVE-2426
> URL: https://issues.apache.org/jira/browse/HIVE-2426
> Project: Hive
> Issue Type: Test
> Reporter: Charles Chen
> Assignee: Charles Chen
> Fix For: 0.9.0
>
> Attachments: HIVE-2426.3.patch, HIVE-2426v2.patch
>
>
> With the testcase
> {noformat}
> drop table invites;
> drop table invites2;
> create table invites (foo int, bar string) partitioned by (ds string);
> create table invites2 (foo int, bar string) partitioned by (ds string);
> set hive.mapred.mode=strict;
> -- test join views: see HIVE-1989
> create view v as select invites.bar, invites2.foo, invites2.ds from invites join invites2 on invites.ds=invites2.ds;
> explain select * from v where ds='2011-09-01';
> drop view v;
> drop table invites;
> drop table invites2;
> {noformat}
> We should not have the partition pruner complain about invites.ds not having a predicate because the predicate invites2.ds='2011-09-01' will be inferred with the ppd transitivity optimization
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2426) Test that views with joins work
properly
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13098500#comment-13098500 ]
jiraposter@reviews.apache.org commented on HIVE-2426:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1732/
-----------------------------------------------------------
Review request for hive.
Summary
-------
HIVE-2426 patch 3
This addresses bug HIVE-2426.
https://issues.apache.org/jira/browse/HIVE-2426
Diffs
-----
http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/UnparseTranslator.java 1165909
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/join_view.q PRE-CREATION
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/join_view.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/1732/diff
Testing
-------
Thanks,
John
> Test that views with joins work properly
> ----------------------------------------
>
> Key: HIVE-2426
> URL: https://issues.apache.org/jira/browse/HIVE-2426
> Project: Hive
> Issue Type: Test
> Reporter: Charles Chen
> Assignee: Charles Chen
> Fix For: 0.9.0
>
> Attachments: HIVE-2426.3.patch, HIVE-2426v2.patch
>
>
> With the testcase
> {noformat}
> drop table invites;
> drop table invites2;
> create table invites (foo int, bar string) partitioned by (ds string);
> create table invites2 (foo int, bar string) partitioned by (ds string);
> set hive.mapred.mode=strict;
> -- test join views: see HIVE-1989
> create view v as select invites.bar, invites2.foo, invites2.ds from invites join invites2 on invites.ds=invites2.ds;
> explain select * from v where ds='2011-09-01';
> drop view v;
> drop table invites;
> drop table invites2;
> {noformat}
> We should not have the partition pruner complain about invites.ds not having a predicate because the predicate invites2.ds='2011-09-01' will be inferred with the ppd transitivity optimization
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2426) Test that views with joins work
properly
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095791#comment-13095791 ]
jiraposter@reviews.apache.org commented on HIVE-2426:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1702/
-----------------------------------------------------------
Review request for hive.
Summary
-------
https://issues.apache.org/jira/browse/HIVE-2426
This addresses bug HIVE-2426.
https://issues.apache.org/jira/browse/HIVE-2426
Diffs
-----
http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/UnparseTranslator.java 1163905
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/join_view.q PRE-CREATION
http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/join_view.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/1702/diff
Testing
-------
Thanks,
Charles
> Test that views with joins work properly
> ----------------------------------------
>
> Key: HIVE-2426
> URL: https://issues.apache.org/jira/browse/HIVE-2426
> Project: Hive
> Issue Type: Test
> Reporter: Charles Chen
> Assignee: Charles Chen
> Attachments: HIVE-2426v2.patch
>
>
> With the testcase
> {noformat}
> drop table invites;
> drop table invites2;
> create table invites (foo int, bar string) partitioned by (ds string);
> create table invites2 (foo int, bar string) partitioned by (ds string);
> set hive.mapred.mode=strict;
> -- test join views: see HIVE-1989
> create view v as select invites.bar, invites2.foo, invites2.ds from invites join invites2 on invites.ds=invites2.ds;
> explain select * from v where ds='2011-09-01';
> drop view v;
> drop table invites;
> drop table invites2;
> {noformat}
> We should not have the partition pruner complain about invites.ds not having a predicate because the predicate invites2.ds='2011-09-01' will be inferred with the ppd transitivity optimization
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2426) Test that views with joins work
properly
Posted by "Charles Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Charles Chen updated HIVE-2426:
-------------------------------
Attachment: HIVE-2426v2.patch
> Test that views with joins work properly
> ----------------------------------------
>
> Key: HIVE-2426
> URL: https://issues.apache.org/jira/browse/HIVE-2426
> Project: Hive
> Issue Type: Test
> Reporter: Charles Chen
> Assignee: Charles Chen
> Attachments: HIVE-2426v2.patch
>
>
> With the testcase
> {noformat}
> drop table invites;
> drop table invites2;
> create table invites (foo int, bar string) partitioned by (ds string);
> create table invites2 (foo int, bar string) partitioned by (ds string);
> set hive.mapred.mode=strict;
> -- test join views: see HIVE-1989
> create view v as select invites.bar, invites2.foo, invites2.ds from invites join invites2 on invites.ds=invites2.ds;
> explain select * from v where ds='2011-09-01';
> drop view v;
> drop table invites;
> drop table invites2;
> {noformat}
> We should not have the partition pruner complain about invites.ds not having a predicate because the predicate invites2.ds='2011-09-01' will be inferred with the ppd transitivity optimization
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HIVE-2426) Test that views with joins work
properly
Posted by "Charles Chen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Charles Chen reassigned HIVE-2426:
----------------------------------
Assignee: Charles Chen
> Test that views with joins work properly
> ----------------------------------------
>
> Key: HIVE-2426
> URL: https://issues.apache.org/jira/browse/HIVE-2426
> Project: Hive
> Issue Type: Test
> Reporter: Charles Chen
> Assignee: Charles Chen
>
> With the testcase
> {noformat}
> drop table invites;
> drop table invites2;
> create table invites (foo int, bar string) partitioned by (ds string);
> create table invites2 (foo int, bar string) partitioned by (ds string);
> set hive.mapred.mode=strict;
> -- test join views: see HIVE-1989
> create view v as select invites.bar, invites2.foo, invites2.ds from invites join invites2 on invites.ds=invites2.ds;
> explain select * from v where ds='2011-09-01';
> drop view v;
> drop table invites;
> drop table invites2;
> {noformat}
> We should not have the partition pruner complain about invites.ds not having a predicate because the predicate invites2.ds='2011-09-01' will be inferred with the ppd transitivity optimization
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira