You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by gu...@apache.org on 2026/09/23 05:06:23 UTC
(spark) branch branch-4.x updated: [SPARK-59478][BUILD] Add sbin/start-connect-server.sh to pyspark-connect test module
This is an automated email from the ASF dual-hosted git repository.
HyukjinKwon pushed a commit to branch branch-4.x
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/branch-4.x by this push:
new a51137ec575b [SPARK-59478][BUILD] Add sbin/start-connect-server.sh to pyspark-connect test module
a51137ec575b is described below
commit a51137ec575b3454b2360c17665115303920498a
Author: Nicholas Chammas <ni...@gmail.com>
AuthorDate: Wed Sep 23 14:05:44 2026 +0900
[SPARK-59478][BUILD] Add sbin/start-connect-server.sh to pyspark-connect test module
### What changes were proposed in this pull request?
Explicitly trigger the `pyspark-connect` test module on changes to `sbin/start-connect-server.sh`.
### Why are the changes needed?
This script is called here as part of PR CI: https://github.com/apache/spark/blob/24c15b0383f21b2e80b27435617f16933236491c/.github/workflows/build_and_test.yml#L757
This is run when any `pyspark` module is activated: https://github.com/apache/spark/blob/2d309efaf85b18d932acd837e81e60f83d6bad57/.github/workflows/build_and_test.yml#L110-L115
By adding this sbin script to the `pyspark-connect` module, we in turn activate the `pyspark_connect_old_client` test in the `build_and_test.yml` workflow.
It's a bit of a clunky relationship, and in the future I would like to refactor this so we are doing less in the workflow YAML and more in `sparktestsupport`. But for now, adding this line to the `pyspark-connect` makes the relationship more explicit than the status quo. The status quo is that edits to `start-connect-server.sh` don't match any module, which triggers `root`, and thus builds everything.
The `stop-connect-server.sh` script is not tested by any part of PR CI as far as I can tell, so I've left it alone for now.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
CI
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes #58769 from nchammas/sbin-script-pyspark-connect.
Authored-by: Nicholas Chammas <ni...@gmail.com>
Signed-off-by: Hyukjin Kwon <hy...@databricks.com>
(cherry picked from commit 15dc43e8045ca56ae746cb699a4f019fa09ee0cb)
Signed-off-by: Hyukjin Kwon <hy...@databricks.com>
---
dev/sparktestsupport/modules.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/dev/sparktestsupport/modules.py b/dev/sparktestsupport/modules.py
index 17952adc2fd6..638e9cffcf99 100644
--- a/dev/sparktestsupport/modules.py
+++ b/dev/sparktestsupport/modules.py
@@ -1256,6 +1256,7 @@ pyspark_connect = Module(
dependencies=[pyspark_sql, connect],
source_file_regexes=[
"python/pyspark/sql/connect",
+ "sbin/start-connect-server.sh",
],
python_test_goals=[
# sql doctests
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org